From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Basil L. Contovounesios" via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#57821: 29.0.50; ANSI sequence not filtered in compilation buffer Date: Sun, 18 Sep 2022 19:27:12 +0300 Message-ID: <875yhkodgf.fsf@tcd.ie> References: <87fsgt11w0.fsf@gmail.com> <87bkrg28lu.fsf@gmail.com> <877d23a7mh.fsf@gnus.org> <87tu55zzll.fsf@gmail.com> <87mtax55v7.fsf@gnus.org> <8735co4zse.fsf@gmail.com> <87k06026bw.fsf@gnus.org> <87y1ug3ik4.fsf@gmail.com> <87fsgopv5j.fsf@tcd.ie> <87tu543cuu.fsf@gmail.com> Reply-To: "Basil L. Contovounesios" Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2047"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 57821@debbugs.gnu.org, Lars Ingebrigtsen To: Matthias Meulien Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 18 18:28:20 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oZx9X-0000Lm-6k for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 18 Sep 2022 18:28:19 +0200 Original-Received: from localhost ([::1]:57882 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oZx9W-0003CA-9K for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 18 Sep 2022 12:28:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34236) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZx9G-0003Bn-P8 for bug-gnu-emacs@gnu.org; Sun, 18 Sep 2022 12:28:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:52036) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oZx9G-0003T7-HI for bug-gnu-emacs@gnu.org; Sun, 18 Sep 2022 12:28:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oZx9F-0004zb-Ua for bug-gnu-emacs@gnu.org; Sun, 18 Sep 2022 12:28:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Sep 2022 16:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57821 X-GNU-PR-Package: emacs Original-Received: via spool by 57821-submit@debbugs.gnu.org id=B57821.166351844419135 (code B ref 57821); Sun, 18 Sep 2022 16:28:01 +0000 Original-Received: (at 57821) by debbugs.gnu.org; 18 Sep 2022 16:27:24 +0000 Original-Received: from localhost ([127.0.0.1]:51114 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZx8d-0004yZ-Tj for submit@debbugs.gnu.org; Sun, 18 Sep 2022 12:27:24 -0400 Original-Received: from mail-ed1-f42.google.com ([209.85.208.42]:40943) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZx8a-0004yI-D4 for 57821@debbugs.gnu.org; Sun, 18 Sep 2022 12:27:22 -0400 Original-Received: by mail-ed1-f42.google.com with SMTP id w28so14079388edi.7 for <57821@debbugs.gnu.org>; Sun, 18 Sep 2022 09:27:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date; bh=GTr8mtix2cjEQb4sg0ArXCUFa7IipAoDA+tghLJuAmw=; b=RIQzTnPpLExh5MWP7pfdCHI3mEHNajpzEK5a+1HLqxwy64/0p3DOcFOKUC8XLciK2m dt3/P3frVW59wBgBCROOVMbORLMVHWz9uHuEqx9u1/kJru+Aj3bZ479pNqz/lkKD7dC5 G8s1SjgQjtELiSaqSxmkJhGhdr5+Ru3nUoRymgmRyM7zbQdtG7cevtI/wNKMe5B5+0Ve P4e61oVxyO5m/91MHy8DeVFIAZf24cU4OzfuWpKFzyYFsUmH561PkM6Mnr/Y4DfEjICP ePBdBsnRB/xV6KvJVvcfSyrHfJyfDF1S5cM8RVzqxCODSFcmgRRMAL5Cz1raimnAhwVe OUJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date; bh=GTr8mtix2cjEQb4sg0ArXCUFa7IipAoDA+tghLJuAmw=; b=FNVMQWBsoANrjbK5zUEmY3+OYw4rwPrwy/PKwatqtqr1+YOIfDHwnfDMWwqQej6U/7 cnm0X2b0inEfhYzvrjaXctuW2hJ1wmt8z5JM+CANzfrlT3FGCWn7z91Y+QhOnULHdmkG +zNWDklGi5autFqEU5gUC7XpTIj1gL16ou30I5I1lI2h+GtUROSU3DiG7VZYGej/Kft2 /FnPeaX71X1zHIgzVQAvLFW5VsJtjAKDRpe7ejY5FyLmxd1cakIo2/+4QFxfZi3xbTAy Bc+MSAXqQmyomIh1fBMsbFNelOqWvApVCyjFZnej4YtNxJJbcW39d1aoeBqwHgdiFAiS o82Q== X-Gm-Message-State: ACrzQf20YFZex9mEqFsAv7W44y0REeGb6G9t0e2DZAE/PkrE7JuhYTqL UrMVVJHrnL0GZsJDGDXuK+9o0w== X-Google-Smtp-Source: AMsMyM4tJq9tuEVqVlPcgookuhRM2CCaAN9o6W5jKcMhUTHV8a/Snfcr2Cuvjcv3bZvNLiZJo7fzew== X-Received: by 2002:a05:6402:22a9:b0:453:9ae3:a18b with SMTP id cx9-20020a05640222a900b004539ae3a18bmr6697873edb.242.1663518434291; Sun, 18 Sep 2022 09:27:14 -0700 (PDT) Original-Received: from localhost ([2a02:587:326b:702d:bb17:174a:b974:3f1]) by smtp.gmail.com with ESMTPSA id x3-20020a170906710300b007317f017e64sm14054972ejj.134.2022.09.18.09.27.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 18 Sep 2022 09:27:13 -0700 (PDT) In-Reply-To: <87tu543cuu.fsf@gmail.com> (Matthias Meulien's message of "Sun, 18 Sep 2022 17:45:45 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:243004 Archived-At: Matthias Meulien [2022-09-18 17:45 +0200] wrote: > "Basil L. Contovounesios" writes: > >> Two spaces after a full stop, here and in the other patches. > > Thanks for your careful reading! I failed to found places with this > problem in the other patches... In the Commentary section of osc.el: ;; Interpretation of OSC (Operating System Commands) escape ;; sequences. Handlers for OSC 2, 7 and 8 (for window title, current ^^ ;; directory and hyperlinks respectively) are provided. ;; The function `osc-compilation-filter' can be added to ;; `compilation-filter-hook' to collect OSC sequences in compilation ;; buffers. The variable `osc-for-compilation-buffer' tells what to do ^^ ;; with collected sequences. >>> +all sequences are filtered out. >>> + >>> +A handler for OSC 2, the command to set a window title, is provided. >> >> Also OSC 7 and 8, no? > > Sure, I thought it's a new handler was implicit in the NEWS file; Saying "new package 'osc'" followed by "a handler for OSC 2 is provided" sounds like that is the only handler provided by the new 'osc' package, or at least like the entry is talking about what is true rather than what is new. > handlers were already mentionned in NEWS.28. But let's try to be more > precise. The new text LGTM. > Here is a patch improving the news entry and fixing the defalias for > variables you mentionned in your other message. I didn't tried to solve > the alias for the button; I'll have to learn more about aliases first, I > thought that just "maintaining" the symbol would be ok. Symbols have three distinct slots in which values can be stored: the value slot, the function slot, and the property list slot. defalias changes the function slot, so it's only appropriate for symbols which are meant to be called as functions. defvaralias changes the value slot, so it's only appropriate for symbols which are meant to be used as variables. Button types are just symbols that record certain information in their property list, like which function to call when clicked, which face to be fontified with, etc. So in this case it's the button type's plist that needs to be aliased/cloned. AFAIK there is no built-in incantation for this, so I guess you need to resort to either: (a) manually calling symbol-plist + setplist; (b) defining one button type as the supertype of the other; or (c) not bothering with the compatibility alias at all. Thanks, -- Basil