From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "J.P." Newsgroups: gmane.emacs.bugs Subject: bug#57956: 29.0.50; Add minimal authorization support to sasl-scram-rfc Date: Wed, 21 Sep 2022 23:23:43 -0700 Message-ID: <875yhggc5s.fsf__25726.0786181845$1663828113$gmane$org@neverwas.me> References: <871qs62o0y.fsf@neverwas.me> <87tu52awv9.fsf@gnus.org> <87a66ssw7s.fsf@neverwas.me> <871qs4mv7a.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14341"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , 57956@debbugs.gnu.org, Magnus Henoch , emacs-erc@gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 22 08:28:25 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1obFhA-0003Wb-JH for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 22 Sep 2022 08:28:25 +0200 Original-Received: from localhost ([::1]:51032 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1obFh9-0001FS-2C for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 22 Sep 2022 02:28:23 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45362) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1obFcz-00083N-3W for bug-gnu-emacs@gnu.org; Thu, 22 Sep 2022 02:24:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36870) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1obFcy-0005YE-Or for bug-gnu-emacs@gnu.org; Thu, 22 Sep 2022 02:24:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1obFcy-0007MN-JX for bug-gnu-emacs@gnu.org; Thu, 22 Sep 2022 02:24:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "J.P." Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 22 Sep 2022 06:24:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57956 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 57956-submit@debbugs.gnu.org id=B57956.166382784028239 (code B ref 57956); Thu, 22 Sep 2022 06:24:04 +0000 Original-Received: (at 57956) by debbugs.gnu.org; 22 Sep 2022 06:24:00 +0000 Original-Received: from localhost ([127.0.0.1]:35942 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1obFct-0007LO-P6 for submit@debbugs.gnu.org; Thu, 22 Sep 2022 02:24:00 -0400 Original-Received: from mail-108-mta35.mxroute.com ([136.175.108.35]:46365) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1obFcr-0007LA-SU for 57956@debbugs.gnu.org; Thu, 22 Sep 2022 02:23:58 -0400 Original-Received: from mail-111-mta2.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta35.mxroute.com (ZoneMTA) with ESMTPSA id 18363dddb4f0002b7a.001 for <57956@debbugs.gnu.org> (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Thu, 22 Sep 2022 06:23:47 +0000 X-Zone-Loop: c624d11e6551379f1546c1f577d32d107db1dad4f084 X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=9cuOrMy1h5vs9C0mceCyG8u3eWpAfjQMJifpOJQZhTc=; b=a18z+METGg0H/StCSZWPhIVi9Q 6B9WAQXWx8f0cEtLiuXaATjKhi1DaPgx+dBB6RzkOzJn4I/vSSK9FCInErobSMqEQp/6illle8mY5 2PU6TXMt0FYnfjAaDnVMyfXpMu0e7mJkDoJxMoD4XKqRkXxBEZV1X0u706o7dREJPFazCZpoL+5Gp xGjAayfAmy22i1quHlwZd2or+niSWCsIn8BBq70z1GMMTIZRrK3U5mYTPZguNeY/brCaoLJ4cx9p9 vo/5W26FXJJL/kU/AZlr7lYsNxkWfLV0J3S7c1xcD7FqWxqkRzEFIvJFo+4aG28NJfWz4E5OZorWw 9qe8GfmQ==; In-Reply-To: <871qs4mv7a.fsf@posteo.net> (Philip Kaludercic's message of "Wed, 21 Sep 2022 18:35:53 +0000") X-Authenticated-Id: masked@neverwas.me X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:243394 Archived-At: Philip Kaludercic writes: > "J.P." writes: > >> is obviously an internal function. Does that matter? Would you rather we >> export it (as in rename it or alias it) beforehand (IOW, now)? > > I'd rather not add "internal functions" to Compat, at least in a way > that it would be exposed as part of the official Compat interface. That > being said, I am not familiar with the feature being discussed here, The feature (also a bug fix) being discussed here concerns the final client-side step of the SCRAM protocol. Basically, it computes a challenge from the server and packs the answer into an outgoing reply. > so maybe an exception has to be made? No reason to. We can keep it internal (the "final step" function, that is) and backport its logic, its helpers, and all (two-ish?) public functions that call it (I'm likely adding a third). Alternatively, we could - have ERC restrict this feature to users of Emacs 29+, or - stick with the status quo and manage this particular case manually via erc-comapt.el [1]. I'd be fine with any of the above, really. [1] https://lists.gnu.org/archive/html/emacs-erc/2022-09/txtCuKCxr1b72.txt