From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jonas Bernoulli Newsgroups: gmane.emacs.bugs Subject: bug#58252: 29.0.50; Docstrings generated by defclass may be to wide Date: Sun, 02 Oct 2022 23:17:15 +0200 Message-ID: <875yh2q61w.fsf@bernoul.li> References: <87a66emh17.fsf@bernoul.li> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13964"; mail-complaints-to="usenet@ciao.gmane.io" To: Stefan Kangas , 58252@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 02 23:18:21 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1of6Ls-0003Kv-2e for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 02 Oct 2022 23:18:20 +0200 Original-Received: from localhost ([::1]:48208 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1of6Lq-0003bW-8V for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 02 Oct 2022 17:18:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55756) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1of6La-0003ax-GS for bug-gnu-emacs@gnu.org; Sun, 02 Oct 2022 17:18:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49131) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1of6La-0004Bp-7O for bug-gnu-emacs@gnu.org; Sun, 02 Oct 2022 17:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1of6LZ-0006Tq-U0 for bug-gnu-emacs@gnu.org; Sun, 02 Oct 2022 17:18:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jonas Bernoulli Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Oct 2022 21:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58252 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 58252-submit@debbugs.gnu.org id=B58252.166474544224861 (code B ref 58252); Sun, 02 Oct 2022 21:18:01 +0000 Original-Received: (at 58252) by debbugs.gnu.org; 2 Oct 2022 21:17:22 +0000 Original-Received: from localhost ([127.0.0.1]:48209 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1of6Kw-0006Su-8j for submit@debbugs.gnu.org; Sun, 02 Oct 2022 17:17:22 -0400 Original-Received: from mail.hostpark.net ([212.243.197.30]:57528) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1of6Kt-0006Sl-N1 for 58252@debbugs.gnu.org; Sun, 02 Oct 2022 17:17:20 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 8B819162BF; Sun, 2 Oct 2022 23:17:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=bernoul.li; h= content-type:content-type:mime-version:message-id:date:date :references:in-reply-to:subject:subject:from:from:received :received; s=sel2011a; t=1664745437; bh=EtAMsPy/QW7D8FJPtJZcji21 30zgCSyrVGNXtn1Oo1M=; b=eV2STyIIDyNFoq6Mzo8s7iZFbHSLopqvGskAAL0n rw5YyDWnBdUgwObEfojU0cXKi9ndGsq+FkKjgNYAOsq8YIWjgo5/fwxG7Jld5/hJ /vP2M20GBk6TdWeX/lEQkRYgO3GmCZu3otwcxVeMqKngCrQ30+wTlkSvIDMlIl00 yfs= X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Original-Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10224) with ESMTP id iCV9tD4FrVSI; Sun, 2 Oct 2022 23:17:17 +0200 (CEST) Original-Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 5B98016483; Sun, 2 Oct 2022 23:17:17 +0200 (CEST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:244264 Archived-At: Stefan Kangas writes: > Jonas Bernoulli writes: > >> The docstrings generated by helper functions of defclass are to wide >> if the name of the class is wide enough. For example, the docstring >> for `emacsql-sqlite-builtin-connection--eieio-childp' is: >> >> ,---- >> | emacsql-sqlite-builtin-connection--eieio-childp is a byte-compiled >> | Lisp function in `emacsql-sqlite-builtin.el'. >> | >> | (emacsql-sqlite-builtin-connection--eieio-childp OBJ) >> | >> | Return non-nil if OBJ is an object of type `emacsql-sqlite-builtin-connection' or a subclass. >> `---- >> >> This affects at least the --eieio-childp, -child-p, -list-p and -p >> functions. > > Thanks, I pushed a fix for this (commit 0a40120b40). Could you please > test it? > > If it's still not working, please give examples of docstrings where it > doesn't. The docstrings of these functions are no longer to wide, but I still get the same warning, ,---- | In toplevel form: | emacsql-sqlite-builtin.el:28:5: Warning: docstring wider than 80 | characters `---- M-x apropos RET emacsql-sqlite-builtin-connection RET gives me ,---- | emacsql-sqlite-builtin-connection | Function: Create a new object of class type | Variable: (not documented) | Value: emacsql-sqlite-builtin-connection | Properties: cl-deftype-satisfies compiler-macro | byte-obsolete-variable cl--class variable-documentation | emacsql-sqlite-builtin-connection--anon-cmacro | Function: (not documented) | Properties: function-history | emacsql-sqlite-builtin-connection--eieio-childp | Function: Return non-nil if OBJ is an object of type | emacsql-sqlite-builtin-connection-child-p | Function: Return non-nil if OBJ is an object of type | Properties: byte-obsolete-info | emacsql-sqlite-builtin-connection-list-p | Function: Test OBJ to see if it a list of objects which are a child | of type | Properties: byte-obsolete-info | emacsql-sqlite-builtin-connection-p | Function: Return non-nil if OBJ is an object of type `---- The information that is shown when following the various "Properties" links is wider than 80 characters, but I wouldn't expect any warning about that. Maybe the warning should include information about which docstring(s) are too wide?