From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#57400: 29.0.50; Support sending patches from VC directly Date: Thu, 13 Oct 2022 19:44:27 +0000 Message-ID: <875ygnjyp0.fsf@posteo.net> References: <84v8qgn1z9.fsf@iki.fi> <87h71zo3p8.fsf@posteo.net> <87sfljmgwz.fsf@posteo.net> <87y1twvima.fsf@posteo.net> <84sfk2p846.fsf@iki.fi> <87h70i9ntt.fsf@posteo.net> <87edvl6vbj.fsf@gmail.com> <8735c1nn3y.fsf@posteo.net> <877d1d6rcy.fsf@gmail.com> <867d1cjc8w.fsf@mail.linkov.net> <87o7unkggk.fsf@posteo.net> <86edvids93.fsf@mail.linkov.net> <87zge52nx0.fsf@posteo.net> <86sfjvqz68.fsf@mail.linkov.net> <87edvecg45.fsf@posteo.net> <86r0ze2ldb.fsf@mail.linkov.net> <871qrchzli.fsf@posteo.net> <86tu471vhq.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12336"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Robert Pluim , 57400@debbugs.gnu.org, Antoine Kalmbach To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 13 21:45:19 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oj48t-0002zz-I8 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Oct 2022 21:45:19 +0200 Original-Received: from localhost ([::1]:50526 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oj48s-0006QH-F1 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Oct 2022 15:45:18 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49050) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oj48d-0006OZ-CG for bug-gnu-emacs@gnu.org; Thu, 13 Oct 2022 15:45:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35945) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oj48d-0002zk-3t for bug-gnu-emacs@gnu.org; Thu, 13 Oct 2022 15:45:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oj48c-0003Vw-Dv for bug-gnu-emacs@gnu.org; Thu, 13 Oct 2022 15:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Oct 2022 19:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57400 X-GNU-PR-Package: emacs Original-Received: via spool by 57400-submit@debbugs.gnu.org id=B57400.166569028013461 (code B ref 57400); Thu, 13 Oct 2022 19:45:02 +0000 Original-Received: (at 57400) by debbugs.gnu.org; 13 Oct 2022 19:44:40 +0000 Original-Received: from localhost ([127.0.0.1]:35023 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oj48F-0003V2-KD for submit@debbugs.gnu.org; Thu, 13 Oct 2022 15:44:39 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:42225) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oj48D-0003Uo-M3 for 57400@debbugs.gnu.org; Thu, 13 Oct 2022 15:44:38 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 660E1240028 for <57400@debbugs.gnu.org>; Thu, 13 Oct 2022 21:44:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1665690271; bh=T4D50hW9X8PDtS45i+K02eT8DWNFG7TdYpAkj722I9w=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=JnREKRb7Wn7/8D3sWZrIeQuMSiO22wuqlneVBN+igM3cljppuE0n5SUgdiJFZT9xS 9mWR3ZSwQBECtX5PQ8G7Gd5Hg+VTsTgqyYgrf+p/e0Oc91o6IVFgeyeTIVEllfU0Sz SsgpaKzr5cOdrIBqJFEKzzLyj9pq1l7toPcGVn8lWcKPS3/N3EutHz1WWpsNa3SHSg DDg061SN+GsNM9+48NFIdtfYhhMKxUpZYW+ti+4l6Il81hkXH1QvjNUqU6yWkm7RCO AHR3fe1zpwxAisAjeJNB+hvQJo1VSKhpO+QkObf+l9JjXMWcUnbHAmw5ZCvY1OQ/lc lxz+hE2SJ4mrg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MpKj80xWRz9rxT; Thu, 13 Oct 2022 21:44:28 +0200 (CEST) In-Reply-To: <86tu471vhq.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 13 Oct 2022 20:30:57 +0300") Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:245351 Archived-At: Juri Linkov writes: >>>> I have done all of the above and am prepared to push the changes, but >>>> before I do I was wondering if anyone would have any objections to the >>>> following changes to vc-git.el: >>> >>> Indeed, abbreviated commits are more usable. But please wait a little >>> for more comments. >> >> Also note that this change would also only affect working-revision and >> previous-revision. If necessary or preferred, I could also modify the >> changes to only affect working-revision. > > Nicer names would be better everywhere, including previous-revision. > But: In my recent mail to RMS I raised questions about 'C-u C-x v ='. > And when I tried your patch then the default value for "HEAD" > often is very strange. For example, try to type 'C-u C-x v =' > on the file lisp/paren.el. Here is what it shows: > > Older revision [remotes/origin/scratch/eglot2emacs~488]: > > I wonder where comes "eglot2emacs" from when the current branch is master? Hmm, it looks like Git tried to find a symbolic reference at any cost, so it found some branch found a relative commit. I'll try and find out if there is a way to avoid this, and only use symbolic references if there is no positional offset.