From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "J.P." Newsgroups: gmane.emacs.bugs Subject: bug#58985: 29.0.50; Have auth-source-pass behave more like other back ends Date: Sun, 13 Nov 2022 07:29:55 -0800 Message-ID: <875yfiq3d8.fsf__8724.98838450468$1668353484$gmane$org@neverwas.me> References: <87wn8cb0ym.fsf@neverwas.me> <874jvdardn.fsf__3771.40490324877$1667692584$gmane$org@neverwas.me> <87pme09vis.fsf@gmx.de> <87a653z7dl.fsf@neverwas.me> <878rkjl1vd.fsf@disroot.org> <877d026uym.fsf@neverwas.me> <87tu35eehq.fsf@disroot.org> <87bkpcu74w.fsf@neverwas.me> <875yfkdwlm.fsf@disroot.org> <874jv3nwmc.fsf@disroot.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11217"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Damien Cassou , =?UTF-8?Q?Bj=C3=B6rn?= Bidar , emacs-erc@gnu.org, Michael Albinus , 58985@debbugs.gnu.org To: Akib Azmain Turja Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Nov 13 16:31:17 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ouEx1-0002gF-R4 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 13 Nov 2022 16:31:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ouEwo-0004j0-WE; Sun, 13 Nov 2022 10:31:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ouEwo-0004ir-96 for bug-gnu-emacs@gnu.org; Sun, 13 Nov 2022 10:31:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ouEwo-00023I-10 for bug-gnu-emacs@gnu.org; Sun, 13 Nov 2022 10:31:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ouEwn-0001E0-Ni for bug-gnu-emacs@gnu.org; Sun, 13 Nov 2022 10:31:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "J.P." Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 13 Nov 2022 15:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58985 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58985-submit@debbugs.gnu.org id=B58985.16683534094642 (code B ref 58985); Sun, 13 Nov 2022 15:31:01 +0000 Original-Received: (at 58985) by debbugs.gnu.org; 13 Nov 2022 15:30:09 +0000 Original-Received: from localhost ([127.0.0.1]:52351 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouEvw-0001Cn-Cs for submit@debbugs.gnu.org; Sun, 13 Nov 2022 10:30:08 -0500 Original-Received: from mail-108-mta134.mxroute.com ([136.175.108.134]:36991) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ouEvt-0001Ak-LK for 58985@debbugs.gnu.org; Sun, 13 Nov 2022 10:30:07 -0500 Original-Received: from mail-111-mta2.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta134.mxroute.com (ZoneMTA) with ESMTPSA id 184719c98260006e99.002 for <58985@debbugs.gnu.org> (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Sun, 13 Nov 2022 15:29:58 +0000 X-Zone-Loop: 8e191f41084bf3a7c6cc21daf1132f7c40c4accd255f X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=jXUsRkRkjBjG3zSgiHEsBs4TpO5C3Vgw4Kn8CCyHPlM=; b=Ppcpu7k4tuSfKTIjqBwlJdDdzS fAYHTIag8jeUOxJxV0Is8tGGxB7m4KODsqSciwVmo9+Dyx57xMehaN7cgntpnWubhbKd3Vc3Xe1R2 wm0eVL5rr4B6obLwpxuohtoMEQdW5eWBdbwblgOy8y3r7KmsfArHFN9ITY+zu2FI4R7hwZQy2IIJ6 y/3i7rSnM0BWA1CJdWKJwWkwOpsrypv2cHAKj+xNF5OlgJDTDRgT68PtLcMIaQlE3mVKZC48SkDL5 zrDhhYYVP+JsdMRynzC9R4eZH6R1XQmVDnWLVfuSlmD20PWOZDLXQvI/R9jVGDGobvL7zM4CkMhjO x77bSPbw==; In-Reply-To: <874jv3nwmc.fsf@disroot.org> (Akib Azmain Turja's message of "Sun, 13 Nov 2022 13:26:19 +0600") X-Authenticated-Id: masked@neverwas.me X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247784 Archived-At: Akib Azmain Turja writes: > Akib Azmain Turja via "Bug reports for GNU Emacs, the Swiss army knife > of text editors" writes: > >> "J.P." writes: >> >>> While I certainly welcome the assiduous scrutinizing of Emacs lisp >>> mechanics and technique (truly), I was mainly hoping that, as an avid >>> pass user, you would also help flesh out the precise effects of the >>> behavior introduced by these changes and hopefully share some insights >>> into how they might impact day-to-day usage for the typical pass user. >>> Granted, that necessarily involves applying these patches atop your >>> daily driver and living with them for a spell and, ideally, investing >>> some thought into imagining common usage patterns beyond your own (plus >>> any potentially problematic edge cases). If you have the energy to >>> devote to (perhaps just some of) these areas, it would really help move >>> this bug report forward. Thanks. >> >> Actually, I'm not very brave, and any damage to my password-store would >> be an absolute disaster. >> >> However, I have made a backup and add the encrypted passwords to a Git >> repository, and since the patch looks safe, I'm going to apply and test >> it. > > I have applied the patch the on top commit f8c11b5a, and it works fine. > > I did some basic testing (manually) of auth-source-pass and the > dependent packages I use, password-store and pass, and they all seem to > be unaffected when the new option enabled. So I guess we can enable it > by default. I didn't felt the need of test with the new feature > disabled, since the patch doesn't touch any old code. Awesome. Thanks for all the work. I know it's kind of a hassle. > And I also found that, auth-source finds the entry "akib@disroot.org" > correctly with (auth-source-search :host "disroot.org") when the new > user option is set to t. Yeah, it's sometimes tricky to tell if the new code is even running, so it's great that you checked that. > However, I haven't still installed the Emacs build with the patch > applied as my daily driver, I'm working on that. The tests were > performed on Emacs build without GUI. OK, nice. You mentioned previously some potentially surprising ambiguities surrounding the trailing /user syntax. If any realistic scenarios present themselves, perhaps we can try to improve the situation if it's not too far out of scope (or just document the behavior, maybe in a unit test). Thanks again.