From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "J.P." Newsgroups: gmane.emacs.bugs Subject: bug#60730: 29.0.60; Free variable with :buffer keyword in ert-with-temp-file Date: Sat, 28 Jan 2023 20:35:47 -0800 Message-ID: <875ycqt0t8.fsf@neverwas.me> References: <87o7r5ji3q.fsf@neverwas.me> <874jsazqzz.fsf@neverwas.me> <83edreaehg.fsf@gnu.org> <87k016y7o9.fsf@neverwas.me> <838rhmab8f.fsf@gnu.org> <874jsaumk7.fsf@neverwas.me> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6591"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: stefankangas@gmail.com, 60730@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jan 29 05:37:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pLzRR-0001Xx-O4 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 29 Jan 2023 05:37:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pLzRH-0008TV-4j; Sat, 28 Jan 2023 23:37:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLzRA-0008TF-Qi for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2023 23:37:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pLzR8-0006VQ-RN for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2023 23:37:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pLzR8-0001AE-F6 for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2023 23:37:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "J.P." Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Jan 2023 04:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60730 X-GNU-PR-Package: emacs Original-Received: via spool by 60730-submit@debbugs.gnu.org id=B60730.16749669654395 (code B ref 60730); Sun, 29 Jan 2023 04:37:02 +0000 Original-Received: (at 60730) by debbugs.gnu.org; 29 Jan 2023 04:36:05 +0000 Original-Received: from localhost ([127.0.0.1]:41915 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLzQD-00018p-CI for submit@debbugs.gnu.org; Sat, 28 Jan 2023 23:36:05 -0500 Original-Received: from mail-108-mta25.mxroute.com ([136.175.108.25]:45517) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLzQ8-00018H-NZ for 60730@debbugs.gnu.org; Sat, 28 Jan 2023 23:36:04 -0500 Original-Received: from mail-111-mta2.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta25.mxroute.com (ZoneMTA) with ESMTPSA id 185fbcf6411000011e.001 for <60730@debbugs.gnu.org> (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Sun, 29 Jan 2023 04:35:50 +0000 X-Zone-Loop: 1e43018938cdd6c15625d47db1e3088665a5fe85f95a X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=v3XbDttVVDmIN03tTDCvPos0PT3QVDDrdEkQIIr20hA=; b=iwFXtCEspbWvP+7+zgclexpxms HuU/kVv6Yq9PtlCf774zuwYOsMy21kWmlft2OxK9trpnRrheTocGvw7GYsS8wF4gNapqaVFTP7RyV zDTbF+R3nsFWBOnp6jj4YoF2kzNgJoKsN523JIvZwXhymD9csrdDcdGdjhs0CzDg9dIvagrMa9Mkp gjM1tZSB7V/PmADNyrUTca9KYfwh6ukpQJgXpO03HLoahoPJyJZY+2UoN/Y8inz+mwan0KMtjtwJ7 sb+P+u8L6Zz2nKW+qvygzk/rArElXHX3Kq3YA5+BZ0D8hO7F5+oyKE8leDL/dmKYyd/tMpiCNr0ZE 6BYWQnbg==; In-Reply-To: <874jsaumk7.fsf@neverwas.me> (J. P.'s message of "Sat, 28 Jan 2023 18:00:40 -0800") X-Authenticated-Id: masked@neverwas.me X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254326 Archived-At: "J.P." writes: > Eli Zaretskii writes: > >> Thanks, but I'm not sure I follow: coding-system's name should always >> be quoted, as it's a symbol. So why things like the below: >> >> (ert-with-temp-file myfile :coding raw-text) >> >> are relevant? AFAIU, they are a mistake: raw-text should be quoted, >> as in 'raw-text. If, as you say, an argument to `:coding' should only ever be quoted, e.g., :coding 'raw-text then `coding' will end up quoted as well, so something like this might be enough: diff --git a/lisp/emacs-lisp/ert-x.el b/lisp/emacs-lisp/ert-x.el index 98a017c8a8e..aa02c79d32f 100644 --- a/lisp/emacs-lisp/ert-x.el +++ b/lisp/emacs-lisp/ert-x.el @@ -484,7 +484,7 @@ ert-with-temp-file (suffix (or suffix ert-temp-file-suffix (ert--with-temp-file-generate-suffix (or (macroexp-file-name) buffer-file-name))))) - `(let* ((coding-system-for-write ,(or coding coding-system-for-write)) + `(let* ((coding-system-for-write ,(or coding `',coding-system-for-write)) (,temp-file (,(if directory 'file-name-as-directory 'identity) (make-temp-file ,prefix ,directory ,suffix ,text))) (,name ,(if directory