From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Danny Freeman via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#61371: 30.0.50; Adding support for jdt:// file scheme in eglot Date: Wed, 15 Feb 2023 13:05:30 -0500 Message-ID: <875yc2by79.fsf@dfreeman.email> References: <87r0v06kjv.fsf@thornhill.no> <875ycbkw62.fsf@gmx.de> <87v8kb9l2a.fsf@thornhill.no> <87h6vt8dfb.fsf@dfreeman.email> Reply-To: Danny Freeman Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6251"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 61371@debbugs.gnu.org, michael.albinus@gmx.de, joaotavora@gmail.com To: Theodor Thornhill Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 15 19:07:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pSMBa-0001Q0-Uf for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Feb 2023 19:07:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pSMBO-0004Z5-PV; Wed, 15 Feb 2023 13:07:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSMBK-0004Yd-Dh for bug-gnu-emacs@gnu.org; Wed, 15 Feb 2023 13:07:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pSMBJ-0005To-WF for bug-gnu-emacs@gnu.org; Wed, 15 Feb 2023 13:07:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pSMBJ-0003mX-Hf for bug-gnu-emacs@gnu.org; Wed, 15 Feb 2023 13:07:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Danny Freeman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Feb 2023 18:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61371 X-GNU-PR-Package: emacs X-Debbugs-Original-Cc: "Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors" , Michael Albinus , 61371@debbugs.gnu.org, joaotavora@gmail.com Original-Received: via spool by submit@debbugs.gnu.org id=B.167648439814507 (code B ref -1); Wed, 15 Feb 2023 18:07:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 15 Feb 2023 18:06:38 +0000 Original-Received: from localhost ([127.0.0.1]:33893 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSMAw-0003lu-3O for submit@debbugs.gnu.org; Wed, 15 Feb 2023 13:06:38 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:58434) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pSMAs-0003le-68 for submit@debbugs.gnu.org; Wed, 15 Feb 2023 13:06:36 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSMAr-0004Td-Bn for bug-gnu-emacs@gnu.org; Wed, 15 Feb 2023 13:06:34 -0500 Original-Received: from out-84.mta0.migadu.com ([2001:41d0:1004:224b::54]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pSMAm-0005LI-N5 for bug-gnu-emacs@gnu.org; Wed, 15 Feb 2023 13:06:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dfreeman.email; s=key1; t=1676484384; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=hLMVxl8UrPUQMWPvbMALH3WqTb3/Bl4hY06cYdSRrIg=; b=ph4cYno105yZQDEHg7I5mI+oTymOjhiyQm/wcOnTHxBNOn1ZjPwH81mTKfhkS4p9YFELbO VyEwn2DI0g5T1RP4/pctIsTbt4ctloksplh55bcLNg7Uj7PMmdDrTJbHtjBFyMUki3aBII im8R0lFjnkv6czkaT8tG4dcXXZ9Tgg8= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-reply-to: <87h6vt8dfb.fsf@dfreeman.email> X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=2001:41d0:1004:224b::54; envelope-from=danny@dfreeman.email; helo=out-84.mta0.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:255753 Archived-At: Danny Freeman writes: > Theodor Thornhill writes: > >> Michael Albinus writes: >> >>> Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife >>> of text editors" writes: >>> >>>> Hi! >>> >>> Hi Theo, >>> >>>> When using Eglot along with Java there are some hacks that needs to be >>>> made to make things functional. One of the more important things is to >>>> add support for the jdt:// file scheme that is sent when you try to >>>> go-to-definition on a system or third party lib. >>>> >>>> As you can see, we need to query the server with >>>> :java/classFileContents, and also register with the server to send it >>>> with the :extendedClientCapabilities on initialization. >>>> >>>> Is there a place this code could live? Maybe in the new java-ts-mode? >>> >>> There is the jarchive package on GNU ELPA. Could this be used, perhaps extended? >>> >>>> Theo >>> >>> Best regards, Michael. >> >> Maybe! Don't know what it does, but I'll check it out - thanks! >> >> Theo > > JDT urls are outside the scope of jarchive. I would think of them less > as URLs and more as tokens to be decoded by the LSP server that provides > them. JDT urls are intended to be sent back to the LSP server using a > special extension method. > > There is an issue open in the eglot-java repo to implement this but I > have been too busy to get around to it > https://github.com/yveszoundi/eglot-java/issues/6 > > Someone has responded there with some code similar to jarchive that will > parse the JDT urls and try to open them, but I wouldn't consider that a > permanent solution. JDT urls are not standardized and subject to change > by the JDT LSP maintainers. I think this bug can be closed now, it was fixed in the eglot-java package. See: https://github.com/yveszoundi/eglot-java/issues/6 Thank you, -- Danny Freeman