From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#61816: 30.0.50; [PATCH] New user option 'doc-view-svg-honor-theme' Date: Thu, 02 Mar 2023 19:20:30 +0100 Message-ID: <875ybjuia9.fsf@ledu-giraud.fr> References: <877cw4tpap.fsf@ledu-giraud.fr> <838rgfe39g.fsf@gnu.org> <87ttz3jnzo.fsf@ledu-giraud.fr> <831qm7dzpg.fsf@gnu.org> <87lekfjh4q.fsf@ledu-giraud.fr> <87h6v3jgm8.fsf@ledu-giraud.fr> <83ttz3cdx2.fsf@gnu.org> Reply-To: Manuel Giraud Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32433"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 61816@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 02 19:21:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pXnYM-0008FT-MQ for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 Mar 2023 19:21:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pXnY9-0005Ty-Cd; Thu, 02 Mar 2023 13:21:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pXnY7-0005Sm-4E for bug-gnu-emacs@gnu.org; Thu, 02 Mar 2023 13:21:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pXnY6-00035U-RF for bug-gnu-emacs@gnu.org; Thu, 02 Mar 2023 13:21:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pXnY6-0000hn-A0 for bug-gnu-emacs@gnu.org; Thu, 02 Mar 2023 13:21:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Manuel Giraud Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Mar 2023 18:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61816 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 61816-submit@debbugs.gnu.org id=B61816.16777812372646 (code B ref 61816); Thu, 02 Mar 2023 18:21:02 +0000 Original-Received: (at 61816) by debbugs.gnu.org; 2 Mar 2023 18:20:37 +0000 Original-Received: from localhost ([127.0.0.1]:58354 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXnXg-0000gb-KM for submit@debbugs.gnu.org; Thu, 02 Mar 2023 13:20:37 -0500 Original-Received: from ledu-giraud.fr ([51.159.28.247]:21877) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pXnXd-0000gQ-7J for 61816@debbugs.gnu.org; Thu, 02 Mar 2023 13:20:35 -0500 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=tEQ1KOdC HB3fwdsD0PRrqAocP5pOLYc2LCitnsijIzQ=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=uF9PWlshCra/wq3KmHdklrAkaGL4Yx RVee8ozQzGoFZlf83Vm5ZAfzQ2zqqtKFtGjw+2QZcfwPLJPUKUGjtRCg== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=tEQ1KOdCHB3fwdsD 0PRrqAocP5pOLYc2LCitnsijIzQ=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=0BQOo/13+0YWAXk5m2q6NguQjrnphXUlRes0XV xNdYDbeTnx2YBspfOB0sjdvuvbJ1rrRJ3XYq0qhG3wBBGt4BkugZZ9IjstQLkEgc6qWLhq be4BaPuqv1/Kvkde1KPIPle7aDbRegZQZyDICPVJqwdA3LEWgOdfKzv6DYYFVWW7T/1Vx9 4wer5awfJ/VzWQwW5jpPHqf1A/NGyhLjj/iXMr+udhdqGkUugRf7baD5s4CQ82uDWPq8q7 7kPt/Sz5tY++w4Ojs3CGzWMDzjD8tvvfLyLM/Uc5YXeDWsowJvtE3M5YfGZU56TdPKLlHP 8Cp8D72jHYylt0qgdNt52skg== Original-Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 5eb2b56c (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Thu, 2 Mar 2023 19:20:31 +0100 (CET) In-Reply-To: <83ttz3cdx2.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 02 Mar 2023 18:32:09 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257177 Archived-At: --=-=-= Content-Type: text/plain Eli Zaretskii writes: [...] > Fine by me, that's what I proposed. Wow, it is cleaner and works even better (no need to change page to update colors). Thanks. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Use-a-face-for-DocView-SVG.patch >From 0f3ff5af9610fbf173f07218d652c1be3477dc14 Mon Sep 17 00:00:00 2001 From: Manuel Giraud Date: Thu, 2 Mar 2023 19:16:19 +0100 Subject: [PATCH] Use a face for DocView SVG * lisp/doc-view.el (doc-view-svg-face): New face for SVG images. (doc-view-insert-image): Use it. --- etc/NEWS | 6 ++++++ lisp/doc-view.el | 19 ++++++++----------- 2 files changed, 14 insertions(+), 11 deletions(-) diff --git a/etc/NEWS b/etc/NEWS index 116b60d8b11..88c3f2f0ef4 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -208,6 +208,12 @@ bound to 'C-c C-d' in 'go-ts-mode'. When this is non-nil, call the 'man' program synchronously rather than asynchronously (which is the default behavior). +** DocView + +--- +*** New face 'doc-view-svg-face'. +This replaces 'doc-view-svg-foreground' and 'doc-view-svg-background'. + * New Modes and Packages in Emacs 30.1 diff --git a/lisp/doc-view.el b/lisp/doc-view.el index 0303fec67a6..b14655fb274 100644 --- a/lisp/doc-view.el +++ b/lisp/doc-view.el @@ -236,17 +236,14 @@ doc-view-imenu-flatten :type 'boolean :version "29.1") -(defcustom doc-view-svg-background "white" - "Background color for svg images. +(defface doc-view-svg-face '((t :inherit default)) + "Face used for SVG images. Only background and foreground colors +are used. See `doc-view-mupdf-use-svg'." - :type 'color - :version "29.1") + :version "30.1") -(defcustom doc-view-svg-foreground "black" - "Foreground color for svg images. -See `doc-view-mupdf-use-svg'." - :type 'color - :version "29.1") +(make-obsolete 'doc-view-svg-background 'doc-view-svg-face "30.1") +(make-obsolete 'doc-view-svg-foreground 'doc-view-svg-face "30.1") (defcustom doc-view-ghostscript-options '("-dSAFER" ;; Avoid security problems when rendering files from untrusted @@ -1602,8 +1599,8 @@ doc-view-insert-image (unless (member :transform-smoothing args) (setq args `(,@args :transform-smoothing t))) (when (eq doc-view--image-type 'svg) - (setq args `(,@args :background ,doc-view-svg-background - :foreground ,doc-view-svg-foreground))) + (setq args `(,@args :background ,(face-background 'doc-view-svg-face) + :foreground ,(face-foreground 'doc-view-svg-face)))) (apply #'create-image file doc-view--image-type nil args)))) (slice (doc-view-current-slice)) (img-width (and image (car (image-size image)))) -- 2.39.1 --=-=-= Content-Type: text/plain -- Manuel Giraud --=-=-=--