From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#62260: 30.0.50; [PATCH] Restrict auto-save file mode Date: Mon, 20 Mar 2023 15:15:59 +0100 Message-ID: <875yavmrts.fsf@ledu-giraud.fr> References: <87v8iynl5c.fsf@ledu-giraud.fr> <83h6uiawvv.fsf@gnu.org> <87r0tlnbtz.fsf@ledu-giraud.fr> <83bkkpc2x6.fsf@gnu.org> <83a609c2q7.fsf@gnu.org> <87ilexn9tc.fsf@ledu-giraud.fr> <838rftbzj3.fsf@gnu.org> <837cvdbykw.fsf@gnu.org> <87edplm0ft.fsf@ledu-giraud.fr> <83sfe19bmk.fsf@gnu.org> <87r0tksyma.fsf@gmx.de> <87v8iw6e0v.fsf@ledu-giraud.fr> <87zg871wgh.fsf@gmx.de> Reply-To: Manuel Giraud Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31450"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , 62260@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 20 15:17:18 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1peGK6-0007xr-OA for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 20 Mar 2023 15:17:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1peGJs-0002ZB-Cf; Mon, 20 Mar 2023 10:17:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1peGJq-0002Yt-SQ for bug-gnu-emacs@gnu.org; Mon, 20 Mar 2023 10:17:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1peGJq-0007J4-Be for bug-gnu-emacs@gnu.org; Mon, 20 Mar 2023 10:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1peGJq-0006oh-7W for bug-gnu-emacs@gnu.org; Mon, 20 Mar 2023 10:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Manuel Giraud Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 20 Mar 2023 14:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62260 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 62260-submit@debbugs.gnu.org id=B62260.167932176826130 (code B ref 62260); Mon, 20 Mar 2023 14:17:02 +0000 Original-Received: (at 62260) by debbugs.gnu.org; 20 Mar 2023 14:16:08 +0000 Original-Received: from localhost ([127.0.0.1]:55460 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peGIy-0006nO-4P for submit@debbugs.gnu.org; Mon, 20 Mar 2023 10:16:08 -0400 Original-Received: from ledu-giraud.fr ([51.159.28.247]:49147) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1peGIs-0006mk-5h for 62260@debbugs.gnu.org; Mon, 20 Mar 2023 10:16:06 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=2dTW3fZ6 JocJVOeWPyR1KNFHuYaKoNs1zdTuTgMHF68=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=c2/pwTYvVKYzVeO3aNo4K5Wdba9p+U Dy2IWNs6P0GU3B356JJBstL1Baw5I5Kp24KtEe5vEup56a8G8f5LlACw== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=2dTW3fZ6JocJVOeW PyR1KNFHuYaKoNs1zdTuTgMHF68=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=hRhfRS4KAUcKOQW1VT6nknbIppCZ95RR4M7yXw qHwxpxJHgKqRj7SVhoB4/+OlQj73oBLAPOUlT6/q2qze+y59bjNsTjJlIA24PCAEDZ0dmg 8r8/HIKOvI63OJHwLqxvNN+xjYUMtOCT07mpTL0otKQ4fAP08Te6tFGT+i+eseNxLr2ebL zKQRSZX1wiL4Yvhf5xQXWwsplgMSNzM8HuVRKBL+ttqgMdNkN+nG+KNy53xD0oAV0zjfJT 6AO0cfOGdBqCXI1Qifw2nEvT0THvf70iH1hHDmybln/hjorNmgVqzDUmHLv7G+FCwjraDd 19pA2U+2GQii5c2OXT00T86g== Original-Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id cb647c1d (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 20 Mar 2023 15:16:00 +0100 (CET) In-Reply-To: <87zg871wgh.fsf@gmx.de> (Michael Albinus's message of "Mon, 20 Mar 2023 12:41:34 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258291 Archived-At: Michael Albinus writes: [...] > (defun my-find-file-hook () > (and buffer-file-name > (member (file-remote-p buffer-file-name 'method) '("doas" "ksu" "s= u" "sudo")) > (auto-save-mode 0))) > (add-hook 'find-file-hook 'my-find-file-hook) Hi Michael, Thanks for this method, I'll try that. > @Eli: We have already remote-file-name-inhibit-auto-save-visited. Shall > we define another user option remote-file-name-inhibit-auto-save, which > could be used similarly? It is a good idea and will be more simple for the end user than the hook you proposed above. That said, I think an important aspect of bug#57395 is to consider what remote/sudo file is "dangerous" and what isn't. So maybe, it would be better to have an option 'dangerous-file-name-inhibit-auto-save' and have a "piece of code" (so easy to say =F0=9F=98=85) that check whether a file is a dangerous one or n= ot=E2=80=A6 Or maybe it is over engineering things. Best regards, --=20 Manuel Giraud