From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#61373: Eglot patch: add customization to prefer plaintext for :hover Date: Thu, 23 Mar 2023 21:25:26 +0000 Message-ID: <875yardut5.fsf@gmail.com> References: <75664907-6B17-43AC-B372-724DA6E7BA42@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33272"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 61373-done@debbugs.gnu.org To: JD Smith Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Mar 23 22:24:32 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pfSQB-0008Ut-R2 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 23 Mar 2023 22:24:31 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pfSPk-0007H1-Jh; Thu, 23 Mar 2023 17:24:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pfSPj-0007G9-69 for bug-gnu-emacs@gnu.org; Thu, 23 Mar 2023 17:24:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pfSPi-0001Du-UE for bug-gnu-emacs@gnu.org; Thu, 23 Mar 2023 17:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pfSPi-0005vW-4Z for bug-gnu-emacs@gnu.org; Thu, 23 Mar 2023 17:24:02 -0400 Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Thu, 23 Mar 2023 21:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 61373 X-GNU-PR-Package: emacs Mail-Followup-To: 61373@debbugs.gnu.org, joaotavora@gmail.com, jdtsmith@gmail.com Original-Received: via spool by 61373-done@debbugs.gnu.org id=D61373.167960661322732 (code D ref 61373); Thu, 23 Mar 2023 21:24:01 +0000 Original-Received: (at 61373-done) by debbugs.gnu.org; 23 Mar 2023 21:23:33 +0000 Original-Received: from localhost ([127.0.0.1]:39450 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfSPF-0005ua-7W for submit@debbugs.gnu.org; Thu, 23 Mar 2023 17:23:33 -0400 Original-Received: from mail-ed1-f41.google.com ([209.85.208.41]:45870) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfSPE-0005uN-6o for 61373-done@debbugs.gnu.org; Thu, 23 Mar 2023 17:23:32 -0400 Original-Received: by mail-ed1-f41.google.com with SMTP id t10so397099edd.12 for <61373-done@debbugs.gnu.org>; Thu, 23 Mar 2023 14:23:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679606606; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6SyoluRaIIyQ2zYtLY+d5110qPonxVi5++SgPzpE4HQ=; b=XtLRgGOiXXaasZ3SThi6IQzc/INdOqSJg+R9zRoK1smoA1Wl953tWwCfU5WaAJcuf6 dLTisxYhbFDKBuwkxHKfTcnL3arcvTuIn2yiWdPChdNmjtiMLmqsETyzz1Ag32E43fxC /0fc9fCX/pwp/odBixgQaPaDWRGjBSFA/O+bgnU4DIqjumGIfbA8uUYUy8AUXIpSBLNW GJvqWyAmYNur5wsr4SL5QK4d5NG3hAZbTWpVRVSuz9x6q1Uc0iJBXNfMzBvea4Vc3+n5 1wj+V+jdvtF1Hqn0d9l36pPTV3Z8fO1TDKBtmDozuL38tvjisnCpRFETjb9eaDSmRbFx t8eA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679606606; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=6SyoluRaIIyQ2zYtLY+d5110qPonxVi5++SgPzpE4HQ=; b=u2C5XZATPBySRjh+Is29PSICE7pmNLJ1suWUaeGJSBNxmlZZ/cUdzJ9IoPBAAlewR8 khmb7kFT4v4ysTmsQq1+xXgeHuZlL4xzAlifzLBXGX5DBRGDdmPMuv0cOt+EEt4mNkyv lj5CFxkDTavREca7YlHD5nQs7y83naGYweY+yxVSD+/vpBfUobe2qha1aong4Q3/f2mb vq2qMYqRiLiICQhopCB8/xx1FwuSECb5DMpzkxgpqaawCkpagmn13BNOq9xUuWVNDFUS 0lZaKQpAFU3GwBBOBx1rEBcDw2vRl2By0qkVVazjn/861Kmja3sIAvzUUCUxQG8V2Hz4 dYLg== X-Gm-Message-State: AO0yUKV17l/aSEqz38O0m4edZtZpRd9g+yyXjsvc+OE3zWtHQtHTx0qr cYHOGj8JwrDC2PzTVZXm/AxQURMzE4g= X-Google-Smtp-Source: AK7set8KlFMWwgOEkBKJy0vqW6XgEnWwuafIVYhdAG+q2Qq1/2qWyBMt3kuQO2aOlTOQ0eNdN0n+eA== X-Received: by 2002:a17:906:79c7:b0:931:54:f24d with SMTP id m7-20020a17090679c700b009310054f24dmr6695404ejo.22.1679606606035; Thu, 23 Mar 2023 14:23:26 -0700 (PDT) Original-Received: from krug (87-196-72-75.net.novis.pt. [87.196.72.75]) by smtp.gmail.com with ESMTPSA id f23-20020a1709064dd700b00931536d461fsm9153163ejw.20.2023.03.23.14.23.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 Mar 2023 14:23:25 -0700 (PDT) In-Reply-To: <75664907-6B17-43AC-B372-724DA6E7BA42@gmail.com> (JD Smith's message of "Wed, 8 Feb 2023 16:33:16 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258481 Archived-At: JD Smith writes: > Some LSP servers badly mangle their responses to :hover into markdown tha= t gfm-viewmode cannot render. See this > discussion, for example.=20 > > The attached patch adds a new custom option `eglot-prefer-plaintext=E2=80= =99 which configures the server to use plaintext for : > hover responses, even if Emacs could in principle handle markdown. Unfor= tunately, the popular Python LSP server in > question (pyright) is not interested in improvement to its generated mark= down (since it "works in VS-Code=E2=80=9D). Luckily the > plaintext docstrings of most packages are very nicely formatted. Hi, I've pushed your patch to master: commit 4566a0c6b825a18e6c065da0543b8b942b7db8df (HEAD -> master, origin/mas= ter, origin/HEAD) Author: JD Smith Date: Thu Mar 23 17:43:52 2023 +0000 Eglot: let user opt-in to plaintext LSP docs (bug#61373) * lisp/progmodes/eglot.el (eglot-prefer-plaintext): New variable. (eglot-client-capabilities): Use it. Copyright-paperwork-exempt: yes I opted noted not to describe eglot-prefer-plaintext in the manual, because I think this option should ultimately live in ElDoc, not in Eglot. Properly supporting markdown rendering in Eldoc is hard though, so there's little reason not to push this simple workaround. Closing this bug. See also bug#61072 and bug#62029 for more discussion. Jo=C3=A3o