From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Basil Contovounesios via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#62741: 30.0.50; Eglot jdtls project test: pass on emacs-29, fail on master Date: Mon, 10 Apr 2023 00:13:25 +0100 Message-ID: <875ya4k5t6.fsf@tcd.ie> References: <87pm8dne2a.fsf@tcd.ie> <87zg7gna2m.fsf@gmail.com> Reply-To: Basil Contovounesios Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39557"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Dmitry Gutov , 62741@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Apr 10 01:14:21 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pleEm-000A9N-R5 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 10 Apr 2023 01:14:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pleEW-0002ke-Vf; Sun, 09 Apr 2023 19:14:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pleEU-0002kS-RN for bug-gnu-emacs@gnu.org; Sun, 09 Apr 2023 19:14:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pleEU-0006OK-Ji for bug-gnu-emacs@gnu.org; Sun, 09 Apr 2023 19:14:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pleEU-00035n-3r for bug-gnu-emacs@gnu.org; Sun, 09 Apr 2023 19:14:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Basil Contovounesios Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 Apr 2023 23:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62741 X-GNU-PR-Package: emacs Original-Received: via spool by 62741-submit@debbugs.gnu.org id=B62741.168108201611846 (code B ref 62741); Sun, 09 Apr 2023 23:14:02 +0000 Original-Received: (at 62741) by debbugs.gnu.org; 9 Apr 2023 23:13:36 +0000 Original-Received: from localhost ([127.0.0.1]:33919 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pleE4-00034z-8G for submit@debbugs.gnu.org; Sun, 09 Apr 2023 19:13:36 -0400 Original-Received: from mail-wr1-f54.google.com ([209.85.221.54]:40498) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pleE1-00034l-82 for 62741@debbugs.gnu.org; Sun, 09 Apr 2023 19:13:35 -0400 Original-Received: by mail-wr1-f54.google.com with SMTP id t4so41255932wra.7 for <62741@debbugs.gnu.org>; Sun, 09 Apr 2023 16:13:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; t=1681082007; x=1683674007; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=n+jcq54goMrU3YB9e02A5o/gNbqhhmtCHx4xXwo/IpI=; b=adR21NnFDKy/nuKLnvS5MK0DI5FBK7MuezE49KG5v6ExFHjASV7fLlDVZnydDjVDvI 7pLRpW0GzkebLdL6UjN7v5fDCH2RwWh6kXFkHTULA0ZeLSkw+E6VH/RO3jRhk69DIT7y Nbc4gQzBrBwOWoECAuuajSg7isAr9hACrKgBkIQNRggQvB31b5YaTSSviKaesPUttvMQ Rw6XgnkbrFQPPVWGJSaUbLxZDWosOvpdAfNwxXJ50tZjnXv1Xx5irRGnrg8PphRmbFnW wR1FpvqivbtN8Kj3sm12L8o3fX2xs6nHRZyu492YCUO7xJmxMpsXgVOH51Bi0j4cbM9G 878Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681082007; x=1683674007; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=n+jcq54goMrU3YB9e02A5o/gNbqhhmtCHx4xXwo/IpI=; b=s+ZTbml2oMD8JxP0TtHr0s05oHtL0L9DUvmfIyI8+KHu3nOTXtEZ0iQZxNxH2z0A+R hUPZIYF0qAUfb7e1aO4btRnpQXQPqqBbo/NB64cRC1D3jAEvOsSvbF4jIj9Eb0hkpe01 14APy7xEZPu6kTOMwl3NoM93SeyVu9g6QmFAg2jvejqBnduLl4JOeYUn/v6C0waxHNZ5 5xhEKSQ40xVW7BdLKp/2CiNCW3OV1ZcN2CXyPRXffiX8BA0j0lVRxTFv1UXetczY1TGa hObBKnkacFu/OFr4bkLR1iWqzekk/f8oYzSzn7o4sDqwHGygMtajh7CuR0+FwWGmT67r jLPg== X-Gm-Message-State: AAQBX9eKnDoYtYnybDUWjwaABhCjnToVNNYgIMAJhtUdtiaGtqp6ze4i W7edqQ2ZzGGbMBkeVBUL8oiDUw== X-Google-Smtp-Source: AKy350bT4tGpu9HPvuqxwb3rg5JOI1Ua9/GCNgLlPjfeIteiRwWCC7cZ6JSDNhM/5Zoq14ayBGgWOg== X-Received: by 2002:a5d:534c:0:b0:2f0:2d96:1c5a with SMTP id t12-20020a5d534c000000b002f02d961c5amr1885157wrv.32.1681082007264; Sun, 09 Apr 2023 16:13:27 -0700 (PDT) Original-Received: from localhost ([51.37.99.170]) by smtp.gmail.com with ESMTPSA id j12-20020a5d604c000000b002efb5f0cf44sm5797390wrt.3.2023.04.09.16.13.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Apr 2023 16:13:26 -0700 (PDT) In-Reply-To: <87zg7gna2m.fsf@gmail.com> ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Sun, 09 Apr 2023 20:13:05 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:259540 Archived-At: Jo=C3=A3o T=C3=A1vora [2023-04-09 20:13 +0100] wrote: > Basil Contovounesios writes: > >> diff --git a/test/lisp/progmodes/eglot-tests.el b/test/lisp/progmodes/eg= lot-tests.el >> index 62e04539ebf..041aafabe8e 100644 >> --- a/test/lisp/progmodes/eglot-tests.el >> +++ b/test/lisp/progmodes/eglot-tests.el >> @@ -325,8 +325,7 @@ eglot-test-eclipse-connect >> "Connect to eclipse.jdt.ls server." >> (skip-unless (executable-find "jdtls")) >> (eglot--with-fixture >> - '(("project/src/main/java/foo" . (("Main.java" . ""))) >> - ("project/.git/" . nil)) >> + '(("project/src/main/java/foo" . (("Main.java" . "")))) >> (with-current-buffer >> (eglot--find-file-noselect "project/src/main/java/foo/Main.java= ") >> (eglot--sniffing (:server-notifications s-notifs) >> >> >> Which I assume means that project-current picks up .git as a project >> root marker, but project-files unexpectedly finds no registered files. >> >> I'm not sure whether this is expected on either the project or eglot >> side. If I squint hard enough it kind of reminds me of bug#62735. > > I think the change is fine, please install it, and thanks. Done: Avoid Git project in eglot-test-eclipse-connect 6674ac17eb4 2023-04-09 23:32:14 +0100 https://git.sv.gnu.org/cgit/emacs.git/commit/?id=3D6674ac17eb4 > Let's hope it doesn't break on Emacs 26.3, 27 and 28 > > (f you could test, it would be great, if not it's OK. It'd involve > making a GitHub fork and using the GitHub actions scripts) Seems to work there too: https://github.com/basil-conto/eglot/commit/e915db94a6 https://github.com/basil-conto/eglot/actions/runs/4652799056 > A safer, but slightly slower route: > > (should (zerop (shell-command "git init"))) > > Some tests known to need project-files already do this. This continues to fail in the same way, both in emacs.git and eglot.git: https://github.com/basil-conto/eglot/commit/1b2d13eaf6 https://github.com/basil-conto/eglot/actions/runs/4652805286 > But why does it pass on Emacs 29?? Maybe project-files simply doesn't > error there? Maybe, but why not? Thanks, --=20 Basil