From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#62720: 29.0.60; Not easy at all to upgrade :core packages like Eglot Date: Sat, 15 Apr 2023 10:40:04 +0000 Message-ID: <875y9x5szf.fsf@posteo.net> References: <87a5zj2vfo.fsf@gmail.com> <87edonlsxi.fsf@posteo.net> <83jzyf4vzb.fsf@gnu.org> <871qknllkj.fsf@posteo.net> <83fs934pjf.fsf@gnu.org> <87wn2fk47y.fsf@posteo.net> <83sfd2g2ek.fsf@gnu.org> <875y9yfxrr.fsf@gmail.com> <87y1muefks.fsf@gmail.com> <834jpifizy.fsf@gnu.org> <83y1mue1qi.fsf@gnu.org> <83sfd2e01f.fsf@gnu.org> <87v8hynsbu.fsf@posteo.net> <87a5z935ly.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="388"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62720@debbugs.gnu.org, rpluim@gmail.com, dmitry@gutov.dev, monnier@iro.umontreal.ca, Eli Zaretskii , larsi@gnus.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 15 12:41:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pndLQ-000ATz-F9 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 15 Apr 2023 12:41:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pndL6-0003wC-6i; Sat, 15 Apr 2023 06:41:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pndL4-0003vq-Vi for bug-gnu-emacs@gnu.org; Sat, 15 Apr 2023 06:41:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pndL4-0002DQ-Ne for bug-gnu-emacs@gnu.org; Sat, 15 Apr 2023 06:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pndL4-0000ig-EP for bug-gnu-emacs@gnu.org; Sat, 15 Apr 2023 06:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Apr 2023 10:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62720 X-GNU-PR-Package: emacs Original-Received: via spool by 62720-submit@debbugs.gnu.org id=B62720.16815552142670 (code B ref 62720); Sat, 15 Apr 2023 10:41:02 +0000 Original-Received: (at 62720) by debbugs.gnu.org; 15 Apr 2023 10:40:14 +0000 Original-Received: from localhost ([127.0.0.1]:48318 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pndKI-0000h0-47 for submit@debbugs.gnu.org; Sat, 15 Apr 2023 06:40:14 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:59733) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pndKF-0000gj-Kn for 62720@debbugs.gnu.org; Sat, 15 Apr 2023 06:40:12 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 21E8A2402CB for <62720@debbugs.gnu.org>; Sat, 15 Apr 2023 12:40:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1681555206; bh=hNpJLKioIIzSdn1zjucb3NeFgTp7KfSB78M2v/eIuck=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=B/H3B8FmSj/4FmC8Mfo+aEHeb8nouTWuu4wyBesIqvxQUhqdtYE/3G/63EDLF3/mq jjTWVvVsdc0hLnSEoSwToWvio85k2VsTagjriopFzSUzzGeIV+j9is9fbzDqZgdDW+ MhWB6JY8LYY6uv7yjvIz2LFeLvLqWtMEwH8XnRkRzzaIjPQFzoSGwM0wCvP3GKZq4E K2cZ1TAdHUpX2Fs5Tp7Ip/JwQsYCST0RVKp1kP6F3WmY3U+7d6kDT+VUAJfaG0zryD gZHysNSyiPE/Q+JwftPQ+4zES7Z9dpELH+/aXXswDYmiCijz9ImMX3Y8fpLL4UyNoB KqNLD0ljMu+NA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Pz8w52JQPz9rxH; Sat, 15 Apr 2023 12:40:04 +0200 (CEST) In-Reply-To: <87a5z935ly.fsf@gmail.com> ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Sat, 15 Apr 2023 09:35:37 +0100") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260020 Archived-At: Jo=C3=A3o T=C3=A1vora writes: > Philip Kaludercic writes: > >> Jo=C3=A3o T=C3=A1vora writes: >>>> Philip presented such a safe modification, and we are in the final >>>> stages of discussing its details, before it will be installed. So >>>> yes, it is possible. >> >> I might have missed a message, what was the last state here? > > Eli is talking about an interaction between you two, so you should be > able to figure out. I know, I have just lost track. [...] > Eli said something like this patch could be acceptable for master and > maybe 29.2.=20=20 > > ----------8<----------8<----------8<----------8<----------8<----------8< > --- a/lisp/emacs-lisp/package.el > +++ b/lisp/emacs-lisp/package.el > @@ -652,6 +652,9 @@ package--builtins > name (a symbol) and DESC is a `package--bi-desc' structure.") > (put 'package--builtins 'risky-local-variable t) >=20=20 > +(defvar package--safely-upgradeable-builtins '(eglot use-package) > + "See bug#62720 for longest docstring ever.") > + > (defvar package-alist nil > "Alist of all packages available for activation. > Each element has the form (PKG . DESCS), where PKG is a package > @@ -2201,14 +2204,19 @@ package-install > (package--archives-initialize) > (list (intern (completing-read > "Install package: " > + (append > (delq nil > (mapcar (lambda (elt) > (unless (package-installed-p (car e= lt)) > (symbol-name (car elt)))) > package-archive-contents)) > + package--safely-upgradeable-builtins) > nil t)) > nil))) > (package--archives-initialize) > + (when-let ((desc (and (memq pkg package--safely-upgradeable-builtins) > + (cadr (assoc pkg package-archive-contents))))) > + (setq pkg desc)) > (add-hook 'post-command-hook #'package-menu--post-refresh) > (let ((name (if (package-desc-p pkg) > (package-desc-name pkg) > ---------->8---------->8---------->8---------->8---------->8---------->8 > > 1. Node code complexity. It's 6 lines of trivial code. > 2. Absolutely no risk of "silent installation of software that wasn't ever > installed before" > 3. Fixes all the aforementioned issues Personally I think this would be a fine solution considering the constraints. --=20 Philip Kaludercic