From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Damien Cassou Newsgroups: gmane.emacs.bugs Subject: bug#63345: 28.2; provided-mode-derived-p doesn't work when passed an alias in MODES Date: Sun, 07 May 2023 11:49:37 +0200 Message-ID: <875y94tqry.fsf@cassou.me> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40348"; mail-complaints-to="usenet@ciao.gmane.io" To: 63345@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun May 07 11:50:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pvb23-000AMl-Q7 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 07 May 2023 11:50:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pvb1p-0004RP-JZ; Sun, 07 May 2023 05:50:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvb1n-0004Qx-7D for bug-gnu-emacs@gnu.org; Sun, 07 May 2023 05:50:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pvb1m-0005aS-Uc for bug-gnu-emacs@gnu.org; Sun, 07 May 2023 05:50:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pvb1m-0004yg-LR for bug-gnu-emacs@gnu.org; Sun, 07 May 2023 05:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Damien Cassou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 May 2023 09:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 63345 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.168345299619113 (code B ref -1); Sun, 07 May 2023 09:50:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 7 May 2023 09:49:56 +0000 Original-Received: from localhost ([127.0.0.1]:36510 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvb1f-0004yC-Jj for submit@debbugs.gnu.org; Sun, 07 May 2023 05:49:55 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:47196) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pvb1c-0004y1-Ds for submit@debbugs.gnu.org; Sun, 07 May 2023 05:49:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvb1c-0004QS-81 for bug-gnu-emacs@gnu.org; Sun, 07 May 2023 05:49:52 -0400 Original-Received: from mail.choca.pics ([2001:910:1410:500::1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pvb1a-0005YR-Fc for bug-gnu-emacs@gnu.org; Sun, 07 May 2023 05:49:52 -0400 Original-Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id C3BF31807FF30 for ; Sun, 7 May 2023 11:49:38 +0200 (CEST) Original-Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10032) with ESMTP id mGlj7tfElKJD for ; Sun, 7 May 2023 11:49:38 +0200 (CEST) Original-Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id 364AF1807FF45 for ; Sun, 7 May 2023 11:49:38 +0200 (CEST) X-Virus-Scanned: amavisd-new at choca.pics Original-Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavisd-new, port 10026) with ESMTP id OwjUWzaMTCn4 for ; Sun, 7 May 2023 11:49:38 +0200 (CEST) Original-Received: from localhost (91.60.75.86.rev.sfr.net [86.75.60.91]) by mail.choca.pics (Postfix) with ESMTPSA id CC6BD1807FF30 for ; Sun, 7 May 2023 11:49:37 +0200 (CEST) Received-SPF: pass client-ip=2001:910:1410:500::1; envelope-from=damien@cassou.me; helo=mail.choca.pics X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261246 Archived-At: Hi, The function `provided-mode-derived-p` (used by `derived-mode-p`) has the code below. The first 3 lines of the function takes care of converting the first argument MODE if it is an alias (as `javascript-mode` is an alias for `js-mode`). This works great when calling the function this way: (provided-mode-derived-p 'javascript-mode 'prog-mode) =E2=87=92 prog-mode But if the second argument MODES contains an alias, the code has no conversion mechanism and the line below returns nil even though I expect it to return non-nil: (provided-mode-derived-p 'javacript-mode 'javascript-mode) =E2=87=92 nil Is that a bug? (defun provided-mode-derived-p (mode &rest modes) "Non-nil if MODE is derived from one of MODES. Uses the `derived-mode-parent' property of the symbol to trace backwards. If you just want to check `major-mode', use `derived-mode-p'." ;; If MODE is an alias, then look up the real mode function first. (when-let ((alias (symbol-function mode))) (when (symbolp alias) (setq mode alias))) (while (and (not (memq mode modes)) (let* ((parent (get mode 'derived-mode-parent)) (parentfn (symbol-function parent))) (setq mode (if (and parentfn (symbolp parentfn)) parentfn parent))= ))) mode) --=20 Damien Cassou "Success is the ability to go from one failure to another without losing enthusiasm." --Winston Churchill