From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#63337: [PATCH] package-vc--build-documentation: Fix relative @include statements Date: Sat, 13 May 2023 08:41:19 +0000 Message-ID: <875y8waaj4.fsf@posteo.net> References: <87fs89qg9y.fsf@breatheoutbreathe.in> <87cz3cea4k.fsf@posteo.net> <87pm7c7zfs.fsf@breatheoutbreathe.in> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9807"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63337@debbugs.gnu.org To: Joseph Turner Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 13 10:42:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pxkpa-0002Kj-QM for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 13 May 2023 10:42:22 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pxkpI-0007zN-Oo; Sat, 13 May 2023 04:42:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pxkpH-0007ym-59 for bug-gnu-emacs@gnu.org; Sat, 13 May 2023 04:42:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pxkpG-0002GV-So for bug-gnu-emacs@gnu.org; Sat, 13 May 2023 04:42:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pxkpG-0004vK-Fe for bug-gnu-emacs@gnu.org; Sat, 13 May 2023 04:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 May 2023 08:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63337 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 63337-submit@debbugs.gnu.org id=B63337.168396729018882 (code B ref 63337); Sat, 13 May 2023 08:42:02 +0000 Original-Received: (at 63337) by debbugs.gnu.org; 13 May 2023 08:41:30 +0000 Original-Received: from localhost ([127.0.0.1]:35799 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pxkok-0004uT-3n for submit@debbugs.gnu.org; Sat, 13 May 2023 04:41:30 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:57023) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pxkoh-0004uD-Lc for 63337@debbugs.gnu.org; Sat, 13 May 2023 04:41:29 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id B610A24003B for <63337@debbugs.gnu.org>; Sat, 13 May 2023 10:41:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1683967281; bh=e60NzWDz/WnWCxXSgys4S4+JnDfC10rnZZDwA5V8M0g=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=FqzzJ0x8T2PXEo8JQEbKxpjr2LvQBdG9NGl8MUmG21sVfuItd1KVcjKf9e9SGK3GX pLBUKa0lsLSKrW1w+lYPmiupb8x7P47GXqfJ1v6T8w7MO/sdU+7A19UA7kie1/4PNJ 3kffl8HVD77nVQE7Pvwc4iUWnYKeULOGc405Gh7KkZNLR/Jjh9zq01U4Y96dd/XGeV SDjeURGqVRQwMj42LEA957fuNAQOICi/hh4voutCp32XnLtnRcIPZX/ZMJiOBM/d6Z 0hOLl1mYk9wx5skCUyoCHWUae5y6rsE8XOYs6LX7nGx0X/Ts5Hb1XgPWArnuav2J/N ZnAsjYSqiaP8Q== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4QJJy91LLjz6tn4; Sat, 13 May 2023 10:41:21 +0200 (CEST) In-Reply-To: <87pm7c7zfs.fsf@breatheoutbreathe.in> (Joseph Turner's message of "Sun, 07 May 2023 11:40:46 -0700") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261672 Archived-At: Joseph Turner writes: > Philip Kaludercic writes: > >> Joseph Turner writes: >> >>> Hello! >>> >>> Because package-vc--build-documentation exports the texinfo manual to a >>> temp file inside /tmp/ , any @include statements with relative paths >>> break the makeinfo call. >>> >>> I noticed this issue when attempting to use package-vc to install >>> org-transclusion, whose manual contains the line >>> >>> #+texinfo: @include fdl.texi >>> >>> See: https://raw.githubusercontent.com/nobiot/org-transclusion/main/docs/org-transclusion-manual.org >>> >>> The attached patch solves this problem by passing the -I flag to >>> makeinfo. From makeinfo --help: >>> >>> -I DIR append DIR to the @include search path. >> >> Good catch, this should be applied to emacs-29. >> >>> Best, >>> >>> Joseph >>> >>> From a41abce88ed3b833c5531208945474c9cd16284b Mon Sep 17 00:00:00 2001 >>> From: Joseph Turner >>> Date: Sat, 6 May 2023 14:49:43 -0700 >>> Subject: [PATCH] Fix: (package-vc--build-documentation) Relative @include >>> statements >>> >>> --- >>> lisp/emacs-lisp/package-vc.el | 5 ++++- >>> 1 file changed, 4 insertions(+), 1 deletion(-) >>> >>> diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el >>> index 489610e2a1e..63c10285ca7 100644 >>> --- a/lisp/emacs-lisp/package-vc.el >>> +++ b/lisp/emacs-lisp/package-vc.el >>> @@ -381,6 +381,7 @@ FILE can be an Org file, indicated by its \".org\" extension, >>> otherwise it's assumed to be an Info file." >>> (let* ((pkg-name (package-desc-name pkg-desc)) >>> (default-directory (package-desc-dir pkg-desc)) >>> + (docs-directory (expand-file-name (file-name-directory file))) >>> (output (expand-file-name (format "%s.info" pkg-name))) >>> clean-up) >>> (when (string-match-p "\\.org\\'" file) >>> @@ -395,7 +396,9 @@ otherwise it's assumed to be an Info file." >>> (erase-buffer) >>> (cond >>> ((/= 0 (call-process "makeinfo" nil t nil >>> - "--no-split" file "-o" output)) >>> + "-I" docs-directory >> >> According to the docs, makeinfo has -I to append the search path, and -P >> to prepend. I don't know how well either of the two are supported, but >> assuming they are, shouldn't -P be preferred? Or wouldn't it have any >> effect? > > I am not sure what difference it would make. I don't know if the default > @include search path includes anything besides the working directory. > > In the attached diff, I have changed -I to -P. I can confirm that this patch does the right thing, and I think we should apply it. >>> + "--no-split" file >>> + "-o" output)) >>> (message "Failed to build manual %s, see buffer %S" >>> file (buffer-name))) >>> ((/= 0 (call-process "install-info" nil t nil