From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#63731: [PATCH] Support Emoji Variation Sequence 16 (FE0F) where appropriate Date: Fri, 26 May 2023 17:25:24 +0200 Message-ID: <875y8fm7x7.fsf@gmail.com> References: <87a5xrzsph.fsf@stebalien.com> <83pm6nlhll.fsf@gnu.org> <87v8gfmqyt.fsf@gmail.com> <83ilcflbua.fsf@gnu.org> <87mt1rmjjg.fsf@gmail.com> <83v8gfjnzj.fsf@gnu.org> <87edn3mbr3.fsf@gmail.com> <83mt1rjg69.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31323"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63731@debbugs.gnu.org, steven@stebalien.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 26 17:26:25 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q2ZKi-0007uO-G1 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 26 May 2023 17:26:24 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q2ZKN-0002LP-MN; Fri, 26 May 2023 11:26:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q2ZKM-0002L7-EF for bug-gnu-emacs@gnu.org; Fri, 26 May 2023 11:26:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q2ZKM-0002Fg-5f for bug-gnu-emacs@gnu.org; Fri, 26 May 2023 11:26:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q2ZKL-0004ob-LT for bug-gnu-emacs@gnu.org; Fri, 26 May 2023 11:26:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 26 May 2023 15:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63731 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 63731-submit@debbugs.gnu.org id=B63731.168511473518462 (code B ref 63731); Fri, 26 May 2023 15:26:01 +0000 Original-Received: (at 63731) by debbugs.gnu.org; 26 May 2023 15:25:35 +0000 Original-Received: from localhost ([127.0.0.1]:50586 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q2ZJu-0004nh-PE for submit@debbugs.gnu.org; Fri, 26 May 2023 11:25:35 -0400 Original-Received: from mail-wm1-f44.google.com ([209.85.128.44]:53385) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q2ZJs-0004nS-V5 for 63731@debbugs.gnu.org; Fri, 26 May 2023 11:25:33 -0400 Original-Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-3f68fc6b479so9855225e9.2 for <63731@debbugs.gnu.org>; Fri, 26 May 2023 08:25:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685114727; x=1687706727; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=aS7qC2vtTrRa/V9UJoUnI4y3Ju8IFunDxOvvkfqfP6g=; b=Y+607IWgW7dhD+C3/bS+5ZEuD5loH9OO7SfztLIqP6UZ9F/lDMrFaZVMG22RfME5Wm Txzem/GRDwc4RzDCf/f3TaaS6nBle3tffzf2l/CQ0fkUGm0j8TrNh3xe1Q6Czv2RTPy5 zZxra7eytYo8/c+Rgb6ppbw1XyyUj6fgKY/XQI8bwRJnW/PXqqOdzzouupZrzyHp0Tn6 fXNS+N2gslUMfxZU/ImxbhvLCO3zfbolbakb7egej/toJ+UJTyVpDiykYV6O4QuZmnVn 1+wafQWs3jq+KNWgCw5+g1iDQO+VzP56ltVFYlB1IJfk+7ljojlTCh6PM7kgquiPod7u ebDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685114727; x=1687706727; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aS7qC2vtTrRa/V9UJoUnI4y3Ju8IFunDxOvvkfqfP6g=; b=GMdPNT8zb+P2aXYPwmcYNbcsrSSsbCVM8cBWMv+aU1J+MMG+x0nnbqJ1x8I4MNKHW2 JdXJyZp3hSPAzZ+/7S9IDKQ91EgBU/Nx/YtDm9n9s8jWoAHCm7yGfMfslAzd93y0JS5u D0/4rVAWqD/bVqMyPoB83N5Cjhv62DjMaxSaRi7mHWAiRTTl4aWaA2EOYKlA4c7ZQMLO GwEkNY0ntv+jtmKwjS5/LWTvZ7PHEeKppvrkli/VGuywchk51HN4IhoIyWtjaF6Dd9Hj HyzUCOKC+AE6fDUMRy6IsJ9sqon7oeXqDhWlcieMgMgxyZrtD7Wreng+Up7aoDX22CKs M5Vg== X-Gm-Message-State: AC+VfDzc/eBVYP7VT8GSIvBjn4NO8/Et980qSIyP9iZn6iRO6ZTVdq11 n6t4bTWPuWpEuSGuFgB9TIpGzIuolIM= X-Google-Smtp-Source: ACHHUZ6SA/JL+vfDljND6JsqrLP57a80eb2/IkNEqw/KCGVeDjv+fXbjQHDZ5YHJpW8ZC00Azxd6xg== X-Received: by 2002:a05:600c:28f:b0:3f6:76e:604b with SMTP id 15-20020a05600c028f00b003f6076e604bmr2015939wmk.0.1685114726470; Fri, 26 May 2023 08:25:26 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id e21-20020a05600c219500b003f604ca479esm9128562wme.3.2023.05.26.08.25.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 May 2023 08:25:25 -0700 (PDT) In-Reply-To: <83mt1rjg69.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 26 May 2023 17:55:26 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262440 Archived-At: >>>>> On Fri, 26 May 2023 17:55:26 +0300, Eli Zaretskii said: >> From: Robert Pluim >> Cc: steven@stebalien.com, 63731@debbugs.gnu.org >> Date: Fri, 26 May 2023 16:02:40 +0200 >>=20 Eli> What does this issue mean for the other VS-n characters, though? Eli> Should we perhaps install something similar for them as well? >>=20 >> For VS-15 maybe? The following gets me text-presentation composition >> with CHAR+FE0E and emoji-presentation with CHAR+FE0F Eli> Actually, I forgot about compose-gstring-for-variation-glyph. My Eli> question was actually whether the general setting in Eli> (let ((elt `([,(purecopy "\\c.\\c^+") 1 compose-gstring-for-grap= hic] Eli> [nil 0 compose-gstring-for-graphic]))) Eli> (map-char-table Eli> #'(lambda (key val) Eli> (if (memq val '(Mn Mc Me)) Eli> (set-char-table-range composition-function-table key elt))) Eli> unicode-category-table)) Eli> affects also the VS-n selectors. But since the latter setting of Eli> (let ((elt '([".." 1 compose-gstring-for-variation-glyph]))) Eli> (set-char-table-range composition-function-table '(#xFE00 . #x= FE0E) elt) Eli> (set-char-table-range composition-function-table '(#xE0100 . #= xE01EF) elt)) Eli> takes care of all the VS-n selectors except VS-16, and your patch = now Eli> will take care of VS-16, it sounds like we don't need to care about Eli> other VS-n selectors? Eli> Or are you saying that without including VS-15, CHAR+FE0E is not Eli> displayed using its text representation? Not quite. If I don=CA=BCt have compose-gstring-for-graphic for VS-15, no composition occurs for CHAR+FE0E. With my change you=CA=BCll get composition, but it=CA=BCs still not 100% correct: CHAR+FE0E when CHAR is a member of the emoji script will use emoji presentation, not text, but the extra empty box will not show, so it=CA=BCs still an improvement. Eli> Did you test the proposed change with the admin/emoji-*.txt files,= to Eli> make sure they all still display OK? Yes. I=CA=BCve also got a change that makes Emoji_Keycap_Sequence work, but I think we can leave that for master. Robert --=20