From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#64101: 29.0.91; Eglot inlay hints rendered out of order Date: Mon, 19 Jun 2023 23:38:34 +0100 Message-ID: <875y7j6psl.fsf@gmail.com> References: <83r0qar07l.fsf@gnu.org> <877cs28m23.fsf@gmail.com> <87v8fl7mko.fsf@gmail.com> <87mt0w7sv2.fsf@gmail.com> <860E88E5-F4B5-4DEB-B64B-D201AB811E02@gmail.com> <4383B208-A6D6-4C5B-AA72-4C1EE56C3ABB@gmail.com> <410CA10A-75BB-4F88-B974-E69E349B3064@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39545"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , Krzysztof Klimonda , Stefan Monnier , 64101@debbugs.gnu.org To: Milan Jovanovic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 20 00:37:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qBNUt-000AA9-2k for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 20 Jun 2023 00:37:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qBNUd-0004B7-Tf; Mon, 19 Jun 2023 18:37:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qBNUc-0004Ag-D5 for bug-gnu-emacs@gnu.org; Mon, 19 Jun 2023 18:37:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qBNUc-00052x-4b for bug-gnu-emacs@gnu.org; Mon, 19 Jun 2023 18:37:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qBNUb-0006UW-Vn for bug-gnu-emacs@gnu.org; Mon, 19 Jun 2023 18:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Jun 2023 22:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64101 X-GNU-PR-Package: emacs Original-Received: via spool by 64101-submit@debbugs.gnu.org id=B64101.168721417424885 (code B ref 64101); Mon, 19 Jun 2023 22:37:01 +0000 Original-Received: (at 64101) by debbugs.gnu.org; 19 Jun 2023 22:36:14 +0000 Original-Received: from localhost ([127.0.0.1]:57511 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBNTp-0006TJ-Ud for submit@debbugs.gnu.org; Mon, 19 Jun 2023 18:36:14 -0400 Original-Received: from mail-wm1-f43.google.com ([209.85.128.43]:49582) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qBNTp-0006T5-50 for 64101@debbugs.gnu.org; Mon, 19 Jun 2023 18:36:13 -0400 Original-Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-3f909853509so20098075e9.3 for <64101@debbugs.gnu.org>; Mon, 19 Jun 2023 15:36:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687214167; x=1689806167; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=B54eluWxW0YXs+j0qtsR+sgHpAnQkhXHy/iAIrBkYAA=; b=H2l6vM1f1br3KqeKj7nsD2sNZuULzH8lAW7toeud3gmYcVTxKq4ZSh7dm2cqQji18v kY6R8pxuyva+IyM4boMUfkoq7vEXPx36cCZt23/MyIwC1FXwyz+Vl0RIYOZxppb6CcY7 HYa5CTFd24pXVqdT8E9jElu74NjCUiPTs+m9JnuYTK0hRJmwnqD50zu/l2qQS1fitw1o XUXVKmC67DxGxoEqPUKVvocD0pQcEtIov3ov0Tgt2gG9kViIUmDKwt02nTqHPWEvsLRJ peynhTUnkLXhY2BQCAKe69rcog6t+bY70sizrPm4X384iQwuYTlZwlzqrNkXWLg0wtNJ ib4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687214167; x=1689806167; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=B54eluWxW0YXs+j0qtsR+sgHpAnQkhXHy/iAIrBkYAA=; b=AKrxI5GJaSZHkjmjVUz/F4OVzjcnRPGGLs6bIZ/q+HzniDdF2pLBfsQ8b8ZEFx6svv CpiIx+1L5pu7132o5vikzzGc0VDK6z2P9zQbFryB7e6T6BIJmFVeNfAkS70ZhUCfSLlL mC74KTbBcyYV0pzDr6zjrTLs0MRPLtfCO7gLeD0c1MdpQY9wJbhAWH29FJnM+qV1fbNP w1GiB2VwmUFPH37iCM553ZBVGIG9nonRP2U4of+5QmrBVCScsfLnJVkhCpcW1AHWAJTU imTGTweF9i9NTSGH570dzHZJlEXHgYjQ7cKXQtutYN/eRmVlAKLXUiuf+zmQUB1DX8Sw srDw== X-Gm-Message-State: AC+VfDz5ZGsVTZGSOUvZQM0Ta2BowDY0wuy3qjbUQTAqIuiOZuKQ/kfO IgTNaP4Q2YceYlJpvYiux3G9whlCnno= X-Google-Smtp-Source: ACHHUZ6ovC8JsWlJ6IBdDmjY6iaeHSRkTDePm3k25Fps7ndQq1moqMNh6qr9BDgtwviEVgNM+midng== X-Received: by 2002:a7b:cc0c:0:b0:3f8:fb7c:6793 with SMTP id f12-20020a7bcc0c000000b003f8fb7c6793mr6322599wmh.24.1687214166879; Mon, 19 Jun 2023 15:36:06 -0700 (PDT) Original-Received: from krug ([87.196.73.15]) by smtp.gmail.com with ESMTPSA id p21-20020a7bcc95000000b003f739a8bcc8sm819697wma.19.2023.06.19.15.36.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jun 2023 15:36:06 -0700 (PDT) In-Reply-To: <410CA10A-75BB-4F88-B974-E69E349B3064@gmail.com> (Milan Jovanovic's message of "Mon, 19 Jun 2023 23:05:49 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263727 Archived-At: Milan Jovanovic writes: > Btw. I still don=E2=80=99t understand why parts of one hint can=E2=80=99t= be simply > merged. They could be merged but devising logic and heuristics to do it correctly would hardly be "simple". In this particular case, they could be merged, becasue the ':' label part doesn't have any properties clashing with the 'index' name-of-parameter label part. But in general, that isn't necessarily so, and Eglot is a generic Eglot client, not just catering to the rust-analyzer server which provides these very fine grained labels. So the simplest solution is taken and it is complex enough. So here the disadvantages outweigh the benefits. > Anyway, my recipe to recreate issue: > > % rust-analyzer --version > rust-analyzer 1.70.0 (90c54180 2023-05-31) =E2=80=94> last rustup version > (`rustup component add rust-analyzer`) Thanks. This was key. I've reproduced the problem (here, I didn't need Mac OS) and pushed a fix to emacs-29. The fix will appear in master soon and thus also in upcoming Eglot 1.16. Jo=C3=A3o