From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#64232: 28.2; Incorrect(?) byte compilation warning about =?UTF-8?Q?=E2=80=98ansi-color-apply-on-region=E2=80=99?= Date: Fri, 30 Jun 2023 06:02:36 +0200 Message-ID: <875y751tsz.fsf@web.de> References: <874jmzs23h.wl-zack@owlfolio.org> <83o7l5yt9k.fsf@gnu.org> <9c38fe1a-ee3a-4b6d-aaa7-33aa4909e331@app.fastmail.com> <87jzvoe3qk.fsf@web.de> <87wmznhr1q.fsf@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="414"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: eliz@gnu.org, zack@owlfolio.org, 64232@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jun 30 06:04:33 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qF5N2-000AQF-Tx for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 30 Jun 2023 06:04:32 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qF5Ma-000415-RH; Fri, 30 Jun 2023 00:04:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qF5MY-00040w-IQ for bug-gnu-emacs@gnu.org; Fri, 30 Jun 2023 00:04:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qF5MY-0005Wd-7q for bug-gnu-emacs@gnu.org; Fri, 30 Jun 2023 00:04:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qF5MX-0003Z6-Pt for bug-gnu-emacs@gnu.org; Fri, 30 Jun 2023 00:04:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Jun 2023 04:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64232 X-GNU-PR-Package: emacs Original-Received: via spool by 64232-submit@debbugs.gnu.org id=B64232.168809783713689 (code B ref 64232); Fri, 30 Jun 2023 04:04:01 +0000 Original-Received: (at 64232) by debbugs.gnu.org; 30 Jun 2023 04:03:57 +0000 Original-Received: from localhost ([127.0.0.1]:54342 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qF5MT-0003Yj-9V for submit@debbugs.gnu.org; Fri, 30 Jun 2023 00:03:57 -0400 Original-Received: from mout.web.de ([212.227.15.14]:33989) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qF5MO-0003YK-Rt for 64232@debbugs.gnu.org; Fri, 30 Jun 2023 00:03:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1688097758; x=1688702558; i=michael_heerdegen@web.de; bh=SgA8xzqo//5SIchlYZg60oqSWrjg5esI9uRfB7o4gFc=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=k6RDpgKPb95ERJ1MtEF8lJ7dU94d/9W5A0Dq3STkwy3txy8oIiT2SmOooMQUHzwMrUBm5Py mP101seGruKeu8Z+ppDP19dLLEI3uUj7F8LWjRpif7brs9mwcJoRhU2HAzwTzqGiPBT+et5IC reOYvTltyUNJ77Cr2FwfnnVdyosZNmvP9dr6kdo6Trr/lGGgz14tfg4HBqXB+wRibXlgenUQT KM7j4qrSWIAFAiWYpPb6K9oma75p9V9iyAG9Sc+KkrO+pUHPBbsNVLAjLsw1LddmC2eEIrUms p8Kq1KJ361YUJOC2TprmilUF5qFgIbZk7+FQNggnUzKQiLoAeaSg== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Original-Received: from drachen.dragon ([217.247.69.86]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MJnvp-1qUhJX1wpF-00K7nu; Fri, 30 Jun 2023 06:02:38 +0200 In-Reply-To: (Stefan Monnier's message of "Thu, 29 Jun 2023 00:51:08 -0400") X-Provags-ID: V03:K1:HOfpC9Iv3yPXY3HNaS3Ha1M9p2q9PxslfRoWWuxujX+e1mvVtHC 1UFI6ITAxWeumWz7UTg4LrRwV5R/z2xLXSSuLcJI8AEx4Mylg8uWm2YkicUOCnLsqUf42uD /cm4Zpl7VCsqK9J6Zrbx2V373OHKJHnJK1mSw7HDpweLTsE/GuWVY44twEDyjytGb0zpbAD KT1Tr7PH7peGsApOruDNg== UI-OutboundReport: notjunk:1;M01:P0:NkEn8VfAOJ8=;rBi67L7IgtuEQK954lCMPDWZwZw cKKqbSTi2+7rABRVH574nsJTNu36aM7nV7Jvfq86rYQzmnN9y0UTfyvEO8KzXYAKGvKzoB39r b4fSLoQRNmr7w7ZGkkljfofBi2/fNtjPSo3CS3II0C5KTHgCz6o7t9gC42TFMlF4+MlVTi40L 2+Z1kbPX5kxhbz0/2E8KMxJoEby7jiRx+ejtihuNtVS+sSGHg0EZ1bPH4KAsmGskjJFOOrFqj +y4YbMat3aNib4DTqU1TOS/dkgAfwVPh5GFKqKNn94oacgxoE34jYzVqaGs4NOwgnGEJrGybc zeVcXnJwsYv8nysrrtA+B5J97aD2oKXdomJCUgzME6tcrw6YnZ3pmR7LVZwth37RNuthqhgb5 admTi6WreEc2xipiVC3AL/q/wiwLQBNYVcV4m9ZBdo/LH2Tgl5m08juGnXwpqLqyrNOIOevxf E4yaEEjqpQCRW9Yv9gDVFVzIrUEwdm9sMiMN4gbBI7HzEqSh1iaE68dDnUGNpzGQaSUioqOTA eOcd3fxMQTvTheEW8MdISntkJk1J7lKSAkG/NF3Sw+i3tS4hW5TUl/NNJpFm7UTnClgSILssF KOg/ddj928zoH7YeGdhKt2dP+BO/FTcmDjlkAx1Q+pWW+/MRNJGKIHzlNo4qv1/lDRvyTQsAM ww/ajv3wowMsVI0PUvWIoPuaX4T6GiphWcQ1ctff239z1Q04paXth+22kZe6n3l7Fyw3OhP4N IfnV99P/MOLtfAKyYhpyljq9I6j3neyzdbmpLVx5VOpnK9lcDfd/WDhzzJRFoXCoUn3p0Xoq X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264300 Archived-At: Stefan Monnier writes: > Someone=E2=84=A2 should sit down and figure out how to make `bytecomp.el`= keep > track of those things more reliably/predictably. > In the mean time, maybe we can simply tweak `byte-compile-eval` so it > never adds to `byte-compile-noruntime-functions` functions which have > already been seen/declared during the current compilation? > > > diff --git a/lisp/emacs-lisp/bytecomp.el b/lisp/emacs-lisp/bytecomp.el > index 99202185d8d..cfec4b3be06 100644 > --- a/lisp/emacs-lisp/bytecomp.el > +++ b/lisp/emacs-lisp/bytecomp.el > @@ -1128,7 +1128,8 @@ byte-compile-eval > ;; we arguably should add it to b-c-noruntime-functions, > ;; but it's not clear it's worth the trouble > ;; trying to recognize that case. > - (unless (get f 'function-history) > + (unless (or (get f 'function-history) > + (assq f byte-compile-function-environme= nt)) > (push f byte-compile-noruntime-functions)))))))))= )))) Seems appropriate (and fixes this bug). Actually with that patch the situation looks already quite ok'ish to me. Thx, Michael.