From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Rahguzar via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#65214: 29.1; Tall images in 'image-mode' can't be scrolled with 'pixel-scroll-precision-mode' on Date: Sat, 12 Aug 2023 08:50:12 +0200 Message-ID: <875y5kn3zq.fsf@zohomail.eu> References: <87il9mddcx.fsf@zohomail.eu> <875y5ld55b.fsf@zohomail.eu> <871qg9d4mp.fsf@zohomail.eu> <87pm3tov80.fsf@yahoo.com> Reply-To: Rahguzar Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22154"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.10.6; emacs 29.1 Cc: 65214@debbugs.gnu.org To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 12 08:57:14 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qUiYk-0005aR-9q for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 12 Aug 2023 08:57:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qUiYc-0008C1-3k; Sat, 12 Aug 2023 02:57:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qUiYY-0008Bd-Su for bug-gnu-emacs@gnu.org; Sat, 12 Aug 2023 02:57:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qUiYY-0007Gz-Ks for bug-gnu-emacs@gnu.org; Sat, 12 Aug 2023 02:57:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qUiYY-0003sV-Gm for bug-gnu-emacs@gnu.org; Sat, 12 Aug 2023 02:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Rahguzar Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 12 Aug 2023 06:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65214 X-GNU-PR-Package: emacs Original-Received: via spool by 65214-submit@debbugs.gnu.org id=B65214.169182337914811 (code B ref 65214); Sat, 12 Aug 2023 06:57:02 +0000 Original-Received: (at 65214) by debbugs.gnu.org; 12 Aug 2023 06:56:19 +0000 Original-Received: from localhost ([127.0.0.1]:48568 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUiXq-0003qo-Hr for submit@debbugs.gnu.org; Sat, 12 Aug 2023 02:56:18 -0400 Original-Received: from sender11-pp-o91.zoho.eu ([31.186.226.249]:25116) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qUiXn-0003qZ-Jx for 65214@debbugs.gnu.org; Sat, 12 Aug 2023 02:56:17 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1691823372; cv=none; d=zohomail.eu; s=zohoarc; b=HnWCluEvAVN/wdzsrgHOxi3THK+XPtjzRLIUPtSb6wV44yCcGiJY7GPN2kPYQJePVrKneWGOzzBPNW4Kqw6/y5nB8NLlTLhRvti01Xd2gqUPuRds8hTaDaVYDXQhRgSJgngvBOgeDhaL05d05iSgr7A6pfMA1Pf21V32r/mcCiI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.eu; s=zohoarc; t=1691823372; h=Content-Type:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=lDYLUQ4qk4OkVxGuuLEyFgCYgHLAUN/To3a/qFNbVHM=; b=JQDlZHoha58t0qBcJsiI4zBEyIZdcejouF3Vfal3ayO51D0J0gy7FyC+c3Lv85SiKbCs9CS+Xi4FMXuEJs5hGlewKR6YBJegLDQODX6OAObQsQxhSjKTOsIulr4mnWnI3izCjjuJebhZtIMHsHPrWyEFV2cBiq34p5rAPJH+n/M= ARC-Authentication-Results: i=1; mx.zohomail.eu; dkim=pass header.i=zohomail.eu; spf=pass smtp.mailfrom=rahguzar@zohomail.eu; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1691823372; s=zoho; d=zohomail.eu; i=rahguzar@zohomail.eu; h=References:From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:In-reply-to:Message-ID:MIME-Version:Content-Type:Message-Id:Reply-To; bh=lDYLUQ4qk4OkVxGuuLEyFgCYgHLAUN/To3a/qFNbVHM=; b=MNlRjnZj6dOyFlHPEQcR+Cad24OjtLtTaGXmIwSb7crOmBjBm4U7eIseGXoEpvCz Vv+Lge5NklABE6MMPBQoE5egZQrnPoBfmB/ceV8DOldlkpUsgqLgG8XXghlSEtk8Fcv AAvXrVaegpo2+v4XdnG7TAVY7tcF3FVDd61UTb78= Original-Received: from localhost (81-231-79-170-no600.tbcn.telia.com [81.231.79.170]) by mx.zoho.eu with SMTPS id 169182337096364.60476482175795; Sat, 12 Aug 2023 08:56:10 +0200 (CEST) In-reply-to: <87pm3tov80.fsf@yahoo.com> X-ZohoMailClient: External X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:267269 Archived-At: Hi Po, Po Lu writes: > I tried to fix this differently on master. Please see if it resolves > your problem (and other issues with scrolling past large images.) > > As always, keep an eye out for performance regressions. Thanks. The issue is still there and can be reproduced by evaluating (let* ((win (display-buffer (get-buffer-create "image-pixel-precision-test"))) (height (* (window-text-height win t) 2)) (file "path/to/image")) (select-window win) (erase-buffer) (insert-image (create-image file nil nil)) (goto-char 1) (pixel-scroll-precision-mode) nil) The resulting image cannot be scrolled. In the new code this is because vscroll is reset to 0 inside the binding for `line-after`. Commenting out that line allows me to scroll the image. Rahguzar