From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#65735: [PATCH] key-translate should use the 1st key of a key sequence Date: Thu, 07 Sep 2023 15:49:26 +0200 Message-ID: <875y4mf5zt.fsf@gmail.com> References: <87edjafmfu.fsf@gmail.com> <83zg1yz9e7.fsf@gnu.org> <87a5tyfb6t.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36967"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "65735@debbugs.gnu.org" <65735@debbugs.gnu.org> To: Shynur Xie Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 07 15:50:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qeFOs-0009SC-Uk for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 07 Sep 2023 15:50:26 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qeFOW-0002C3-O9; Thu, 07 Sep 2023 09:50:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qeFOS-00028D-EL for bug-gnu-emacs@gnu.org; Thu, 07 Sep 2023 09:50:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qeFOS-0001Rf-5y for bug-gnu-emacs@gnu.org; Thu, 07 Sep 2023 09:50:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qeFOT-0007dL-RD for bug-gnu-emacs@gnu.org; Thu, 07 Sep 2023 09:50:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Sep 2023 13:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65735 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65735-submit@debbugs.gnu.org id=B65735.169409457829309 (code B ref 65735); Thu, 07 Sep 2023 13:50:01 +0000 Original-Received: (at 65735) by debbugs.gnu.org; 7 Sep 2023 13:49:38 +0000 Original-Received: from localhost ([127.0.0.1]:38934 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeFO6-0007ce-Ct for submit@debbugs.gnu.org; Thu, 07 Sep 2023 09:49:38 -0400 Original-Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]:46583) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeFO3-0007cR-PT for 65735@debbugs.gnu.org; Thu, 07 Sep 2023 09:49:36 -0400 Original-Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-402c46c49f4so10817055e9.1 for <65735@debbugs.gnu.org>; Thu, 07 Sep 2023 06:49:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694094568; x=1694699368; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=Og1MGes+4N9veSrB3ToxnHHpFwU66ZESRKJ457+JdfY=; b=VGEAc/3CP1Ehx1RLgFkT7qudRCnX+WETQqj0AU38ZVFPe4JTU3QOfz1llWP/gsrA3j id+hUkc4TneVHmyVX+9DmD4e8JWtu6PzYXPC4vdfSPJcV0tSArtgDmrGWr8EeTwm36U/ 26onFArojM5arWdGygzvWOm6NEEyv5E7/5zjXnT4/5/Uw0qQDgrFIcABpeVZhpThca6h 1+5sIdY/c6XHRVv7HoNQRiEvo6BexGQCxoz+22ytSCSAZLbHHDQDUhUxzoLmtB44TuNq F5MRhfATtNra/mJE5aP4qBb+jKhnRdO6tlBxa8SUk8LUnHmzjtdrCu5VgWnxigkIEJ36 7jNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1694094568; x=1694699368; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Og1MGes+4N9veSrB3ToxnHHpFwU66ZESRKJ457+JdfY=; b=bAN009updDiQRpl0IpiJojfvvk+ruGqV8Cg0xJZPXhgo7TBAVymassK1fxjSb5+ooB dDzVhtZ/X2sD6167J0SHoBJdjnV/mAj1QtWsQBfVz7MK0eXo5l3fyjh17KHjbH45xIVx gXYte9ROsX3DnkB+mXe6LA9m1tc7Kv3OiEAu6BsiSE8DGp3iEebrWE76Riao8Yaa3Ll9 f/gq2wmzl0mwzl+yibt9VPZkGKKnvmufjQPER8OBtTk1znLdV5K1tUdYU2FO9vxbJ2V6 pkcORMBrUjVTTYVbCD3BNKXz/+Vn8D1iKOTwfSGUZZlwMxkVI4MOfPZaxl5X6X2cmBcQ FA7g== X-Gm-Message-State: AOJu0YxtUyHB7UT+CJHNRuM8dSqrBGFf1c9ZGOlooijUxiMsxBb4tYlZ 2ly1ZIl8qzAQ4YYclIhsa6pO25bC8ayXQQ== X-Google-Smtp-Source: AGHT+IGp8ylzPVUfQC3WgKf396nuWabU7jF+Fuu5MtDg3CHLSIPIORXCEMf69brRz961LyIvAZ/okA== X-Received: by 2002:a7b:cd17:0:b0:401:cc0f:f866 with SMTP id f23-20020a7bcd17000000b00401cc0ff866mr4829119wmj.12.1694094567693; Thu, 07 Sep 2023 06:49:27 -0700 (PDT) Original-Received: from rltb ([2a01:e0a:3f3:fb50:2c97:7c37:cd1d:967d]) by smtp.gmail.com with ESMTPSA id v11-20020a1cf70b000000b00401d8810c8bsm2587362wmh.15.2023.09.07.06.49.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Sep 2023 06:49:27 -0700 (PDT) In-Reply-To: (Shynur Xie's message of "Thu, 7 Sep 2023 13:42:18 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269662 Archived-At: >>>>> On Thu, 7 Sep 2023 13:42:18 +0000, Shynur Xie said: >> Robert: >> Perhaps we should also check that `from' and `to' specify single >> keys, although that might be overkill. Shynur> Not necessary IMO. Shynur> As a regular Emacs user, I would read its docstring before usin= g this Shynur> function; the docstring already explains how to use it very cle= arly. Shynur> Moreover, there're several examples in the elisp manual for ref= erence: OK, I=CA=BCll leave that bit alone. Shynur> The docstring of `keyboard-translate' does suggest using Shynur> `key-translate'; similarly, `define-key' suggests using `keymap= -set'. Right. But the question is whether we should change Emacs to use the new functions, or whether we call it 'unnecessary churn'. Shynur> FWIW, I noticed that there're also some `define-key' invocation= s in Shynur> the file "lisp/simple.el". One function at a time :-) Robert --=20