From: Visuwesh <visuweshm@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Philip Kaludercic <philipk@posteo.net>, 66908@debbugs.gnu.org
Subject: bug#66908: Exposing more public nadvice API
Date: Sat, 04 Nov 2023 08:18:59 +0530 [thread overview]
Message-ID: <875y2ifd2c.fsf@gmail.com> (raw)
In-Reply-To: <jwvfs1mbivc.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Fri, 03 Nov 2023 18:05:40 -0400")
[வெள்ளி நவம்பர் 03, 2023] Stefan Monnier wrote:
>>> It's clearly the internal function most frequently used outside of
>>> `nadvice.el`, indeed.
>>> I think it'd be OK to promote that function to a non-internal name.
>> It would be nice if you could since it would also provide some guarantee
>> of it being a fairly stable interface.
>
> Could you describe the circumstance where you need it?
We need to get the func-arity of the original function and not its
advice. I have xref-find-definitions adviced but
(func-arity 'xref-find-definitions);; ⇒ (0 . many)
returns the func-arity of the advice meanwhile, what we are really
interested in is the func-arity of xref-find-definitions as shown in the
*Help* buffer i.e.,
(func-arity (advice--cd*r (indirect-function 'xref-find-definitions))) ;; ⇒ (1 . 1)
which is the right return value. It might be nice to not have to call
`indirect-function' here for the "global" function but you can be a
better judge of that.
>> The other function that I saw get usage outside of nadvice and bytecomp
>> was advice--symbol-function. Should we use its return value, or is
>> indirect-function's return value good enough for advice--cd*r? IIRC,
>> help-function-arglist uses indirect-function and it also works for our
>> use case.
>
> I don't think `advice--symbol-function` is a good candidate because its
> semantics is not very clearly defined. E.g. I'd be hard pressed to give
> a comprehensible documentation of it without either being too vague,
> or promising things I can't always provide, or getting too much into the
> the nitty gritty details of the various possible situations.
> That's why I haven't promoted the comment in its body
> to an actual docstring :-(
>
> Most callers are in only one of the many different situations, in which
> case they usually don't need that functionality.
In our case, the functions that will be checked for its arity should be
defined at the time of func-arity call. Or at least auto-loaded AFAIU.
Philip can correct me if I'm wrong.
next prev parent reply other threads:[~2023-11-04 2:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-03 8:34 bug#66908: Exposing more public nadvice API Philip Kaludercic
2023-11-03 16:22 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-03 18:50 ` Visuwesh
2023-11-03 19:24 ` Drew Adams
2023-11-03 22:05 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-04 2:48 ` Visuwesh [this message]
2023-11-04 6:14 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-04 6:28 ` Visuwesh
2023-11-04 8:13 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-11-04 9:58 ` Philip Kaludercic
2023-11-04 15:55 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875y2ifd2c.fsf@gmail.com \
--to=visuweshm@gmail.com \
--cc=66908@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=philipk@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).