From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Steven Allen <steven@stebalien.com> Newsgroups: gmane.emacs.bugs Subject: bug#69019: [PATCH] package-vc: scan the correct directory for lisp files Date: Sun, 11 Feb 2024 22:46:51 +0000 Message-ID: <875xyu39gk.fsf@stebalien.com> References: <87ttmgp2yv.fsf@stebalien.com> <87zfw7xj3r.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18430"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 69019@debbugs.gnu.org To: Philip Kaludercic <philipk@posteo.net> Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Feb 12 18:42:02 2024 Return-path: <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org> Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org>) id 1rZaJc-0004Xw-I0 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 12 Feb 2024 18:42:02 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <bug-gnu-emacs-bounces@gnu.org>) id 1rZaJQ-0005zg-Ii; Mon, 12 Feb 2024 12:41:49 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1rZaJN-0005zN-VQ for bug-gnu-emacs@gnu.org; Mon, 12 Feb 2024 12:41:46 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1rZaJN-0001xE-EG for bug-gnu-emacs@gnu.org; Mon, 12 Feb 2024 12:41:45 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1rZaJe-0004mE-9q for bug-gnu-emacs@gnu.org; Mon, 12 Feb 2024 12:42:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Steven Allen <steven@stebalien.com> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org> Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Feb 2024 17:42:02 +0000 Resent-Message-ID: <handler.69019.B69019.170775971718335@debbugs.gnu.org> Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69019 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 69019-submit@debbugs.gnu.org id=B69019.170775971718335 (code B ref 69019); Mon, 12 Feb 2024 17:42:02 +0000 Original-Received: (at 69019) by debbugs.gnu.org; 12 Feb 2024 17:41:57 +0000 Original-Received: from localhost ([127.0.0.1]:45038 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>) id 1rZaJV-0004lM-UF for submit@debbugs.gnu.org; Mon, 12 Feb 2024 12:41:57 -0500 Original-Received: from mout01.posteo.de ([185.67.36.141]:42839) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <steven@stebalien.com>) id 1rZaJR-0004kS-AV for 69019@debbugs.gnu.org; Mon, 12 Feb 2024 12:41:53 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 71B22240027 for <69019@debbugs.gnu.org>; Mon, 12 Feb 2024 18:39:55 +0100 (CET) Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4TYWtg0FBzz9rxP for <69019@debbugs.gnu.org>; Mon, 12 Feb 2024 18:39:54 +0100 (CET) Resent-To: 69019@debbugs.gnu.org Resent-From: Philip Kaludercic <philipk@posteo.net> Resent-Date: Mon, 12 Feb 2024 18:39:54 +0100 Resent-Message-ID: <878r3p37kl.fsf@posteo.net> Original-Received: from proxy02.posteo.name ([127.0.0.1]) by dovecot15.posteo.name (Dovecot) with LMTP id /zNVM19FyWVo+AAAB3Nl4w for <philipk@posteo.net>; Sun, 11 Feb 2024 23:46:55 +0100 Original-Received: from proxy02.posteo.de ([127.0.0.1]) by proxy02.posteo.name (Dovecot) with LMTP id Syu1NPtNyWWChAIAGFAyLg ; Sun, 11 Feb 2024 23:46:55 +0100 Original-Received: from mailin01.posteo.de (unknown [10.0.0.61]) by proxy02.posteo.de (Postfix) with ESMTPS id 4TY2lL6y9Nz120b for <philipk@posteo.net>; Sun, 11 Feb 2024 23:46:54 +0100 (CET) Original-Received: from mx01.posteo.de (mailin01.posteo.de [127.0.0.1]) by mailin01.posteo.de (Postfix) with ESMTPS id E024B2155F for <philipk@posteo.net>; Sun, 11 Feb 2024 23:46:54 +0100 (CET) X-Posteo-Spam-Status: v=1; e=base64; a=aes-256-gcm; d=/wns2KwiXLd0MGT2Sz2eIvdrHDJKQ6Ru8LDn3SNZZ8oNmHnizw7fSvvP6+VTzBZqNUVleg45/ NEQV+jjm1C9gd7Rn9oBv1l7JixPA6FmbbrCCwGeHljZAgoPd9IlinCAN4x9p8ujvVaEvsithQGS LhMAnTCfMYyOtQG55uLrZjq5lJulX+iW1BnRy89BzhKaisAteu8VUXRiZis3l9atn0UrG/Y4fGE vyaiKN1MAwwyvyOzwl7Sv2VgnmxGotMmSlkFKpkjsTQlM3DHd3wEGF8fKr5an/6F8TMFgW2qguI Ow0fsgRJLgsLFmIBCXUf8pzj1C8ajkPL3VD0/sVsZWucrt2D/KUpZSYmFW5I1xv/d0bpxyKgRJx A== X-Posteo-Antispam-Signature: v=1; e=base64; a=aes-256-gcm; d=NyUYq5woj6zlruSf/iSoaxdeFpuyrXVrjurNwx95tOH4Kwigd40UZed4mjGQl6ZGq6QZHk5BjWetMRmUiFUbILlFJYr8KwpM930eq8Qzy8qBbPQ0D9RJMNlM5QNgS8q9Kxa2mMXX Authentication-Results: posteo.de; dkim=pass (2048-bit key) header.d=stebalien.com header.i=@stebalien.com header.b=eDsP2Bnt; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=ALyZeAUT; dkim-atps=neutral X-Posteo-TLS-Received-Status: TLSv1.3 Original-Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mx01.posteo.de (Postfix) with ESMTPS id 4TY2lL1tbMz11QL for <philipk@posteo.net>; Sun, 11 Feb 2024 23:46:54 +0100 (CET) Original-Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 0E3C45C0096 for <philipk@posteo.net>; Sun, 11 Feb 2024 17:46:53 -0500 (EST) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Sun, 11 Feb 2024 17:46:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stebalien.com; h=cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1707691613; x=1707778013; bh=Lg1KhLDJHf h+HjT/BmSVPcJpXnJqhmIERsxj9x4mWh4=; b=eDsP2BntGwVprcZG3gJboJRV/D LPaYkrIV8I1EymAP2B5BCdIuSkXNG4yc5Cngp9sIqmSHBPPaUMAzdE7FTzKpOWCx HOa82Azy31/QWZYSFt9K3ovbTqbDzg0aZVMxQKyvE71K1QK6sUcUMYaFscLtCAmq gruQLVMRVV0bZPF3XIz+z26Dar6X3rPnz9cCDNuzMkjeSn7UfOfeTseBzqDZ6IJI dnw0I6tfqPPezo6HteM0XyYWJM+BJkEOVfvSnOYzWwrrQQwhNX6Jf+DRxtunPT+O 7RIpiBwzJzagXHseTQgnb84Go6QCIcH1d1ykzOV4npoWmQBbjgn1/rej3j7w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1707691613; x=1707778013; bh=Lg1KhLDJHfh+HjT/BmSVPcJpXnJq hmIERsxj9x4mWh4=; b=ALyZeAUTbkn+hEIRKJBtBofqStvBk7RKMACilL+MMAEg 9HyrMFG0bjtvtRvfWkf8bGHVeiYA3l1GgCa8uiQXNGEniE1nDWo5uPWF25xudtSa snvV4HzrQIZofyTBoQ91vSFgPvCAy3odWmA8NEnfCrvK2yeTCELE8nTa+FOE2mOH OUAAikalJd6Yh9u8BsvFch3NYtfU7O/xNhXFwbhKhaWY8raY8WgOmqnSYqJZ+af0 d2/fzyBa/cZK2FyTei2YvKGDuGh/aInEAGZEGSQiQYksnIottLpYjkSQF1xxF9Oz npiM5JG9ZKhtJ93Cj0T9Z8+eS8NL4Ju+7Y6xR9bfJg== X-ME-Sender: <xms:XE7JZREnErBoo3-kB0VYkyDXgnzaCwWSytFQF3g3EuXHDYpa2KPpkA> <xme:XE7JZWUEdlDVF3UH5V5dDTFgdhle87BqHEgjB8MQsJO9vD2ci279pOUjQF5Ad-LsU w4cfLSWsoPj8Bvjssg> X-ME-Received: <xmr:XE7JZTL1ruSpDmkMzVD3SL4VZHR5aQ3vI5jJmdKFDVtpDL51Bop-1BS4TU7YMy5nju6tG1ZvMu0KC4Ee5LTIRRFa0ncf> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledruddvgddtvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffujghffffkgggtsehttdertddttddtnecuhfhrohhmpefuthgvvhgvnhcu tehllhgvnhcuoehsthgvvhgvnhesshhtvggsrghlihgvnhdrtghomheqnecuggftrfgrth htvghrnhepgfffteffiefhgeduueehtdeilefggeefgeehgfevgeetvdeutdfggfevheeu hfefnecuffhomhgrihhnpehgihhthhhusgdrtghomhenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehsthgvvhgvnhesshhtvggsrghlihgvnhdr tghomh X-ME-Proxy: <xmx:XE7JZXG-xDnUtZOZxmijaNA9n-ofXWcS8Y5EDz8ki-88EzlMR77j6g> <xmx:XE7JZXVgTiZpOuMUH9ybniB7PqP0pqdVVAuVWsXbkK2MBJutO7Z8zA> <xmx:XE7JZSPMypxrfWL_CzFpmSF9xXV7EoKAE0ySeaz-Y6LtPuO2bt1Cdw> <xmx:XU7JZeB-TnmcnNsh35GKXvQJDJlQ23LLNy6Atfw46VILS4IvDc8ecQ> Feedback-ID: ie8a146a7:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA for <philipk@posteo.net>; Sun, 11 Feb 2024 17:46:52 -0500 (EST) In-Reply-To: <87zfw7xj3r.fsf@posteo.net> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs.gnu.org> List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-gnu-emacs>, <mailto:bug-gnu-emacs-request@gnu.org?subject=unsubscribe> List-Archive: <https://lists.gnu.org/archive/html/bug-gnu-emacs> List-Post: <mailto:bug-gnu-emacs@gnu.org> List-Help: <mailto:bug-gnu-emacs-request@gnu.org?subject=help> List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-gnu-emacs>, <mailto:bug-gnu-emacs-request@gnu.org?subject=subscribe> Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:279905 Archived-At: <http://permalink.gmane.org/gmane.emacs.bugs/279905> >> Following up on my previous patch (Bug#68761), we need to scan for >> package requirements inside the lisp-dir (if set), not in the root >> package directory. > > Looks good, do you have any specific examples where this caused > problems? pdf-tools puts all its files in a "lisp" dir, so they weren't getting searched when scanning for dependencies. The package definition is: (:url "https://github.com/vedang/pdf-tools/pulls" :lisp-dir "lisp") This patch causes package-vc to scan for dependencies in elisp files in "$pkg-dir/lisp/", instead of looking for elisp files in "$pkg-dir/". >> * lisp/emacs-lisp/package-vc.el (package-vc--unpack-1): >> Scan 'lisp-dir', if set, for lisp files instead of scanning the root >> package directory. > > Just note that the convention of the commit message logs is not to > indent the lines here. I can take care of that. I did not, thanks!