From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#68931: 30.0.50; Gnus byte-compilation error with (display . [not expire]) with git emacs Date: Wed, 21 Feb 2024 14:05:56 -0800 Message-ID: <875xyhjwvv.fsf@ericabrahamsen.net> References: <87ttmnop61.fsf@uwo.ca> <86r0hr13eu.fsf@gnu.org> <523B7DE4-EA66-4686-845A-35CDCC575F92@gmail.com> <86jznj0yol.fsf@gnu.org> <87fry63ojy.fsf@ericabrahamsen.net> <87zfvtehx8.fsf@uwo.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37642"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: 68931@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 21 23:27:58 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rcv4G-0009Y3-EI for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 21 Feb 2024 23:27:56 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rcv41-0000g0-23; Wed, 21 Feb 2024 17:27:41 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rcv40-0000f0-0o for bug-gnu-emacs@gnu.org; Wed, 21 Feb 2024 17:27:40 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rcv3z-0006Zq-PN for bug-gnu-emacs@gnu.org; Wed, 21 Feb 2024 17:27:39 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rcv4M-00041U-8T for bug-gnu-emacs@gnu.org; Wed, 21 Feb 2024 17:28:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Feb 2024 22:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68931 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.170855445715376 (code B ref -1); Wed, 21 Feb 2024 22:28:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 21 Feb 2024 22:27:37 +0000 Original-Received: from localhost ([127.0.0.1]:47952 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rcv3v-0003zt-S3 for submit@debbugs.gnu.org; Wed, 21 Feb 2024 17:27:36 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:32804) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rcv3s-0003yd-3o for submit@debbugs.gnu.org; Wed, 21 Feb 2024 17:27:33 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rcujN-0001Ia-48 for bug-gnu-emacs@gnu.org; Wed, 21 Feb 2024 17:06:21 -0500 Original-Received: from mail.ericabrahamsen.net ([52.70.2.18]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rcujK-0002sa-K1 for bug-gnu-emacs@gnu.org; Wed, 21 Feb 2024 17:06:19 -0500 Original-Received: from localhost (71-212-21-65.tukw.qwest.net [71.212.21.65]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 67DABFA02C for ; Wed, 21 Feb 2024 22:05:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1708553157; bh=xPlmx0DpZBiaQ+9tTIsvjw/syq6duZoHmA+IKSt5qHQ=; h=From:To:Subject:In-Reply-To:References:Date:From; b=BeYYN2uc2g2/kzQ086d7xupb654M+2FDDX06Bn2Unu58IAjmCbk0eucv7TMJJPMph BKWTO8z5OX1SNLTQxy/YdzkHKDvo8Hu6igZpqhb07vercuXXiy3EDyI0+iVpoTuIui vwlHFTG9CEXUUWJwpgevUEWLYm0d43QXeD2smzIs= In-Reply-To: <87zfvtehx8.fsf@uwo.ca> (Dan Christensen's message of "Wed, 21 Feb 2024 14:28:03 -0500") Received-SPF: pass client-ip=52.70.2.18; envelope-from=eric@ericabrahamsen.net; helo=mail.ericabrahamsen.net X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:280421 Archived-At: Dan Christensen writes: > On Feb 5, 2024, Stefan Monnier via "Bug reports for GNU Emacs, the Swiss= army knife of text editors" wrote: > >> diff --git a/lisp/gnus/gnus-agent.el b/lisp/gnus/gnus-agent.el >> index 604eea4c33d..cfcbea2e233 100644 >> --- a/lisp/gnus/gnus-agent.el >> +++ b/lisp/gnus/gnus-agent.el >> @@ -2925,8 +2921,9 @@ gnus-category-make-function-1 >> ;; Functions are just returned as is. >> ((or (symbolp predicate) >> (functionp predicate)) >> - `(,(or (cdr (assq predicate gnus-category-predicate-alist)) >> - predicate))) >> + (let ((fun (or (cdr (assq predicate gnus-category-predicate-alist)) >> + predicate))) >> + (if (symbolp fun) `(,fun) `(funcall ',fun)))) >> ;; More complex predicate. >> ((consp predicate) >> `(,(cond > > I see that this part was committed and then reverted. I just manually > applied it to master, and it makes the warnings in the *Compile-Log* > buffer go away, and my display predicate still works correctly. The > warnings said: > > Warning: Use =E2=80=98funcall=E2=80=99 instead of =E2=80=98#[0 \301\300!= \207 [expire > gnus-article-marked-p] 2]=E2=80=99 in the function position > > So I recommend that this be committed again. It will be! I only reverted because I'd committed completely by accident, and Stefan had mentioned it might need some equivalent adjustments elsewhere to be completely correct. I just haven't tested it fully yet.