From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#67931: [PATCH] Use S/MIME key from content for mail signing via OpenSSL Date: Tue, 07 May 2024 19:20:30 -0700 Message-ID: <875xvpt575.fsf@ericabrahamsen.net> References: <8734vx6mk7.fsf@yshyn.com> <86y18lajgd.fsf@gnu.org> <87edadt5wv.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31495"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: larsi@gnus.org, Eli Zaretskii , 67931@debbugs.gnu.org, stefankangas@gmail.com To: Illia Ostapyshyn Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed May 08 04:21:58 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s4WwP-00080c-Hp for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 08 May 2024 04:21:57 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s4Ww6-0004Py-HB; Tue, 07 May 2024 22:21:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s4Ww5-0004PZ-3f for bug-gnu-emacs@gnu.org; Tue, 07 May 2024 22:21:37 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s4Ww4-0007jv-Qt for bug-gnu-emacs@gnu.org; Tue, 07 May 2024 22:21:36 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s4WwT-0007Y2-KN for bug-gnu-emacs@gnu.org; Tue, 07 May 2024 22:22:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 May 2024 02:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67931 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 67931-submit@debbugs.gnu.org id=B67931.171513486628983 (code B ref 67931); Wed, 08 May 2024 02:22:01 +0000 Original-Received: (at 67931) by debbugs.gnu.org; 8 May 2024 02:21:06 +0000 Original-Received: from localhost ([127.0.0.1]:46104 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s4WvZ-0007XN-EA for submit@debbugs.gnu.org; Tue, 07 May 2024 22:21:05 -0400 Original-Received: from mail.ericabrahamsen.net ([52.70.2.18]:54438) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s4WvX-0007Wp-9i for 67931@debbugs.gnu.org; Tue, 07 May 2024 22:21:04 -0400 Original-Received: from localhost (71-212-21-65.tukw.qwest.net [71.212.21.65]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 9CF7FFA396; Wed, 8 May 2024 02:20:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1715134831; bh=/9KZFMDH2VfZs+3E8BguujvTizoSMBfsTYRHESBBKZg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=g8VEeUvnp12HOtKMCDcJ7rZO1h5722HF3/qhQL+tkfgVsrOALDJ8TermNTJ3UfXug Iek1CAskZfHcQBqyHXT3NggPAtDaWSX+AfEmUjdjybOXbDAWOtl/MzaMDS5a9vp48D RPTcvau2DCLajjGJks5qdP+zdeh3DjzCXhNFNon4= In-Reply-To: <87edadt5wv.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Tue, 07 May 2024 19:05:04 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:284664 Archived-At: Eric Abrahamsen writes: > Illia Ostapyshyn writes: > >> Eli Zaretskii writes: >> >>>> Cc: Lars Ingebrigtsen , 17780@debbugs.gnu.org, >>>> Stefan Kangas , Jan Beich , >>>> 67931@debbugs.gnu.org >>>> From: Illia Ostapyshyn >>>> Date: Mon, 06 May 2024 20:46:33 +0200 >>>> >>>> Sorry, forgot to attach the patch, sending it with this email. >>> >>> Thanks, I'm adding Eric to the discussion. >> >> Thanks! >> >> I've realized that reusing certfile parameter for signing will have >> unintended side-effects when encrypting and signing a message. When a >> single signencrypt MML tag is used for both this results in all >> certfiles passed to both `smime-encrypt-buffer' and `smime-sign-buffer'. >> >> I'm sending a new patch that introduces a parameter called chainfile for >> signatures instead. > > Thanks for the report, and the code. I haven't been able to get the > reproducer to work so far (in Emacs -Q), because it always ends up at > `mml-smime-sign-query' instead of `mml-smime-sign-buffer', and the > latter seems to be the only way to (eventually) end up at > `mml-smime-openssl-sign', where the problem is: > > - mml-smime-sign-buffer > - mml-smime-sign > - (funcall (nth 1 (assq 'openssl mml-smime-function-alist))) > - mml-smime-openssl-sign > > `mml-smime-sign' is the only place that does (nth 1 (assq 'openssl > mml-smime-function-alist)) > > The only way to call `mml-smime-sign-buffer' instead of > `mml-smime-sign-query' is if some code ran: > > (funcall (nth 1 (assoc "smime" mml-sign-alist))) > > And so far as I can tell, no code does that. > > Obviously you arrived at that function somehow, otherwise we wouldn't > have this bug report, but so far I can't figure out how! Bah, I'm sorry, I didn't realize that was only half the recipe. Hang on...