From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#60078: 30.0.50; Gnus: Can't remove groups of select methods that don't exist anymore Date: Mon, 13 May 2024 17:55:38 -0700 Message-ID: <875xvh9ppx.fsf@ericabrahamsen.net> References: <875yedvblv.fsf@thaodan.de> <87jzlgvlfe.fsf@kubajecminek.cz> <878r0hauhl.fsf@ericabrahamsen.net> <87ttj2isyj.fsf@kubajecminek.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29601"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 60078@debbugs.gnu.org, =?UTF-8?Q?Bj=C3=B6rn?= Bidar To: Jakub =?UTF-8?Q?Je=C4=8Dm=C3=ADnek?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 14 02:57:28 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s6gTv-0007Vo-PW for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 14 May 2024 02:57:27 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s6gTZ-0000IR-4x; Mon, 13 May 2024 20:57:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s6gTW-0000Ha-OZ for bug-gnu-emacs@gnu.org; Mon, 13 May 2024 20:57:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s6gTW-0000fr-8M for bug-gnu-emacs@gnu.org; Mon, 13 May 2024 20:57:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s6gTW-00042f-Hy; Mon, 13 May 2024 20:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, bugs@gnus.org Resent-Date: Tue, 14 May 2024 00:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60078 X-GNU-PR-Package: emacs,gnus Original-Received: via spool by 60078-submit@debbugs.gnu.org id=B60078.171564817015420 (code B ref 60078); Tue, 14 May 2024 00:57:02 +0000 Original-Received: (at 60078) by debbugs.gnu.org; 14 May 2024 00:56:10 +0000 Original-Received: from localhost ([127.0.0.1]:35905 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s6gSg-00040Y-FC for submit@debbugs.gnu.org; Mon, 13 May 2024 20:56:10 -0400 Original-Received: from mail.ericabrahamsen.net ([52.70.2.18]:44610) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s6gSb-0003zg-DS for 60078@debbugs.gnu.org; Mon, 13 May 2024 20:56:09 -0400 Original-Received: from localhost (71-212-21-65.tukw.qwest.net [71.212.21.65]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 59A2CFA01F; Tue, 14 May 2024 00:55:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1715648156; bh=gf5uuDZDMuPWon2R52ku5NtSfMtrMXfDFN6r+xgBKDs=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=iap145N6sMxAPxJeWyqvJFm/KaqbMc1Al0TJOb5Y5jiUXDz25ex+GISd1QwKeVvus HdM0YWHPZoqff5A234atxsc9KBwMIp1wBUjEfWptmv/cBzzmqoI6lgh/4N6gkWCB+c PcurMEdgvqyWxpbaDVxLvFaSw6jHDm4l4GSs9N14= In-Reply-To: <87ttj2isyj.fsf@kubajecminek.cz> ("Jakub =?UTF-8?Q?Je=C4=8Dm=C3=ADnek?= via \"Bug reports for GNU Emacs, the Swiss army knife of text editors\""'s message of "Sun, 12 May 2024 22:08:40 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:284985 Archived-At: Jakub Je=C4=8Dm=C3=ADnek via "Bug reports for GNU Emacs, the Swiss army kni= fe of text editors" writes: > Hello Eric, thanks for looking into it once again. > > "Eric Abrahamsen" writes: > >> So it looks like there's multiple things going on here. First of all, >> the check for bogus groups explicitly excludes secondary select methods. >> Why I do not know, but it's been that way since 2004. > > I believe that this is a bug. The documentation says that the `bogus' > group is such that exists in the `.newsrc' file, but isn=E2=80=99t known = to the > server (i.e., it isn=E2=80=99t in the active file). > > So it must not be active and must not be foreign. But the definition of > foreign group in `gnus-check-bogus-newsgroups' is different from what > was defined by Lars in 1997: > > (defun gnus-group-foreign-p (group) > "Say whether a group is foreign or not." > (and (not (gnus-group-native-p group)) > (not (gnus-group-secondary-p group)))) > > We should use this predicate in `gnus-check-bogus-newsgroups' which > fixes the bug we hit along the way (different behaviour between primary > (native) and secondary select methods). > > What do you think? I think you're right about the definition of "foreign", and that there's a bug/misunderstanding in code like this, but this check isn't a complete fix because `gnus-group-secondary-p' looks up the group's method, and the whole reason we're running this code is that the group's method no longer exists. (The original/current code also has this issue.) If the method is actually gone, groups that used to belong to it will also be passed over. So I guess there's two scenarios to support: in the first, the server is still there but one or more groups are gone (someone's deleted an IMAP folder from the server), and in the second the server itself has been removed from the user's config files, and we're clearing out the old groups. Your patch (or at least the understanding behind it) should be part of the fix, but there will have to be more. Thanks, Eric