From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#72275: 30.0.60; [PATCH] Fix jumping to page in DocView's text contents Date: Wed, 24 Jul 2024 15:33:15 +0200 Message-ID: <875xsuhq3o.fsf@ledu-giraud.fr> Reply-To: Manuel Giraud Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39782"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Tassilo Horn To: 72275@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jul 24 15:34:11 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sWc8B-000A5W-KP for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 24 Jul 2024 15:34:11 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sWc82-00087M-8U; Wed, 24 Jul 2024 09:34:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sWc7z-00086t-2j for bug-gnu-emacs@gnu.org; Wed, 24 Jul 2024 09:33:59 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sWc7x-0005z7-Ni for bug-gnu-emacs@gnu.org; Wed, 24 Jul 2024 09:33:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sWc82-0005KB-Fw for bug-gnu-emacs@gnu.org; Wed, 24 Jul 2024 09:34:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Manuel Giraud Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Jul 2024 13:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 72275 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.172182801620434 (code B ref -1); Wed, 24 Jul 2024 13:34:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 24 Jul 2024 13:33:36 +0000 Original-Received: from localhost ([127.0.0.1]:33373 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sWc7c-0005JV-1i for submit@debbugs.gnu.org; Wed, 24 Jul 2024 09:33:36 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:49400) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sWc7a-0005JM-0P for submit@debbugs.gnu.org; Wed, 24 Jul 2024 09:33:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sWc7R-00081A-D8 for bug-gnu-emacs@gnu.org; Wed, 24 Jul 2024 09:33:25 -0400 Original-Received: from ledu-giraud.fr ([51.159.28.247]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sWc7N-0005tv-LF; Wed, 24 Jul 2024 09:33:24 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=5tYup9g5 yZ+1bay9YRpVdslGj4kp3BEJw6LnbXY0WJ0=; h=date:subject:cc:to:from; d=ledu-giraud.fr; b=Dvtb0uVyIUn7mj7fGJy6+UtfcDHox9yjuD1Ukw4gaBuN8n1JB7 m6NLt1f2/oAgq3BcOO6leBBxAtEN+bleeYBQ== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=5tYup9g5yZ+1bay9 YRpVdslGj4kp3BEJw6LnbXY0WJ0=; h=date:subject:cc:to:from; d=ledu-giraud.fr; b=lTjdhj4ZbfSCotGxGgaYnD1WA7aAXfU/vVfUNUb7+FIl1bGx0A Ob8DtZbJhRWUbmqGFybgSHuYR8nchAQHdl9eHWGrpHsrqLsc0xwJT1f25NaAyc3Rut8y7a oXfR0QLdnAMr3Je5fetUNyQapPYdE2EITPG/uQVnSaM+lzC8nDb9ZdkyChGMvXpkt0YQJ+ qDNS6c8ReMrtQKo+XmNA7fIs5r0itt/ug0Fz4f6bwmCxUoi4dM6l7X/63bgWDgqg6ZplAZ i2hR7YLRmuHLDHGR1j5kgbaxMsv5rNqq2TgycsESzP3DAESd8eQKUXwSuGg2WRBb+sCL9l IVjgChcg/F1Q== Original-Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 6bfb3d95 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Wed, 24 Jul 2024 15:33:18 +0200 (CEST) Received-SPF: pass client-ip=51.159.28.247; envelope-from=manuel@ledu-giraud.fr; helo=ledu-giraud.fr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:289223 Archived-At: --=-=-= Content-Type: text/plain Hi, Poppler's "pdftotext" does not seem to enforce page delimiter at the first column. For instance, I have documents translated with "pdftotext" that skips the first three page starting with " ". In such case, using `page-delimiter' (which defaults to "^ ") to jump to the text contents page does not work as expected. This patch fixes this issue. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Fix-jumping-to-page-in-DocView-s-text-contents.patch >From e22d7dd15c8762214bfe4dbc504fe8e8dce90c46 Mon Sep 17 00:00:00 2001 From: Manuel Giraud Date: Wed, 24 Jul 2024 15:18:30 +0200 Subject: [PATCH] Fix jumping to page in DocView's text contents * lisp/doc-view.el (doc-view-open-text): Replace `page-delimiter' with a plain Control-L. --- lisp/doc-view.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/doc-view.el b/lisp/doc-view.el index e7d7ed4a862..19fd8901867 100644 --- a/lisp/doc-view.el +++ b/lisp/doc-view.el @@ -1782,7 +1782,7 @@ doc-view-open-text (goto-char (point-min)) ;; Put point at the start of the page the user was ;; reading. Pages are separated by Control-L characters. - (re-search-forward page-delimiter nil t (1- page)) + (re-search-forward " " nil t (1- page)) (add-hook 'write-file-functions (lambda () ;; FIXME: If the user changes major mode and then -- 2.45.2 --=-=-= Content-Type: text/plain In GNU Emacs 30.0.60 (build 2, x86_64-unknown-openbsd7.5) of 2024-07-24 built on computer Repository revision: 23549d7175108ca632375f9cc4390ff3e53e4d1e Repository branch: mgi/doc-view-ctrl-l Windowing system distributor 'The X.Org Foundation', version 11.0.12101013 System Description: OpenBSD computer 7.5 GENERIC.MP#198 amd64 Configured using: 'configure CC=egcc CPPFLAGS=-I/usr/local/include LDFLAGS=-L/usr/local/lib MAKEINFO=gmakeinfo --prefix=/home/manuel/emacs --bindir=/home/manuel/bin --with-x-toolkit=no --without-cairo --without-compress-install' Configured features: DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG LCMS2 LIBOTF LIBXML2 MODULES NOTIFY KQUEUE OLDXMENU PDUMPER PNG RSVG SQLITE3 THREADS TIFF TREE_SITTER WEBP X11 XDBE XFT XIM XINPUT2 XPM ZLIB Important settings: value of $LC_CTYPE: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Dired by name Minor modes in effect: pdf-occur-dired-minor-mode: t gnus-dired-mode: t display-time-mode: t display-battery-mode: t desktop-save-mode: t exwm-randr-mode: t server-mode: t electric-pair-mode: t override-global-mode: t repeat-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t minibuffer-regexp-mode: t buffer-read-only: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: /home/manuel/prog/elisp/exwm/exwm-randr hides /home/manuel/.emacs.d/elpa/exwm-0.31/exwm-randr /home/manuel/prog/elisp/exwm/exwm hides /home/manuel/.emacs.d/elpa/exwm-0.31/exwm /home/manuel/prog/elisp/exwm/exwm-xsettings hides /home/manuel/.emacs.d/elpa/exwm-0.31/exwm-xsettings /home/manuel/prog/elisp/exwm/exwm-xim hides /home/manuel/.emacs.d/elpa/exwm-0.31/exwm-xim /home/manuel/prog/elisp/exwm/exwm-workspace hides /home/manuel/.emacs.d/elpa/exwm-0.31/exwm-workspace /home/manuel/prog/elisp/exwm/exwm-systemtray hides /home/manuel/.emacs.d/elpa/exwm-0.31/exwm-systemtray /home/manuel/prog/elisp/exwm/exwm-manage hides /home/manuel/.emacs.d/elpa/exwm-0.31/exwm-manage /home/manuel/prog/elisp/exwm/exwm-layout hides /home/manuel/.emacs.d/elpa/exwm-0.31/exwm-layout /home/manuel/prog/elisp/exwm/exwm-input hides /home/manuel/.emacs.d/elpa/exwm-0.31/exwm-input /home/manuel/prog/elisp/exwm/exwm-floating hides /home/manuel/.emacs.d/elpa/exwm-0.31/exwm-floating /home/manuel/prog/elisp/exwm/exwm-core hides /home/manuel/.emacs.d/elpa/exwm-0.31/exwm-core /home/manuel/prog/elisp/exwm/exwm-config hides /home/manuel/.emacs.d/elpa/exwm-0.31/exwm-config /home/manuel/prog/elisp/exwm/exwm-background hides /home/manuel/.emacs.d/elpa/exwm-0.31/exwm-background /home/manuel/.emacs.d/elpa/ef-themes-1.7.0/theme-loaddefs hides /home/manuel/emacs/share/emacs/30.0.60/lisp/theme-loaddefs Features: (shadow sort mail-extr misearch multi-isearch vc-hg vc-bzr vc-src vc-sccs vc-svn emacsbug log-edit pulse dabbrev add-log smerge-mode diff whitespace display-line-numbers org-indent org-agenda texinfo texinfo-loaddefs view flymake-cc flymake python conf-mode vc-cvs vc-rcs log-view pcvs-util make-mode oc-basic org-element org-persist org-id org-element-ast inline avl-tree ol-eww eww url-queue mm-url ol-rmail ol-mhe ol-irc ol-info ol-gnus nnselect ol-docview doc-view filenotify ol-bibtex bibtex ol-bbdb ol-w3m ol-doi org-link-doi gnus-icalendar org-capture org-refile org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-src ob-comint org-pcomplete org-list org-footnote org-faces org-entities org-version ob-emacs-lisp ob-core ob-eval org-cycle org-table ol org-fold org-fold-core org-keys oc org-loaddefs org-compat org-macs emacs-news-mode mule-util on-screen gud sh-script smie treesit executable pdf-occur ibuf-ext ibuffer ibuffer-loaddefs tablist tablist-filter semantic/wisent/comp semantic/wisent semantic/wisent/wisent semantic/util-modes semantic/util semantic semantic/tag semantic/lex semantic/fw mode-local cedet pdf-isearch let-alist pdf-misc imenu pdf-tools cus-edit cus-start pdf-view bookmark jka-compr pdf-cache pdf-info tq pdf-util pdf-macs image-mode exif gnus-dired vc-dir ewoc vc vc-git diff-mode track-changes vc-dispatcher bug-reference time battery cus-load desktop frameset exwm-randr xcb-randr exwm exwm-input xcb-keysyms xcb-xkb exwm-manage exwm-floating xcb-cursor xcb-render exwm-layout exwm-workspace exwm-core xcb-ewmh xcb-icccm xcb xcb-xproto xcb-types xcb-debug server ef-kassio-theme ef-themes modus-operandi-theme modus-themes zone speed-type url-http url-auth url-gw nsm ytdious mpdired transmission color calc-bin calc-ext calc calc-loaddefs rect calc-macs supercite regi ebdb-gnus gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime smime gnutls dig gnus-sum shr pixel-fill kinsoku url-file svg dom gnus-group gnus-undo gnus-start gnus-dbus dbus xml gnus-cloud nnimap nnmail mail-source utf7 nnoo gnus-spec gnus-int gnus-range gnus-win ebdb-message message sendmail yank-media puny rfc822 mml mml-sec epa epg rfc6068 epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums gmm-utils mailheader ebdb-mua ebdb-com crm ebdb-format ebdb mailabbrev eieio-opt speedbar ezimage dframe find-func eieio-base timezone icalendar gnus nnheader gnus-util mail-utils range mm-util mail-prsvr wid-edit web-mode derived disp-table erlang-start skeleton cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs slime-asdf grep slime-tramp tramp rx trampver tramp-integration files-x tramp-message tramp-compat warnings xdg shell pcomplete parse-time iso8601 time-date format-spec tramp-loaddefs slime-fancy slime-indentation slime-cl-indent cl-indent slime-trace-dialog slime-fontifying-fu slime-package-fu slime-references slime-compiler-notes-tree advice slime-scratch slime-presentations bridge slime-macrostep macrostep compat slime-mdot-fu slime-enclosing-context slime-fuzzy slime-fancy-trace slime-fancy-inspector slime-c-p-c slime-editing-commands slime-autodoc slime-repl slime-parse slime apropos compile text-property-search etags fileloop generator xref project arc-mode archive-mode noutline outline pp comint ansi-osc ansi-color ring hyperspec thingatpt elec-pair edmacro kmacro use-package-bind-key bind-key appt diary-lib diary-loaddefs cal-menu calendar cal-loaddefs pcase dired-x dired-aux dired dired-loaddefs use-package-core repeat easy-mmode calfw-autoloads calfw-cal-autoloads calfw-org-autoloads debbugs-autoloads ebdb-autoloads cl-extra help-mode ef-themes-autoloads exwm-autoloads hyperbole-autoloads kotl-autoloads hact set hhist on-screen-autoloads osm-autoloads pdf-tools-autoloads rust-mode-autoloads info slime-autoloads macrostep-autoloads speed-type-autoloads tablist-autoloads transmission-autoloads xelb-autoloads ytdious-autoloads package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs icons password-cache json subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd touch-screen tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind kqueue lcms2 dynamic-setting system-font-setting font-render-setting xinput2 x multi-tty move-toolbar make-network-process emacs) Memory information: ((conses 16 1025742 653219) (symbols 48 57496 2) (strings 32 260102 42117) (string-bytes 1 6536941) (vectors 16 159749) (vector-slots 8 2188364 86800) (floats 8 634 915) (intervals 56 43337 1512) (buffers 992 169)) -- Manuel Giraud --=-=-=--