From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "J.P." Newsgroups: gmane.emacs.bugs Subject: bug#73686: 31.0.50; ERC 5.6.1-git: back button gone from describe-face via erc-nicks-list-faces Date: Mon, 07 Oct 2024 19:47:41 -0700 Message-ID: <875xq38g4y.fsf__36834.6894437977$1728355711$gmane$org@neverwas.me> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6525"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-erc@gnu.org To: 73686@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 08 04:48:22 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sy0Gq-0001S2-N6 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 08 Oct 2024 04:48:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sy0GS-0006O8-GV; Mon, 07 Oct 2024 22:47:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sy0GR-0006Ng-2i; Mon, 07 Oct 2024 22:47:55 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sy0GQ-00009C-PM; Mon, 07 Oct 2024 22:47:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:From:To:Subject; bh=CT2Drxr6z/JlrkMKq4dpCAX9YcMS9dQCa1aOjoKMhVc=; b=Qli7kbr4YOkgd+i5kN5Mwof11qIEgneF6Ae7OIRWz5dMgX5U+Wr1jeUJL9b84dei7WVnEsBL9udD5JTjQW7H5egoUwNEuhmR3U1E7GZnhuI7RH4j60vhkax1WjkzKp0l14R6aVmKeBbWWg8PZhqSSqYPcgcO/E9jNWB3uW1+r2T36byYQanmb9Mea478OuL2ikrqWvzesMy6UhneGBxxcBWJAga3vqk5Xj6etow8MEvRrZpPPuEWCZ6fZAWVooUS655XCvpnxopjmVY6jgaU5AY/uDbX1dVZY1VV/mPApUOSb24DB8OyJD4ulg+j1GQviYa1HX40w513opUidkedxA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sy0GY-0005nN-Oe; Mon, 07 Oct 2024 22:48:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "J.P." Original-Sender: "Debbugs-submit" Resent-CC: emacs-erc@gnu.org, bug-gnu-emacs@gnu.org Resent-Date: Tue, 08 Oct 2024 02:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 73686 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: emacs-erc@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.172835568122267 (code B ref -1); Tue, 08 Oct 2024 02:48:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 8 Oct 2024 02:48:01 +0000 Original-Received: from localhost ([127.0.0.1]:49896 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sy0GW-0005n5-JT for submit@debbugs.gnu.org; Mon, 07 Oct 2024 22:48:01 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:39636) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sy0GU-0005mw-34 for submit@debbugs.gnu.org; Mon, 07 Oct 2024 22:47:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sy0GL-0006LE-Oh for bug-gnu-emacs@gnu.org; Mon, 07 Oct 2024 22:47:49 -0400 Original-Received: from mail-108-mta28.mxroute.com ([136.175.108.28]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sy0GJ-00008t-LH for bug-gnu-emacs@gnu.org; Mon, 07 Oct 2024 22:47:49 -0400 Original-Received: from filter006.mxroute.com ([136.175.111.3] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta28.mxroute.com (ZoneMTA) with ESMTPSA id 1926a067f830003e01.001 for (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Tue, 08 Oct 2024 02:47:43 +0000 X-Zone-Loop: b01f6c1e887d0cdca3e3ea37849abe3bf9d2b3df0bf3 X-Originating-IP: [136.175.111.3] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:Subject:To:From:Sender: Reply-To:Cc:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=CT2Drxr6z/JlrkMKq4dpCAX9YcMS9dQCa1aOjoKMhVc=; b=ar0LEDWfhE8jNROkriF3yloAWx SRwWh/HqyBLFtSzZg0adDifOpu4GQi3LuWQteRBDsX+ePJIHXaF8JEY3GYsNQ8nMfPQKMUJO2n4Yx Lcf/EQKLqPGm46+DJwnaeZpBEGLbwfD3MlPK5hcNzvp4+wNFlE9g9wcOGzjZAYmuHj7h5212iTZ7M rc7p6qqb7KJhtVU7lK6UrwUFFwRGJmaNk6FwpWC6RMMJ8Jwwy/lq1pX3Tr9NwMqdF/G4oTT/pt7Wz ACfZIFvDToYRs5TnhzJXl+6eRVjQBKhqugieS6OZMi6ZMiXyS9fACmvsLIEr7Kp+6za5XFAuTPMH1 ciTFxQGg==; X-Authenticated-Id: masked@neverwas.me Received-SPF: pass client-ip=136.175.108.28; envelope-from=jp@neverwas.me; helo=mail-108-mta28.mxroute.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:293139 Archived-At: The test `erc-nicks-list-faces' in test/lisp/erc/erc-nicks-tests.el now fails [1]. This appears to be related to a recent change involving the killing of local variables in `help-setup-xref'. e776df2a3eae0454ea85287e15ebba649bf8e918 is the first bad commit commit e776df2a3eae0454ea85287e15ebba649bf8e918 Author: Dmitry Gutov Date: Sun Oct 6 04:31:31 2024 +0300 help-setup-xref: Keep the local values only of some variables ,* lisp/help-mode.el (help-setup-xref): Kill all local variables, saving ones that are known to need to be preserved (bug#73637). lisp/help-mode.el | 37 +++++++++++++------------------------ 1 file changed, 13 insertions(+), 24 deletions(-) The change also affects `list-faces-display' in faces.el, which `erc-nicks-list-faces' depends on. >From emacs -Q: 1. M-x list-faces-display RET 2. TAB TAB RET C-x o (but see below*) 3. l -> (user-error "No previous help buffer") Regarding (2), the Help buffer now opens in a split whereas before it opened in the current window. The failing test expects the old behavior but obviously doesn't have to for Emacs 31+. (That is to say we should ensure the command still works and the test still passes on older Emacs versions.) I may not be able to look into this for a few days. Just filing a bug now so folks will see it's been spotted. Thanks. [1] https://emba.gnu.org/emacs/emacs/-/jobs/90900/raw In GNU Emacs 31.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.43, cairo version 1.18.0) of 2024-10-07 built on localhost Repository revision: ff4de9eff30ade164655354f71e7cbca48135858 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12401002 System Description: Fedora Linux 40 (Workstation Edition) Configured using: 'configure --enable-check-lisp-object-type --enable-checking=yes,glyphs 'CFLAGS=-O0 -g3' PKG_CONFIG_PATH=:/usr/lib64/pkgconfig:/usr/share/pkgconfig' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB Important settings: value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: ERC Minor modes in effect: erc-truncate-mode: t erc-track-mode: t erc-track-minor-mode: t erc-ring-mode: t erc-nicks-mode: t erc-netsplit-mode: t erc-menu-mode: t erc-match-mode: t erc-list-mode: t erc-irccontrols-mode: t erc-keep-place-indicator-mode: t erc-move-to-prompt-mode: t erc-readonly-mode: t erc-scrolltobottom-mode: t erc-imenu-mode: t erc-pcomplete-mode: t erc-button-mode: t erc-fill-wrap-mode: t erc-fill-mode: t erc-stamp--date-mode: t erc-stamp--display-margin-mode: t erc-stamp-mode: t erc-autojoin-mode: t erc-networks-mode: t tooltip-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t minibuffer-regexp-mode: t line-number-mode: t visual-line-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message yank-media dired dired-loaddefs rfc822 mml mml-sec epa epg rfc6068 epg-config gnus-util mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils facemenu help-fns radix-tree mule-util compile text-property-search comp-run comp-common network-stream puny nsm erc-truncate erc-track erc-ring erc-nicks color erc-netsplit erc-menu erc-match erc-list erc-goodies erc-imenu imenu erc-pcomplete time-date pcomplete comint ansi-osc ansi-color ring erc-button browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util url-parse url-vars mailcap erc-fill erc-stamp erc-join cus-edit pp wid-edit view cus-start cus-load erc derived auth-source eieio eieio-core icons password-cache json map format-spec erc-backend erc-networks easy-mmode byte-opt bytecomp byte-compile erc-common inline cl-extra help-mode erc-compat cl-seq cl-macs gv pcase rx compat subr-x cl-loaddefs cl-lib erc-loaddefs rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd touch-screen tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo gtk x-toolkit xinput2 x multi-tty move-toolbar make-network-process native-compile emacs) Memory information: ((conses 16 310654 14020) (symbols 48 15823 0) (strings 32 41880 7379) (string-bytes 1 1446301) (vectors 16 22633) (vector-slots 8 247090 18865) (floats 8 201 7029) (intervals 56 5336 0) (buffers 984 20))