From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#74556: 30.0.92; Package upgrade can fail and results in deleted package Date: Wed, 11 Dec 2024 03:34:44 +0000 Message-ID: <875xnqyjsb.fsf@posteo.net> References: <87plmgq55e.fsf@daniel-mendler.de> <87zflj62ai.fsf@posteo.net> <87v7w7617o.fsf@posteo.net> <86ttbfism4.fsf@gnu.org> <87v7vvz0ay.fsf@posteo.net> <87zfl3h93m.fsf@daniel-mendler.de> <87ldwnxppc.fsf@posteo.net> <87pllzp9q4.fsf@daniel-mendler.de> <87h67bxosg.fsf@posteo.net> <86o71i522l.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40325"; mail-complaints-to="usenet@ciao.gmane.io" Cc: mail@daniel-mendler.de, 74556@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 11 04:35:16 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tLDVL-000AL8-37 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 11 Dec 2024 04:35:15 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tLDVE-0004BP-2u; Tue, 10 Dec 2024 22:35:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tLDV9-0004Ab-B8 for bug-gnu-emacs@gnu.org; Tue, 10 Dec 2024 22:35:05 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tLDV8-0003HO-Om for bug-gnu-emacs@gnu.org; Tue, 10 Dec 2024 22:35:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=Zdsd8PM7QuhcXWnINzQUVyCqM9G4A1iR7yzlvULXGBc=; b=VXyytDy5w4IQHHH0h//EvQkRggSJm1I/B9JcnkcZe08rOtit96ppzf9ejyJ52+ZvR5D76Bo2Z0i+0iE5W3ZJ9RS8AqG5aDElHDJ51ihEj+gi73W4JaaDr6IEBYYjN1SgfexommXS0nCMXKyoas+3+MsTZ8nPJahoAgNUufOJNj0WpT24KmkHvmxTJiCMx+yjwbMAHTU7MDTEqwdeuEOKkbatg03xKhmtFs2PpyyD2zg+4eQy3bi9ctNrX8z2HqBofYoNd6tl1r5+PQD/TDC8q/xC1w7NPN52GtCJDBk16WIK0LqQD7gIRvJTUmuD4tk1c8ES7HBheGz/5QTF80zhFA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tLDV8-0005in-HF for bug-gnu-emacs@gnu.org; Tue, 10 Dec 2024 22:35:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 11 Dec 2024 03:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74556 X-GNU-PR-Package: emacs Original-Received: via spool by 74556-submit@debbugs.gnu.org id=B74556.173388809721974 (code B ref 74556); Wed, 11 Dec 2024 03:35:02 +0000 Original-Received: (at 74556) by debbugs.gnu.org; 11 Dec 2024 03:34:57 +0000 Original-Received: from localhost ([127.0.0.1]:60643 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tLDV2-0005iL-GI for submit@debbugs.gnu.org; Tue, 10 Dec 2024 22:34:56 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]:53375) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tLDUz-0005hs-93 for 74556@debbugs.gnu.org; Tue, 10 Dec 2024 22:34:54 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 23233240101 for <74556@debbugs.gnu.org>; Wed, 11 Dec 2024 04:34:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1733888087; bh=GDGUc7Aq34AWJAsmo4OMi+wBjvKn+dowbriq5095D3w=; h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=CpPdecLv8722/24Va89Zf4bw9I1yeQxSq7bV9grvjnr+z76S5IsxPFCtjEfFAtHdu +BNrB+5rNWfr8SV+zWbQ5Gs30XKogrmAXIZApT6g/ZpYUy0BmusHnifwGTaA7qpAPl FhEnJMfCiSWhWMIUML3p8AG5JM2PKUZqN5Z9rV7U5+So2Pqzwwr4uLcNTkitL9khw1 t5e4KbJP5LAp+jcNE3lhKPsKj5qCDFk7HYoJrlIFlXx7+Iz8uS4MjmegNRcsbZlrgO nOOCVKvAmv9mA0P1G3qHH1rrdcWhVU2qQBvOAnUDdTA6usD38V9iZG5FIxErySaHnQ D+MtHQs19RnkQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Y7Lnd2dCZz9rxD; Wed, 11 Dec 2024 04:34:44 +0100 (CET) In-Reply-To: <86o71i522l.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 11 Dec 2024 05:30:10 +0200") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296794 Archived-At: Eli Zaretskii writes: >> From: Philip Kaludercic >> Cc: Eli Zaretskii , 74556@debbugs.gnu.org >> Date: Tue, 10 Dec 2024 20:31:59 +0000 >> >> Daniel Mendler > Philip Kaludercic writes: >> > >> >> Daniel Mendler writes: >> >> >> >>> Philip Kaludercic writes: >> >>> >> >>>> Eli Zaretskii writes: >> >>>> >> >>>>>> Cc: 74556@debbugs.gnu.org >> >>>>>> From: Philip Kaludercic >> >>>>>> Date: Thu, 28 Nov 2024 11:34:51 +0000 >> >>>>>> >> >>>>>> Philip Kaludercic writes: >> >>>>>> >> >>>>>> [...] >> >>>>>> >> >>>>>> > It might make sense to try and "deactivate" a package before installing >> >>>>>> > the new package. Looking into some second-try fallback for >> >>>>>> > package-install to refresh the package index if a package was not found >> >>>>>> > would also be a good idea ^^ >> >>>>>> >> >>>>>> This might do it? >> >>>>> >> >>>>> Philip, please install this on the emacs-30 branch, unless you see any >> >>>>> problems with the change. We'd like to make another pretest soon. >> >>>> >> >>>> Done. But we should keep the report open as there might be better >> >>>> approaches to discuss in the future. >> >>> >> >>> Hello Philip, >> >>> >> >>> I just tried the modified `package-upgrade' function and it doesn't seem >> >>> to work. It seems to break the upgrade procedure in an even worse way, >> >>> at least in my setup. Now `package-install' is tried first with the >> >>> package symbol, which will be a no-op, since the package is already >> >>> installed. Afterwards the package is deleted and we always end up with >> >>> no package. Probably `package-install' should also be called with a >> >>> package descriptor of the new package version? >> >> >> >> Right, my sincere apologies for that oversight. That being said, I >> >> don't feel comfortable fixing this right now as I am short on time to >> >> fix and test something like this on the "emacs-30" branch. My vote >> >> would be to revert the commit and try to tackle the issue on the >> >> "master" branch. An alternative I can propose that would be closer to >> >> the original code might be >> > >> > Yes, I also vote to revert your commit on the emacs-30 release branch. >> > The issue isn't severe (and not a regression), so I'd say it is okay to >> > fix the issue on the master branch. >> >> Eli, what do you say? > > It looks like you are in agreement, so please revert on emacs-30. Done > (Unless you also want to revert on master, don't forget to say "do not > merge" in the log message.) No, it doesn't make sense to keep the current change on master either. > Thanks.