From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#65491: [PATCH] Improve performance allocating vectors Date: Sat, 16 Sep 2023 19:22:54 +0200 Message-ID: <8758CDE8-40F1-48DB-9B94-38F771DC8C6C@gmail.com> References: <6B2EDD07-AAEB-40E8-B369-F634296BD3D9@gmail.com> <83v8cagkqv.fsf@gnu.org> <83ttrugkj2.fsf@gnu.org> <83r0mygi4y.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11658"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65491@debbugs.gnu.org, Paul Eggert , monnier@iro.umontreal.ca To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 16 19:24:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qhZ1j-0002qu-MW for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 16 Sep 2023 19:24:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qhZ1R-0003KF-CW; Sat, 16 Sep 2023 13:23:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qhZ1P-0003K5-Fy for bug-gnu-emacs@gnu.org; Sat, 16 Sep 2023 13:23:55 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qhZ1P-0002Yb-8D for bug-gnu-emacs@gnu.org; Sat, 16 Sep 2023 13:23:55 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qhZ1W-0004kQ-0E for bug-gnu-emacs@gnu.org; Sat, 16 Sep 2023 13:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Sep 2023 17:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65491 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65491-submit@debbugs.gnu.org id=B65491.169488499518177 (code B ref 65491); Sat, 16 Sep 2023 17:24:01 +0000 Original-Received: (at 65491) by debbugs.gnu.org; 16 Sep 2023 17:23:15 +0000 Original-Received: from localhost ([127.0.0.1]:48494 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qhZ0l-0004j7-Dm for submit@debbugs.gnu.org; Sat, 16 Sep 2023 13:23:15 -0400 Original-Received: from mail-lf1-x132.google.com ([2a00:1450:4864:20::132]:49196) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qhZ0g-0004iZ-P5 for 65491@debbugs.gnu.org; Sat, 16 Sep 2023 13:23:13 -0400 Original-Received: by mail-lf1-x132.google.com with SMTP id 2adb3069b0e04-501cba1ec0aso5239633e87.2 for <65491@debbugs.gnu.org>; Sat, 16 Sep 2023 10:23:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1694884977; x=1695489777; darn=debbugs.gnu.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=7D8G7uCOTYGgEgMURpVzf7uu4OEanmvRIucjpaFQw8Y=; b=gjC83R99FMLXqjqCQoMikS5DelncOM/vKn9tp31j5YoI/v6qUzuynAmHabQVfzvgqe SjjxrBmgwAyNuclTeVPxkDxLYBFJtrRNcsdxFNOFjMXoG85PBQCaSET5QUIr1r8/nqIr VpyVwx5tCD3GVEQv7Zo6OwcFkr0M1Mu22AknIKd/hXxWHnJbxMXx6WAs2UpdxLZFiMk1 2tDR1EN5L1ph6xwNp7hEFaG3nbeolasghTBpe6B4uUeREzXhpjjWEJs3zymJy8PZUx38 Bt8NVkCZWFkyDrPEYF+w3CiR96WcsmBGfSLd7SXUx2J54sMgZQVyN022FM33X6hRwUM5 hC2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694884977; x=1695489777; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=7D8G7uCOTYGgEgMURpVzf7uu4OEanmvRIucjpaFQw8Y=; b=d5CDRX9grbrI69/lgPmwtCcn6Gbk2JEld3sVbWwqndJBLAhgV4ug/4uawqAjTq+bRY rZHmdQElmkDMpYdK8AZJMs6yT7zTCr4vsxuzzLaEAtws5sXs28xBOZWLG5vXzSRbZ/or Mxg3f5N6PkCPd6g2Ra/2rOfz+8i0OynGwLVxuza6klzJef4jUC7xWQxxh5CU6aKQqqz8 070v3qycjh+oj3T89+0SX+T377sbEmcKcoSwM+erihT/fqPYEXiGgBibvAMIdsFudDJ6 ZemV60O2PBI91NqvI/Wzlpdyr/NkHTYS4fHW9bUubW+dz9wcp4lR4QuMbqokzGuEn9dh dRfQ== X-Gm-Message-State: AOJu0YwvCzcPLKF6jAIg840t5p+11MyhjYmoqPyCStkOFXWI6F/MJYHm 4xbAeRX0T7uk4urTUmrRVyYq5B/NpdY= X-Google-Smtp-Source: AGHT+IFTg7hVHlwZ6IFMM0l616bcchCcEcwY+Fn0liSYmLba+Z2TPgSQ7HMyyXeyZD3Vq8CIDI8ivw== X-Received: by 2002:ac2:5633:0:b0:500:c348:7efd with SMTP id b19-20020ac25633000000b00500c3487efdmr4054149lff.59.1694884977291; Sat, 16 Sep 2023 10:22:57 -0700 (PDT) Original-Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id q17-20020ac25151000000b004fe3c53bb69sm1100909lfd.307.2023.09.16.10.22.55 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 16 Sep 2023 10:22:55 -0700 (PDT) In-Reply-To: <83r0mygi4y.fsf@gnu.org> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:270641 Archived-At: 16 sep. 2023 kl. 19.09 skrev Eli Zaretskii : > Sorry, I cannot accept this kind of "discussions" when such tricky > issues come up. What's the rush of installing changes when you still > didn't answer my questions, and we still are not sure these changes > are correct? I'm confident that they are correct. Moreover, I'm also confident that = the old code was incorrect, which is why the change was carried out. = Both the C standard and modern C compilers agree. There's nothing strange or unusual that the 32-bit --with-wide-int = configuration sees unexpected warnings when code is changed. You must = have seen that many times before. It doesn't mean that there is anything = wrong with the change; in this case it was just a somewhat pedantic GCC = warning, quickly silenced. >>> It does, but LISP_WORD_TAG(type) is a 64=3Dbit type with the only = bits >>> set above 32 bit, so how casting it to uintptr_t is TRT? >>=20 >> Because XUNTAG is used to get the pointer part; we don't want the tag = bits.=20 >=20 > Then just casting should do, no? Why the subtraction? Because when Lisp_Object is pointer-sized we need to remove the tag bits = from the word. Only in the special configuration with a Lisp_Object that = is larger than pointers can we simply cast away the tag bits.