* browse-url.el actually hardwires names
@ 2004-04-12 17:17 Dan Jacobson
0 siblings, 0 replies; only message in thread
From: Dan Jacobson @ 2004-04-12 17:17 UTC (permalink / raw)
Gentlemen, in browse-url.el we see passages like
(message "Starting Netscape...")
(apply 'start-process (concat "netscape" url) nil
browse-url-netscape-program
He has hardwired the word Netscape into the message, whilst allowing
the variable browse-url-netscape-program to vary.
Therefor he would be better off saying
(message "Starting browse-url-netscape-program") or better
(message (concat "Starting " browse-url-netscape-program))
The user would then not still see "Netscape" when he has instead
left it for some future rival.
There are several similar occurrences of this throughout the file.
$ grep Starting /usr/share/emacs/21.3/lisp/net/browse-url.el
(message "Starting Netscape...")
(message "Starting Mozilla...")
(message "Starting Galeon...")
(message "Starting Mosaic...")
(message "Starting Mosaic...done"))))
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2004-04-12 17:17 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-04-12 17:17 browse-url.el actually hardwires names Dan Jacobson
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).