From: Dan Jacobson <jidanni@jidanni.org>
Subject: browse-url.el actually hardwires names
Date: Tue, 13 Apr 2004 01:17:58 +0800 [thread overview]
Message-ID: <874qrp6rp5.fsf@jidanni.org> (raw)
Gentlemen, in browse-url.el we see passages like
(message "Starting Netscape...")
(apply 'start-process (concat "netscape" url) nil
browse-url-netscape-program
He has hardwired the word Netscape into the message, whilst allowing
the variable browse-url-netscape-program to vary.
Therefor he would be better off saying
(message "Starting browse-url-netscape-program") or better
(message (concat "Starting " browse-url-netscape-program))
The user would then not still see "Netscape" when he has instead
left it for some future rival.
There are several similar occurrences of this throughout the file.
$ grep Starting /usr/share/emacs/21.3/lisp/net/browse-url.el
(message "Starting Netscape...")
(message "Starting Mozilla...")
(message "Starting Galeon...")
(message "Starting Mosaic...")
(message "Starting Mosaic...done"))))
reply other threads:[~2004-04-12 17:17 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874qrp6rp5.fsf@jidanni.org \
--to=jidanni@jidanni.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).