unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stephen Berman <stephen.berman@gmx.net>
To: bug-gnu-emacs@gnu.org
Cc: emacs-pretest-bug@gnu.org
Subject: bug#410: 23.0.60; display-buffer regression
Date: Sun, 15 Jun 2008 00:34:47 +0200	[thread overview]
Message-ID: <874p7vfxx4.fsf@escher.local.home> (raw)
In-Reply-To: 4853920E.9020106@gmx.at

On Sat, 14 Jun 2008 11:40:30 +0200 martin rudalics <rudalics@gmx.at> wrote:

>> The recent reimplementation of display-buffer in lisp resulted in the
>> following changed behavior, which I consider a regression:
>>
>> 1. emacs -Q
>>
>> 2. M-x calendar
>>    ==> The window is vertically split, the *scratch* buffer above and
>>    the Calendar buffer is below in a smaller window sized to fit.
>>
>> 3. M-: (pop-to-buffer (get-buffer "*Messages*"))
>>    ==> Now the *Messages* buffer is above and the Calendar buffer is
>>    still below, but the windows are evenly split, i.e. the Calendar
>>    window is no longer sized to fit but is too big.  Prior to the
>>    reimplementation of display-buffer doing this step did not change the
>>    height of the Calendar window.
>>
>> The behavior in step 3 results from the invocation of
>> window--even-window-heights in the last clause of the cond in
>> display-buffer, which happens because the *Messages* buffer exits but is
>> not displayed.  If the sexp in step 3 contained *scratch* instead of
>> *Messages*, the height of the Calendar window would not have changed.
>
> Thanks for noticing this.
>
>> Looking at the pre-reimplementation source of Fdisplay_buffer, it looks
>> like the window heights should get evened out just as in the lisp
>> reimplementation; nevertheless, this is not what happens in the above
>> recipe with the older code.
>
> It's because in the Elisp code I evened window heights whenever they
> were not equal.  The original code evened heights only when the height
> of the window to display BUFFER-OR-NAME was less than that of the
> selected window.  

Thanks for the explication, I didn't grasp that in my cursory perusal.

>                   I've tried to restore the original behavior.  Please
> try again.

Your patch makes display-buffer work as it previously did in cases like
the above; thanks.

Steve Berman








      reply	other threads:[~2008-06-14 22:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-13 22:04 bug#410: 23.0.60; display-buffer regression Stephen Berman
2008-06-14  9:40 ` martin rudalics
2008-06-14 22:34   ` Stephen Berman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874p7vfxx4.fsf@escher.local.home \
    --to=stephen.berman@gmx.net \
    --cc=410@emacsbugs.donarmstrong.com \
    --cc=bug-gnu-emacs@gnu.org \
    --cc=emacs-pretest-bug@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).