unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@jurta.org>
To: "Drew Adams" <drew.adams@oracle.com>
Cc: 2397@emacsbugs.donarmstrong.com
Subject: bug#2397: 23.0.90; grep no longer highlights the match
Date: Sun, 22 Feb 2009 21:01:36 +0200	[thread overview]
Message-ID: <874oymnvx3.fsf@jurta.org> (raw)
In-Reply-To: <000f01c99516$f20a9a10$0200a8c0@us.oracle.com> (Drew Adams's message of "Sun, 22 Feb 2009 09:56:52 -0800")

> Even more specifically, it is the change from
> (setenv "GREP_OPTIONS" (concat (getenv "GREP_OPTIONS") " --color=always"))
> to
> (setenv "GREP_OPTIONS" (concat (getenv "GREP_OPTIONS") " --color=auto"))
> that introduces the bug. Putting back `always' in place of `auto' restores the
> highlighting.
>
> Why `auto' doesn't work, I don't know.

This change was the result of the following discussion:

http://thread.gmane.org/gmane.emacs.bugs/16956
http://thread.gmane.org/gmane.emacs.devel/83316

As you can see grep source code emits highlighting sequences
only when TERM is not "dumb".  So we set it to "emacs-grep".

          if(isatty(STDOUT_FILENO) && getenv("TERM") &&
	     strcmp(getenv("TERM"), "dumb"))
                  color_option = 1;
          else
            color_option = 0;

Could you please post the value of `process-connection-type'.
Also please eval `M-x grep RET set RET' and show the value of
the environment variable `TERM'.

If it is "emacs-grep" then I'm afraid it is the line
"isatty(STDOUT_FILENO)" in grep source code that fails
in your environment.

-- 
Juri Linkov
http://www.jurta.org/emacs/






  reply	other threads:[~2009-02-22 19:01 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <utz6eo3ue.fsf@gnu.org>
2009-02-19 23:26 ` bug#2397: 23.0.90; grep no longer highlights the match Drew Adams
2009-02-22 17:56   ` Drew Adams
2009-02-22 19:01     ` Juri Linkov [this message]
2009-02-22 20:04       ` Drew Adams
2009-02-22 22:08         ` Juri Linkov
2009-02-22 22:27           ` Drew Adams
2009-02-22 22:52             ` Juri Linkov
2009-02-22 23:14               ` Drew Adams
2009-02-22 23:48                 ` Juri Linkov
2009-02-24  0:56                   ` Drew Adams
2009-02-28 17:50   ` bug#2397: marked as done (23.0.90; grep no longer highlights the match) Emacs bug Tracking System
     [not found] ` <000701c999ce$aa77cb20$0200a8c0@us.oracle.com>
     [not found]   ` <usklyo063.fsf@gnu.org>
     [not found]     ` <001201c999da$77282650$0200a8c0@us.oracle.com>
2009-02-28 20:10       ` bug#2397: 23.0.90; grep no longer highlights the match Eli Zaretskii
2009-02-28 21:09         ` Drew Adams
2009-02-28 22:08           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874oymnvx3.fsf@jurta.org \
    --to=juri@jurta.org \
    --cc=2397@emacsbugs.donarmstrong.com \
    --cc=drew.adams@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).