From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#6227: Color isearch regexp submatches differently Date: Sun, 23 May 2010 19:12:35 +0300 Organization: JURTA Message-ID: <874ohyppfs.fsf@mail.jurta.org> References: <87bpca15ja.fsf@mail.jurta.org> <87wruv1ohr.fsf@mail.jurta.org> <877hmvtn9t.fsf@mail.jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1274632052 31287 80.91.229.12 (23 May 2010 16:27:32 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 23 May 2010 16:27:32 +0000 (UTC) Cc: 6227@debbugs.gnu.org To: Lennart Borgman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun May 23 18:27:29 2010 connect(): No such file or directory Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OGE1O-0008MB-K1 for geb-bug-gnu-emacs@m.gmane.org; Sun, 23 May 2010 18:27:28 +0200 Original-Received: from localhost ([127.0.0.1]:34571 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OGE1M-0000eG-AI for geb-bug-gnu-emacs@m.gmane.org; Sun, 23 May 2010 12:27:24 -0400 Original-Received: from [140.186.70.92] (port=56590 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OGE1F-0000cj-GI for bug-gnu-emacs@gnu.org; Sun, 23 May 2010 12:27:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OGE18-0006o8-Pa for bug-gnu-emacs@gnu.org; Sun, 23 May 2010 12:27:12 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:41684) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OGE18-0006ny-Nr for bug-gnu-emacs@gnu.org; Sun, 23 May 2010 12:27:10 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1OGDqL-0000GK-Mw; Sun, 23 May 2010 12:16:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 May 2010 16:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6227 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 6227-submit@debbugs.gnu.org id=B6227.1274631309991 (code B ref 6227); Sun, 23 May 2010 16:16:01 +0000 Original-Received: (at 6227) by debbugs.gnu.org; 23 May 2010 16:15:09 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OGDpV-0000Fw-6Q for submit@debbugs.gnu.org; Sun, 23 May 2010 12:15:09 -0400 Original-Received: from smtp-out1.starman.ee ([85.253.0.3] helo=mx1.starman.ee) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OGDpS-0000FK-W2 for 6227@debbugs.gnu.org; Sun, 23 May 2010 12:15:07 -0400 X-Virus-Scanned: by Amavisd-New at mx1.starman.ee Original-Received: from mail.starman.ee (82.131.98.186.cable.starman.ee [82.131.98.186]) by mx1.starman.ee (Postfix) with ESMTP id 67AED3F40BD; Sun, 23 May 2010 19:14:59 +0300 (EEST) In-Reply-To: (Lennart Borgman's message of "Sun, 23 May 2010 12:04:50 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sun, 23 May 2010 12:16:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:37209 Archived-At: >> I think `reb-update-overlays' should be completely rewritten >> for isearch.el. > > You surely know this things much better than me, but is there any > reason to double the code? `reb-update-overlays' highlights all matches in the buffer. This is like what lazy-highlighting does. But we agreed that it should affect only the current isearch match, not all lazy-highlighted matches. > If it is rewritten why not let re-builder share the same code? Yes, and query-replace highlighting could share it too. >> The only thing we need from re-builder.el are faces >> reb-match-1, reb-match-2, reb-match-3. =A0We should try >> using the existing faces for the same functionality. --=20 Juri Linkov http://www.jurta.org/emacs/