bug#7046: 23.1; Repeating emacs macro skipping every second line

bug#7046: 23.1; Repeating emacs macro skipping every second line

[Gord Wait]

I created a keyboard macro to move a word from the end of the line to the start of the line. At the end of it I include the commands - "move-beggining-of-line" followed by "next-line" so that I can repeat it through my file.
If I run it interactively "by hand" it works great. If I call it with a numerical repeat value to make it run say 20 times, it skips every second line.

This basically makes keyboard macros useless to me for the first time in over 25 years of using emacs.. I will try "forward-line" to see if it behaves the same way..



In GNU Emacs 23.1.1 (i386-mingw-nt5.1.2600)
 of 2009-07-29 on SOFT-MJASON
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.4)'

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: C.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: cp1252
  default-enable-multibyte-characters: t

Major mode: Tcl

Minor modes in effect:
  show-paren-mode: t
  tooltip-mode: t
  tool-bar-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
C-x ( C-s P I N _ C-f C-s - t o C-f C-SPC C-e C-w C-a
C-y SPC C-a C-n C-x ) C-x C-s C-x e C-x e C-x e C-x
C-s C-k C-/ C-u 2 0 C-x e C-/ C-/ C-/ C-/ C-/ C-/ C-/
C-/ C-/ C-/ C-/ C-/ C-a C-x C-s <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <menu-bar> <help-menu>
<send-emacs-bug-report>

Recent messages:
Saving file c:/firmware/projects/Proj_137_UC_S2_ExtremeCard_Stratix/trunk/board_test_system_for_S4_card/bts_config/bts_config_pinout.tcl...
Wrote c:/firmware/projects/Proj_137_UC_S2_ExtremeCard_Stratix/trunk/board_test_system_for_S4_card/bts_config/bts_config_pinout.tcl
(Type e to repeat macro) [3 times]
Saving file c:/firmware/projects/Proj_137_UC_S2_ExtremeCard_Stratix/trunk/board_test_system_for_S4_card/bts_config/bts_config_pinout.tcl...
Wrote c:/firmware/projects/Proj_137_UC_S2_ExtremeCard_Stratix/trunk/board_test_system_for_S4_card/bts_config/bts_config_pinout.tcl
Undo!
(Type e to repeat macro)
Undo! [12 times]
Saving file c:/firmware/projects/Proj_137_UC_S2_ExtremeCard_Stratix/trunk/board_test_system_for_S4_card/bts_config/bts_config_pinout.tcl...
Wrote c:/firmware/projects/Proj_137_UC_S2_ExtremeCard_Stratix/trunk/board_test_system_for_S4_card/bts_config/bts_config_pinout.tcl

*** E-Mail body has been placed on clipboard, please paste them here! ***

This e-mail may contain information that is privileged, confidential or otherwise exempt from disclosure under applicable laws. Unauthorized use, reproduction or dissemination of the e-mail is strictly prohibited. If you have received this e-mail in error, please contact the sender immediately. [11EABB509DF]

bug#7047: 23.1; Repeating emacs macro skipping every second line

[Gord Wait]

I don't know how to add comments to a reported bug.. so I'll try this..

I also tried using "forward-line" and got similar results.

It seems to be dependent on how many repeats I select. If I auto repeat say 10 lines worth,
It seems to be ok. If I auto repeat the macro 1000 times, then it starts to skip every line at some point..

-----Original Message-----
From: Gord Wait
Sent: Thursday, September 16, 2010 11:38 AM
To: 'bug-gnu-emacs@gnu.org'
Subject: 23.1; Repeating emacs macro skipping every second line

I created a keyboard macro to move a word from the end of the line to the start of the line. At the end of it I include the commands - "move-beggining-of-line" followed by "next-line" so that I can repeat it through my file.
If I run it interactively "by hand" it works great. If I call it with a numerical repeat value to make it run say 20 times, it skips every second line.

This basically makes keyboard macros useless to me for the first time in over 25 years of using emacs.. I will try "forward-line" to see if it behaves the same way..



In GNU Emacs 23.1.1 (i386-mingw-nt5.1.2600)
 of 2009-07-29 on SOFT-MJASON
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.4)'

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: C.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: cp1252
  default-enable-multibyte-characters: t

Major mode: Tcl

Minor modes in effect:
  show-paren-mode: t
  tooltip-mode: t
  tool-bar-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  global-auto-composition-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
C-x ( C-s P I N _ C-f C-s - t o C-f C-SPC C-e C-w C-a
C-y SPC C-a C-n C-x ) C-x C-s C-x e C-x e C-x e C-x
C-s C-k C-/ C-u 2 0 C-x e C-/ C-/ C-/ C-/ C-/ C-/ C-/
C-/ C-/ C-/ C-/ C-/ C-a C-x C-s <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <help-echo> <help-echo>
<help-echo> <help-echo> <help-echo> <menu-bar> <help-menu>
<send-emacs-bug-report>

Recent messages:
Saving file c:/firmware/projects/Proj_137_UC_S2_ExtremeCard_Stratix/trunk/board_test_system_for_S4_card/bts_config/bts_config_pinout.tcl...
Wrote c:/firmware/projects/Proj_137_UC_S2_ExtremeCard_Stratix/trunk/board_test_system_for_S4_card/bts_config/bts_config_pinout.tcl
(Type e to repeat macro) [3 times]
Saving file c:/firmware/projects/Proj_137_UC_S2_ExtremeCard_Stratix/trunk/board_test_system_for_S4_card/bts_config/bts_config_pinout.tcl...
Wrote c:/firmware/projects/Proj_137_UC_S2_ExtremeCard_Stratix/trunk/board_test_system_for_S4_card/bts_config/bts_config_pinout.tcl
Undo!
(Type e to repeat macro)
Undo! [12 times]
Saving file c:/firmware/projects/Proj_137_UC_S2_ExtremeCard_Stratix/trunk/board_test_system_for_S4_card/bts_config/bts_config_pinout.tcl...
Wrote c:/firmware/projects/Proj_137_UC_S2_ExtremeCard_Stratix/trunk/board_test_system_for_S4_card/bts_config/bts_config_pinout.tcl

*** E-Mail body has been placed on clipboard, please paste them here! ***

This e-mail may contain information that is privileged, confidential or otherwise exempt from disclosure under applicable laws. Unauthorized use, reproduction or dissemination of the e-mail is strictly prohibited. If you have received this e-mail in error, please contact the sender immediately. [11EABB509DF]

bug#7047: Please close 7047 it is a duplicate of 7046

[Gord Wait]

Thanks..


This e-mail may contain information that is privileged, confidential or otherwise exempt from disclosure under applicable laws. Unauthorized use, reproduction or dissemination of the e-mail is strictly prohibited. If you have received this e-mail in error, please contact the sender immediately. [11EABB509DF]

bug#7047: Please close 7047 it is a duplicate of 7046

[Stefan Monnier]

You can close your bugs yourself by sending a message to
<nnn>-done@debbugs.gnu.org.  That's actually what I've done with this
message (in Bcc), so just try and remember for next time,


        Stefan

bug#7047: Please close 7047 it is a duplicate of 7046

[Glenn Morris]

Stefan Monnier wrote:

> You can close your bugs yourself by sending a message to
> <nnn>-done@debbugs.gnu.org.  That's actually what I've done with this
> message (in Bcc), so just try and remember for next time,

It had been merged with 7046, so now both are closed.
I will sort it out.

bug#7046: More info

[Gord Wait]

I also tried using "forward-line" and got similar results.

It seems to be dependent on how many repeats I select. If I auto repeat say 10 lines worth,
It seems to be ok. If I auto repeat the macro 1000 times, then it starts to skip every line at some point..


This e-mail may contain information that is privileged, confidential or otherwise exempt from disclosure under applicable laws. Unauthorized use, reproduction or dissemination of the e-mail is strictly prohibited. If you have received this e-mail in error, please contact the sender immediately. [11EABB509DF]

bug#7046: More info

[Stefan Monnier]

> I also tried using "forward-line" and got similar results.  It seems
> to be dependent on how many repeats I select. If I auto repeat say 10
> lines worth, It seems to be ok. If I auto repeat the macro 1000 times,
> then it starts to skip every line at some point..

Both cases sound like bugs, but without a concrete test case it's
difficult to track it down.  Can you provide a precise test case
(e.g. a sample file and the key strokes you hit to define and run the
macro, ideally starting from "emacs -Q")?


        Stefan

bug#7046: More info

[Gord Wait]

Hopefully this update will make it, Glenn Morris emailed me to note that the 7046 bug got closed (by accident)..

Here is the explanation. Below it are some sample lines. Build a file with a couple hundred of those lines to test against..

--------------------------------------------

The goal of the edit work is to cut the last "word" of each line and place it as the first "word" of each line.
(Later I sort-lines, this way the lines are sorted by the value of the original last word of the line)..

I create a keyboard macro that knows the line syntax, and does one line of work:


(fset 'moveword
   [?\C-s ?- ?t ?o ?\C-f ?\C-  ?\C-e ?\C-w ?\C-a ?\C-y ?  ?\C-a ?\C-n])

Macro edit view of the same thing:
Macro:

C-s                     ;; isearch-forward
-to                     ;; self-insert-command * 3
C-f                     ;; forward-char
C-SPC                   ;; set-mark-command
C-e                     ;; move-end-of-line
C-w                     ;; kill-region
C-a                     ;; move-beginning-of-line
C-y                     ;; yank
SPC                     ;; self-insert-command
C-a                     ;; move-beginning-of-line
C-n                     ;; next-line

Place the cursor at the start of any line and run the macro once

(Esc-x moveword)

It finds the ascii "-to" word, moves ahead to the last word, cuts and pastes it at the start, then drops down one line.

Try it repeatedly for a few lines manually to show the macro works as desired..

Now try to auto repeat the macro 100 times:

(Ctrl-u 100 Esc-x moveword)

Macro repeats, but at some point starts skipping a line.

I also manually executed the macro succesfully on lines that failed the 100 repeat, to show that it wasn't some artifact of those failed lines..

-----------------------------------------------
Sample lines to be manipulated by the macro.. Make a file with a few hundred of these in it. Duplicating these ones will be fine to show the bug. In the real file each line is unique.
-----------------------------------------------
set_location_assignment PIN_AP23 -to ddr3bot_dq[36]
set_location_assignment PIN_AM23 -to ddr3bot_dq[35]
set_location_assignment PIN_AT23 -to ddr3bot_dq[34]
set_location_assignment PIN_AN23 -to ddr3bot_dq[33]
set_location_assignment PIN_AU23 -to ddr3bot_dq[32]
set_location_assignment PIN_AK17 -to ddr3bot_dq[31]
set_location_assignment PIN_AG17 -to ddr3bot_dq[30]
set_location_assignment PIN_AH17 -to ddr3bot_dq[29]
set_location_assignment PIN_AG16 -to ddr3bot_dq[28]
set_location_assignment PIN_AL17 -to ddr3bot_dq[27]
set_location_assignment PIN_AH16 -to ddr3bot_dq[26]
set_location_assignment PIN_AM17 -to ddr3bot_dq[25]
set_location_assignment PIN_AJ16 -to ddr3bot_dq[24]
set_location_assignment PIN_AU15 -to ddr3bot_dq[23]
set_location_assignment PIN_AR17 -to ddr3bot_dq[22]
set_location_assignment PIN_AT15 -to ddr3bot_dq[21]
set_location_assignment PIN_AP17 -to ddr3bot_dq[20]
set_location_assignment PIN_AV16 -to ddr3bot_dq[19]
set_location_assignment PIN_AN16 -to ddr3bot_dq[18]
set_location_assignment PIN_AW16 -to ddr3bot_dq[17]
set_location_assignment PIN_AT16 -to ddr3bot_dq[16]
set_location_assignment PIN_AW12 -to ddr3bot_dq[15]
set_location_assignment PIN_AV11 -to ddr3bot_dq[14]
set_location_assignment PIN_AU14 -to ddr3bot_dq[13]
set_location_assignment PIN_AW11 -to ddr3bot_dq[12]
set_location_assignment PIN_AV14 -to ddr3bot_dq[11]
set_location_assignment PIN_AU12 -to ddr3bot_dq[10]
set_location_assignment PIN_AW14 -to ddr3bot_dq[9]
set_location_assignment PIN_AT12 -to ddr3bot_dq[8]
set_location_assignment PIN_AP13 -to ddr3bot_dq[7]
set_location_assignment PIN_AP14 -to ddr3bot_dq[6]
set_location_assignment PIN_AN13 -to ddr3bot_dq[5]
set_location_assignment PIN_AR14 -to ddr3bot_dq[4]
set_location_assignment PIN_AL14 -to ddr3bot_dq[3]
set_location_assignment PIN_AN14 -to ddr3bot_dq[2]
set_location_assignment PIN_AM13 -to ddr3bot_dq[1]
set_location_assignment PIN_AM14 -to ddr3bot_dq[0]
set_location_assignment PIN_AL23 -to ddr3bot_dqs_n[7]
set_location_assignment PIN_AU26 -to ddr3bot_dqs_n[6]



-----Original Message-----
From: Stefan Monnier [mailto:monnier@IRO.UMontreal.CA]
Sent: Friday, September 17, 2010 8:35 AM
To: Gord Wait
Cc: '7046@debbugs.gnu.org'
Subject: Re: bug#7046: More info

> I also tried using "forward-line" and got similar results.  It seems
> to be dependent on how many repeats I select. If I auto repeat say 10
> lines worth, It seems to be ok. If I auto repeat the macro 1000 times,
> then it starts to skip every line at some point..

Both cases sound like bugs, but without a concrete test case it's
difficult to track it down.  Can you provide a precise test case
(e.g. a sample file and the key strokes you hit to define and run the
macro, ideally starting from "emacs -Q")?


        Stefan

This e-mail may contain information that is privileged, confidential or otherwise exempt from disclosure under applicable laws. Unauthorized use, reproduction or dissemination of the e-mail is strictly prohibited. If you have received this e-mail in error, please contact the sender immediately. [11EABB509DF]

bug#7046: More info

[Johan Bockgård]

Gord Wait <gordwait@lighthauslogic.com> writes:

> I also tried using "forward-line" and got similar results.

Really?

> It seems to be dependent on how many repeats I select. If I auto
> repeat say 10 lines worth, It seems to be ok. If I auto repeat the
> macro 1000 times, then it starts to skip every line at some point..

next-line can move to the wrong column when point gets below the end of
the window.

The problem is in line-move-visual (i.e it only exists if the variable
line-move-visual is non-nil),

    ;; Otherwise, we should reset `temporary-goal-column'.
    (let ((posn (posn-at-point)))
      (cond
       ;; Handle the `overflow-newline-into-fringe' case:
       ((eq (nth 1 posn) 'right-fringe)
        (setq temporary-goal-column (cons (- (window-width) 1) hscroll)))
       ((car (posn-x-y posn))
        (setq temporary-goal-column
              (cons (/ (float (car (posn-x-y posn)))
                       (frame-char-width)) hscroll)))))

If the position is not visible in the window, posn-at-point returns nil
and temporary-goal-column is not updated as it should.

bug#10461: bug#7046: More info

[Alan Third]

Johan Bockgård <bojohan@gnu.org> writes:

> Gord Wait <gordwait@lighthauslogic.com> writes:
>
>> It seems to be dependent on how many repeats I select. If I auto
>> repeat say 10 lines worth, It seems to be ok. If I auto repeat the
>> macro 1000 times, then it starts to skip every line at some point..
>
> next-line can move to the wrong column when point gets below the end of
> the window.
>
> The problem is in line-move-visual (i.e it only exists if the variable
> line-move-visual is non-nil),
>
>     ;; Otherwise, we should reset `temporary-goal-column'.
>     (let ((posn (posn-at-point)))
>       (cond
>        ;; Handle the `overflow-newline-into-fringe' case:
>        ((eq (nth 1 posn) 'right-fringe)
>         (setq temporary-goal-column (cons (- (window-width) 1) hscroll)))
>        ((car (posn-x-y posn))
>         (setq temporary-goal-column
>               (cons (/ (float (car (posn-x-y posn)))
>                        (frame-char-width)) hscroll)))))
>
> If the position is not visible in the window, posn-at-point returns nil
> and temporary-goal-column is not updated as it should.

I can't replicate this on Emacs 27 and it's been over 7 years since the
last bug report. Can anyone confirm whether it's still a problem?
-- 
Alan Third

bug#10461: bug#7046: More info

[Eli Zaretskii]

> From: Alan Third <alan@idiocy.org>
> Date: Mon, 30 Dec 2019 14:05:03 +0000
> Cc: "'7046@debbugs.gnu.org'" <7046@debbugs.gnu.org>, 10461@debbugs.gnu.org
> 
> > The problem is in line-move-visual (i.e it only exists if the variable
> > line-move-visual is non-nil),
> >
> >     ;; Otherwise, we should reset `temporary-goal-column'.
> >     (let ((posn (posn-at-point)))
> >       (cond
> >        ;; Handle the `overflow-newline-into-fringe' case:
> >        ((eq (nth 1 posn) 'right-fringe)
> >         (setq temporary-goal-column (cons (- (window-width) 1) hscroll)))
> >        ((car (posn-x-y posn))
> >         (setq temporary-goal-column
> >               (cons (/ (float (car (posn-x-y posn)))
> >                        (frame-char-width)) hscroll)))))
> >
> > If the position is not visible in the window, posn-at-point returns nil
> > and temporary-goal-column is not updated as it should.
> 
> I can't replicate this on Emacs 27 and it's been over 7 years since the
> last bug report. Can anyone confirm whether it's still a problem?

This has been fixed several releases back, so I'm closing it.