From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.bugs Subject: bug#4894: 23.1; emacs ignores number characters in incremental search in keyboard macros Date: Tue, 30 Oct 2012 07:21:58 +0800 Message-ID: <874nlcdfu1.fsf@gnu.org> References: <87y6mdo6bi.fsf@mail.jurta.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1351552963 11356 80.91.229.3 (29 Oct 2012 23:22:43 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 29 Oct 2012 23:22:43 +0000 (UTC) Cc: Petr Machata , 4894@debbugs.gnu.org, Kenichi Handa To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 30 00:22:51 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TSyfO-0003Vh-1h for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 Oct 2012 00:22:46 +0100 Original-Received: from localhost ([::1]:50630 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TSyfF-0005qe-Om for geb-bug-gnu-emacs@m.gmane.org; Mon, 29 Oct 2012 19:22:37 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:45174) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TSyfD-0005q4-IO for bug-gnu-emacs@gnu.org; Mon, 29 Oct 2012 19:22:36 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TSyfC-0007Mk-4j for bug-gnu-emacs@gnu.org; Mon, 29 Oct 2012 19:22:35 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:56632) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TSyfC-0007Me-0q for bug-gnu-emacs@gnu.org; Mon, 29 Oct 2012 19:22:34 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TSyha-0001dT-3g for bug-gnu-emacs@gnu.org; Mon, 29 Oct 2012 19:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Oct 2012 23:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 4894 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 4894-submit@debbugs.gnu.org id=B4894.13515530746242 (code B ref 4894); Mon, 29 Oct 2012 23:25:02 +0000 Original-Received: (at 4894) by debbugs.gnu.org; 29 Oct 2012 23:24:34 +0000 Original-Received: from localhost ([127.0.0.1]:38647 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TSyh8-0001cc-Ed for submit@debbugs.gnu.org; Mon, 29 Oct 2012 19:24:34 -0400 Original-Received: from mail-pa0-f44.google.com ([209.85.220.44]:39225) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TSyh7-0001cW-2p for 4894@debbugs.gnu.org; Mon, 29 Oct 2012 19:24:33 -0400 Original-Received: by mail-pa0-f44.google.com with SMTP id fb11so3643445pad.3 for <4894@debbugs.gnu.org>; Mon, 29 Oct 2012 16:22:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=RRFVmmTZzI0ApqL0Fz8HJpKH+oQBLLhbmsRKaklfow4=; b=UcfyGYDMI2NFdHMEYcakkz9W+By9fq5WaDePMRF02uLp0YVd5itGNrqpV0m7YzJk2v B6FKJDXzaocA0eYoLjwt2yMvRuJkKSOrayYcOEe97gA7Nvwmvteff3O3UFzneW61mvf1 4Coz32poQ33LEkQlvr1CvZXu/v6K9surWrEf+rPPA2+cZR1zEjKUp3scaIqrb/PbNy8h 8SCrex2n5NAqqhpgNmmqiQVhzzkjrL8I1qTr0guTHOp/7CAuD60YZTjwP8DDrK/tMZC7 hYDGJ3NyIoo0CWp/wqb4TpFeftD0ThcPvKJMFq+/bv4Bix9vjgshJm/UMPpc/bdCkBTm 9upA== Original-Received: by 10.66.75.162 with SMTP id d2mr87094717paw.27.1351552924107; Mon, 29 Oct 2012 16:22:04 -0700 (PDT) Original-Received: from ulysses ([155.69.187.103]) by mx.google.com with ESMTPS id ho7sm6681170pbc.3.2012.10.29.16.22.00 (version=SSLv3 cipher=OTHER); Mon, 29 Oct 2012 16:22:02 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Wed, 11 Nov 2009 13:32:05 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:66221 Archived-At: Stefan Monnier writes: > Actually, the need for cancel-kbd-macro-events is explained in > the comment. The problem is that after cancelling the we should > add the ?0 replacement. That should normally be done by isearch-unread, > but for printing char, we don't call that function any more. > > I.e. the problem was introduced by the change below. Handa, can you > explain why we need this? Maybe it was needed at the time but not > any more? Since there has been no follow up in a long time, I went ahead and committed a fix that involves calling store-kbd-macro-event in the affected function.