From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#14390: 24.3.50; (wrong-type-argument stringp t) from `read-regexp' Date: Sun, 12 May 2013 02:17:05 +0300 Organization: JURTA Message-ID: <874ne9qf7y.fsf@mail.jurta.org> References: <5C8F1D9AC91F44D8B2802A79E962581C@us.oracle.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1368314572 19764 80.91.229.3 (11 May 2013 23:22:52 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 11 May 2013 23:22:52 +0000 (UTC) Cc: 14390@debbugs.gnu.org To: "Drew Adams" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun May 12 01:22:51 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UbJ7q-0005Uy-8s for geb-bug-gnu-emacs@m.gmane.org; Sun, 12 May 2013 01:22:50 +0200 Original-Received: from localhost ([::1]:35089 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UbJ7p-0005YC-Fi for geb-bug-gnu-emacs@m.gmane.org; Sat, 11 May 2013 19:22:49 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:56493) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UbJ7l-0005Xu-I8 for bug-gnu-emacs@gnu.org; Sat, 11 May 2013 19:22:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UbJ7k-0004ap-P5 for bug-gnu-emacs@gnu.org; Sat, 11 May 2013 19:22:45 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:32844) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UbJ7k-0004al-LT for bug-gnu-emacs@gnu.org; Sat, 11 May 2013 19:22:44 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1UbJ82-0000lJ-BV for bug-gnu-emacs@gnu.org; Sat, 11 May 2013 19:23:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 11 May 2013 23:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14390 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 14390-submit@debbugs.gnu.org id=B14390.13683145482826 (code B ref 14390); Sat, 11 May 2013 23:23:02 +0000 Original-Received: (at 14390) by debbugs.gnu.org; 11 May 2013 23:22:28 +0000 Original-Received: from localhost ([127.0.0.1]:36953 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UbJ7U-0000jX-95 for submit@debbugs.gnu.org; Sat, 11 May 2013 19:22:28 -0400 Original-Received: from ps18281.dreamhost.com ([69.163.218.105]:49322 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UbJ7R-0000jP-NN for 14390@debbugs.gnu.org; Sat, 11 May 2013 19:22:26 -0400 Original-Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id E9832258B9E93C; Sat, 11 May 2013 16:22:05 -0700 (PDT) In-Reply-To: <5C8F1D9AC91F44D8B2802A79E962581C@us.oracle.com> (Drew Adams's message of "Sat, 11 May 2013 14:54:12 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:74181 Archived-At: > The problem is (find-tag-default-as-regexp), which will return `t' when > TAG is nil. `t' is not a valid suggestion: SUGGESTIONS must be a list > of strings. An empty string return value for the case when TAG is nil was lost when copying this code from `read-regexp' to `find-tag-default-as-regexp' in revno:111971. It could be restored back with: === modified file 'lisp/subr.el' --- lisp/subr.el 2013-04-27 23:07:46 +0000 +++ lisp/subr.el 2013-05-11 23:16:36 +0000 @@ -2715,7 +2715,7 @@ (defun find-tag-default-as-regexp () (get major-mode 'find-tag-default-function) 'find-tag-default)) (tag (funcall tagf))) - (cond ((not tag)) + (cond ((not tag) "") ((eq tagf 'find-tag-default) (format "\\_<%s\\_>" (regexp-quote tag))) (t (regexp-quote tag))))) BTW, the same commit revno:111971 introduced the function `hi-lock-read-regexp-defaults'. I think this is a good thing, and I propose to improve it by adding `read-regexp-defaults-or-tag' and `read-regexp-defaults-or-history' as we were discussing a month ago.