From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nathan Trapuzzano Newsgroups: gmane.emacs.bugs Subject: bug#13446: 24.2; Fix loop test in linum.el Date: Fri, 25 Oct 2013 11:26:32 -0400 Message-ID: <874n85cqxj.fsf@nbtrap.com> References: <87y5fvp7ti.fsf@nbtrap.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1382714902 24045 80.91.229.3 (25 Oct 2013 15:28:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 25 Oct 2013 15:28:22 +0000 (UTC) To: 13446@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 25 17:28:26 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VZjJG-0001Ee-JF for geb-bug-gnu-emacs@m.gmane.org; Fri, 25 Oct 2013 17:28:22 +0200 Original-Received: from localhost ([::1]:59747 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VZjJG-0003Xn-6T for geb-bug-gnu-emacs@m.gmane.org; Fri, 25 Oct 2013 11:28:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53913) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VZjJ5-0003Qq-5I for bug-gnu-emacs@gnu.org; Fri, 25 Oct 2013 11:28:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VZjIx-0000CG-7W for bug-gnu-emacs@gnu.org; Fri, 25 Oct 2013 11:28:11 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:57834) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VZjIx-0000C6-42 for bug-gnu-emacs@gnu.org; Fri, 25 Oct 2013 11:28:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1VZjIw-0000yb-IC for bug-gnu-emacs@gnu.org; Fri, 25 Oct 2013 11:28:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Nathan Trapuzzano Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 25 Oct 2013 15:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13446 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.13827148593690 (code B ref -1); Fri, 25 Oct 2013 15:28:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 25 Oct 2013 15:27:39 +0000 Original-Received: from localhost ([127.0.0.1]:43620 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VZjIX-0000xN-M9 for submit@debbugs.gnu.org; Fri, 25 Oct 2013 11:27:38 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:51936) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VZjIU-0000wt-Vy for submit@debbugs.gnu.org; Fri, 25 Oct 2013 11:27:36 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VZjIH-0008TJ-Q5 for submit@debbugs.gnu.org; Fri, 25 Oct 2013 11:27:29 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:34137) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VZjIH-0008TA-MY for submit@debbugs.gnu.org; Fri, 25 Oct 2013 11:27:21 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53581) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VZjIA-0003Os-NU for bug-gnu-emacs@gnu.org; Fri, 25 Oct 2013 11:27:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VZjI3-0008Qe-Oq for bug-gnu-emacs@gnu.org; Fri, 25 Oct 2013 11:27:14 -0400 Original-Received: from oproxy13-pub.mail.unifiedlayer.com ([69.89.16.30]:45978) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1VZjI3-0008QC-Fn for bug-gnu-emacs@gnu.org; Fri, 25 Oct 2013 11:27:07 -0400 Original-Received: (qmail 16461 invoked by uid 0); 25 Oct 2013 15:26:38 -0000 Original-Received: from unknown (HELO host393.hostmonster.com) (66.147.240.193) by oproxy13.mail.unifiedlayer.com with SMTP; 25 Oct 2013 15:26:37 -0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbtrap.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References:Subject:To:From; bh=lYQcpg/uS6tDl+J+0746jRBxAX+/V9Ugfn6eItLmfFg=; b=TGEv1LgbPy7wBnQFt8zuW+n4DbSGj5pc/5SIMfmxRCF7AgXOXzdI586YmtySHomjGNdPJ8hqHETx6vCGiG5Wu1bopGTld/Leld96BaJYSCeXYraHyJBGPLPxCqlZrEfF; Original-Received: from [50.90.253.209] (port=41765 helo=Nathan-GNU) by host393.hostmonster.com with esmtpsa (TLSv1:CAMELLIA128-SHA:128) (Exim 4.80) (envelope-from ) id 1VZjHZ-00021s-85 for bug-gnu-emacs@gnu.org; Fri, 25 Oct 2013 09:26:37 -0600 In-Reply-To: <87y5fvp7ti.fsf@nbtrap.com> (Nathan Trapuzzano's message of "Mon, 14 Jan 2013 20:13:13 -0500") User-Agent: Gnus/5.130007 (Ma Gnus v0.7) Emacs/24.3 (gnu/linux) X-Identified-User: {1585:host393.hostmonster.com:nbtrapco:nbtrap.com} {sentby:smtp auth 50.90.253.209 authed with nbtrap@nbtrap.com} X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:79644 Archived-At: Any reason why this hasn't been accepted? Nathan Trapuzzano writes: > There is an incorrect loop test in linum.el that potentially applies an > overlay to a line not visible in the window and thereby messes up the > width of the overlays in the lines that are visible. The patch/merge > directive is attached, and what follows is the commit message: > > ----- > > Modify loop test in `linum-update-window'. > > `limit' is set to the position returned by `window-end'; this position > is either on the last visible (logical) line in the buffer or is the > first position on the line following the last visible line. In the > former case, the loop variable never reaches the value of `limit', but > in the latter case, an overlay is applied to a line that is not > visible in the window. This can mess up the width of the overlay on > the visible lines, especially if the width of the line number (as a > string) of the line that's not visible is different from the width of > the visible lines' line numbers. > # Bazaar merge directive format 2 (Bazaar 0.90) > # revision_id: nbtrap@nbtrap.com-20130115010121-h7kwjyr5kimowgml > # target_branch: . > # testament_sha1: a9154d3ede2b389220646bb8e9e708117d876d01 > # timestamp: 2013-01-14 20:03:26 -0500 > # base_revision_id: nbtrap@nbtrap.com-20130111013646-pn4xh5r94x5asomb > # > # Begin patch > === modified file 'lisp/linum.el' > --- lisp/linum.el 2012-01-19 07:21:25 +0000 > +++ lisp/linum.el 2013-01-15 00:45:27 +0000 > @@ -151,7 +151,7 @@ > (run-hooks 'linum-before-numbering-hook) > ;; Create an overlay (or reuse an existing one) for each > ;; line visible in this window, if necessary. > - (while (and (not (eobp)) (<= (point) limit)) > + (while (and (not (eobp)) (< (point) limit)) > (let* ((str (if fmt > (propertize (format fmt line) 'face 'linum) > (funcall linum-format line))) > > # Begin bundle > IyBCYXphYXIgcmV2aXNpb24gYnVuZGxlIHY0CiMKQlpoOTFBWSZTWdjgvvgAABJfgAAQQGFxUBIA > AACv794QIABkRTaajamQyGjTaRiFGgBMBBkwQhDmaVnH5r9hMFQyJ7EUzThiw4Ixc/mQVpexbPS2 > 9yLLTxaFbWvXcN2zcydOQxpD652acQC4g4Z96jI5BipgKAAiM5Zz45Kd/4u5IpwoSGxwX3wA