unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Tassilo Horn <tsdh@gnu.org>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: Michael Heerdegen <michael_heerdegen@web.de>, 16238@debbugs.gnu.org
Subject: bug#16238: 24.3.50; pcase docs (and possibly pcase) wrong
Date: Tue, 24 Dec 2013 16:34:31 +0100	[thread overview]
Message-ID: <874n5yuut4.fsf@thinkpad.tsdh.org> (raw)
In-Reply-To: <jwv8uva2te4.fsf-monnier+emacsbugs@gnu.org> (Stefan Monnier's message of "Tue, 24 Dec 2013 09:53:35 -0500")

Stefan Monnier <monnier@IRO.UMontreal.CA> writes:

>> (defun evaluate (exp env)
>>   (pcase exp
>>     (`(add ,x ,y)         (+ (evaluate x env) (evaluate y env)))
>>     (`(call ,fun ,arg)    (funcall (evaluate fun) (evaluate arg env)))
>>                                                 `--- HERE!
>
> Indeed, feel free to fix it.

Done.

>> But shouldn't `arg' be substituted with 'x and `body' with '(add 1
>> x)?
>
> No, the code is meant for lexical-binding.

Ok, I see.  I've also mentioned that in the docs, though I guess you can
refine that comment to be more specific.

Bye,
Tassilo





  reply	other threads:[~2013-12-24 15:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-24  9:13 bug#16238: 24.3.50; pcase docs (and possibly pcase) wrong Tassilo Horn
2013-12-24  9:37 ` Tassilo Horn
2013-12-24  9:55 ` Michael Heerdegen
2013-12-24 14:53 ` Stefan Monnier
2013-12-24 15:34   ` Tassilo Horn [this message]
2013-12-24 20:13     ` Glenn Morris
2013-12-25  9:15       ` Tassilo Horn
2013-12-25 20:04         ` Tassilo Horn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874n5yuut4.fsf@thinkpad.tsdh.org \
    --to=tsdh@gnu.org \
    --cc=16238@debbugs.gnu.org \
    --cc=michael_heerdegen@web.de \
    --cc=monnier@IRO.UMontreal.CA \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).