From: Thierry Volpiatto <thierry.volpiatto@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 16197@debbugs.gnu.org
Subject: bug#16197: 24.3.50; no completion on commands following "sudo" in shell and eshell
Date: Sat, 04 Jan 2014 06:33:02 +0100 [thread overview]
Message-ID: <874n5kfh0x.fsf@gmail.com> (raw)
In-Reply-To: <jwvha9kr8fi.fsf-monnier+emacsbugs@gnu.org> (Stefan Monnier's message of "Fri, 03 Jan 2014 17:53:00 -0500")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> Maybe because you are using pcomplete-match with an hard coded value of
>> 0 for index.(Not tested)
>
> Not sure who "you" is.
Whoever wrote pcomplete/tar.
> I'm afraid your description of the problem, solutions, and problems of
> those solutions is a bit too cryptic for me.
>
> Here's my starting point:
> - I understand that currently pcomplete does not provide completion for
> "sudo" and it would be nice to add it.
> - "sudo" is not particularly special, so whatever solution is used for
> it should also work for many other commands.
> - There is already pcomplete/xargs and pcomplete/rsh.
Don't know what */rsh does, but */xargs is actually not working.
Same for tar as described in previous posts.
> Can pcomplete/sudo use the same approach as pcomplete/xargs and pcomplete/rsh?
> If not, why not?
Well I didn't read */xargs, but here are the problems:
- `pcomplete-command-name' actually is always returning the first arg of
command line e.g for "sudo apt-get" it is returning "sudo".
- `shell-command-completion' is trying to complete after what
`shell-backward-command' returns, which is actually the first command
near prompt or "[&;|]+ ", so when you try to complete after sudo or
xargs, you call the completion against "sudo" or "xargs" which returns
nothing of course.
Actually the fix made to these two functions is affecting only sudo, but
I can easily fix it to handle also 'xargs'.
> If yes but there are still problems, do those problems also affect
> pcomplete/xargs and pcomplete/rsh?
> If not, why not?
>
> If yes, then let's first focus on fixing pcomplete/xargs.
Don't think so, I think the problem should be fixed at another level as
descripted above.
You can look at the code here:
https://github.com/thierryvolpiatto/emacs-tv-config/blob/master/pcomplete-extension.el
--
Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997
next prev parent reply other threads:[~2014-01-04 5:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-20 8:18 bug#16197: 24.3.50; no completion on commands following "sudo" in shell and eshell Thierry Volpiatto
2013-12-23 8:36 ` Thierry Volpiatto
2013-12-23 10:21 ` Thierry Volpiatto
2013-12-24 6:59 ` Thierry Volpiatto
2013-12-24 10:49 ` Thierry Volpiatto
2014-01-03 22:53 ` Stefan Monnier
2014-01-04 5:33 ` Thierry Volpiatto [this message]
2014-01-04 7:11 ` Thierry Volpiatto
2014-01-04 20:26 ` Stefan Monnier
2014-01-05 7:35 ` Thierry Volpiatto
2020-09-25 17:51 ` Stefan Monnier
2020-09-26 13:09 ` Lars Ingebrigtsen
2020-09-26 22:17 ` Stefan Monnier
2020-09-27 12:08 ` Lars Ingebrigtsen
2020-09-28 2:07 ` Stefan Monnier
2020-09-28 11:12 ` Lars Ingebrigtsen
2014-01-07 13:11 ` Thierry Volpiatto
2020-09-25 10:44 ` Lars Ingebrigtsen
2014-01-07 15:26 ` Thierry Volpiatto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874n5kfh0x.fsf@gmail.com \
--to=thierry.volpiatto@gmail.com \
--cc=16197@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).