bug#16697: 24.3.50; ERC scrolltobottom module does not work anymore

bug#16697: 24.3.50; ERC scrolltobottom module does not work anymore

[Ivan Kanis]

1) emacs -Q
2) eval (setq erc-modules '(scrolltobottom)) in *scratch*
3) M-x erc RET RET RET

Wait for the window to fill up.

I expect the prompt to stay at the bottom as it used to in 24.3.


In GNU Emacs 24.3.50.1 (i686-pc-linux-gnu, GTK+ Version 2.24.20)
 of 2014-02-08 on tao.kanis.fr
Repository revision: 116348 michael.albinus@gmx.de-20140208133515-mgy8agwqq4nc6bfb
Windowing system distributor `The X.Org Foundation', version 11.0.11403000
System Description:	Ubuntu 13.10

Configured using:
 `configure --prefix=/home/ivan/emacs-bzr --without-compress-install
 'CFLAGS=-g -DSYSTEM_PURESIZE_EXTRA=1000000''

Important settings:
  value of $LANG: en_US.UTF8
  locale-coding-system: utf-8-unix

Major mode: ERC

Minor modes in effect:
  erc-scrolltobottom-mode: t
  tooltip-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
C-y H-i H-i H-i H-i H-i H-i H-i H-i H-i H-i <up> <up> 
<up> <up> <up> <up> <up> <up> <up> <up> <left> <left> 
<left> <left> <left> <left> <left> <left> <left> <left> 
<left> <left> <left> <left> <left> <left> <left> <left> 
<left> <left> <left> <left> ( s e t q SPC C-e <backspace> 
<backspace> <backspace> <backspace> <backspace> <backspace> 
<backspace> <backspace> C-k C-k C-k C-k C-k C-k C-k 
C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k C-k H-SPC 
M-SPC M-SPC <backspace> C-e ) ) C-x C-e M-x e r i c 
<return> <backspace> <backspace> c <return> <return> 
<return> <return> <return> / n i c <backspace> <backspace> 
<backspace> <backspace> M-k M-k C-x k <return> y e 
s <return> M-x e r c <return> <return> <return> 6 6 
6 <return> <return> / j SPC # e m a c s <return> C-x 
b # e m a c s <return> M-x r e p o <tab> C-g C-h v 
e m a c s m <backspace> - m o <tab> <backspace> <backspace> 
<backspace> <backspace> <backspace> <backspace> <backspace> 
<backspace> <backspace> <backspace> <backspace> <backspace> 
<backspace> <backspace> <backspace> <backspace> e r 
c - m o <tab> d <tab> l <backspace> u l e s <return> 
M-x r e p o r t - e m <tab> <return>

Recent messages:
Logging in without password
forward-sentence: End of buffer [2 times]
Connecting to irc.freenode.net:6667... ...done
Logging in as 'ivan666'...
Logging in without password
Logging in as 'ivan666'... done
Making completion list...
Quit
Making completion list... [2 times]
Type C-x 1 to delete the help window.

Load-path shadows:
None found.

Features:
(shadow sort hashcash mail-extr emacsbug message rfc822 mml mml-sec
mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils
mailheader sendmail rfc2047 rfc2045 ietf-drums mail-utils help-mode
easymenu mule-util network-stream starttls tls erc-goodies erc
erc-backend erc-compat format-spec auth-source eieio byte-opt bytecomp
byte-compile cconv eieio-core gnus-util mm-util help-fns mail-prsvr
password-cache thingatpt pp time-date tooltip electric uniquify
ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd tool-bar dnd
fontset image regexp-opt fringe tabulated-list newcomment lisp-mode
prog-mode register page menu-bar rfn-eshadow timer select scroll-bar
mouse jit-lock font-lock syntax facemenu font-core frame cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev
minibuffer nadvice loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote make-network-process
dbusbind gfilenotify dynamic-setting system-font-setting
font-render-setting move-toolbar gtk x-toolkit x multi-tty emacs)

bug#16697: 24.3.50; ERC scrolltobottom module does not work anymore

[Eli Zaretskii]

> From: Ivan Kanis <ivan@kanis.fr>
> Date: Sat, 08 Feb 2014 21:53:47 +0100
> 
> 1) emacs -Q
> 2) eval (setq erc-modules '(scrolltobottom)) in *scratch*
> 3) M-x erc RET RET RET
> 
> Wait for the window to fill up.
> 
> I expect the prompt to stay at the bottom as it used to in 24.3.

Does it help to set scroll-conservatively to a value larger than 100?

bug#16697: 24.3.50; ERC scrolltobottom module does not work anymore

[Ivan Kanis]

February, 08 at 23:03 Eli wrote:

>> From: Ivan Kanis <ivan@kanis.fr>
>> Date: Sat, 08 Feb 2014 21:53:47 +0100
>> 
>> 1) emacs -Q
>> 2) eval (setq erc-modules '(scrolltobottom)) in *scratch*
>> 3) M-x erc RET RET RET
>> 
>> Wait for the window to fill up.
>> 
>> I expect the prompt to stay at the bottom as it used to in 24.3.
>
> Does it help to set scroll-conservatively to a value larger than 100?

Hi Eli,

Of course it 'works' but it's global for all buffers. After years of
conservative scroll set to 0 I am somewhat used to it. I have set it to
101 on my configuration to see if it's nice.

This module did The Right Thing just for ERC buffers. It if can't be
fixed it should at least be removed.

Ivan
-- 
Bad user karma.
    -- BOFH excuse #7

bug#16697: 24.3.50; ERC scrolltobottom module does not work anymore

[Eli Zaretskii]

> From: Ivan Kanis <ivan@kanis.fr>
> Cc: 16697@debbugs.gnu.org
> Date: Sun, 09 Feb 2014 10:44:06 +0100
> 
> February, 08 at 23:03 Eli wrote:
> 
> >> From: Ivan Kanis <ivan@kanis.fr>
> >> Date: Sat, 08 Feb 2014 21:53:47 +0100
> >> 
> >> 1) emacs -Q
> >> 2) eval (setq erc-modules '(scrolltobottom)) in *scratch*
> >> 3) M-x erc RET RET RET
> >> 
> >> Wait for the window to fill up.
> >> 
> >> I expect the prompt to stay at the bottom as it used to in 24.3.
> >
> > Does it help to set scroll-conservatively to a value larger than 100?
> 
> Hi Eli,
> 
> Of course it 'works' but it's global for all buffers. After years of
> conservative scroll set to 0 I am somewhat used to it. I have set it to
> 101 on my configuration to see if it's nice.
> 
> This module did The Right Thing just for ERC buffers. It if can't be
> fixed it should at least be removed.

Sorry, I didn't mean to suggest that you should turn on
scroll-conservatively, I just wanted to see what causes recentering.

However, now that I tried your recipe, I see that Emacs 24.3 also
recenters, like the current trunk.  If I then type RET at the "ERC>"
prompt, the display is scrolled so that the last non-empty line is
indeed at the bottom of the window.

I think this is expected, given that scrolltobottom works off the
post-command-hook, no?

Are you sure that Emacs 24.3 behaves differently here?  Did you
perhaps use in Emacs 24.3 erc that is different from the one which was
supplied with the release tarball?

bug#16697: 24.3.50; ERC scrolltobottom module does not work anymore

[Ivan Kanis]

February, 09 at 19:16 Eli wrote:

>> From: Ivan Kanis <ivan@kanis.fr>
>> Cc: 16697@debbugs.gnu.org
>> Date: Sun, 09 Feb 2014 10:44:06 +0100
>> 
>> February, 08 at 23:03 Eli wrote:
>> 
>> >> From: Ivan Kanis <ivan@kanis.fr>
>> >> Date: Sat, 08 Feb 2014 21:53:47 +0100
>> >> 
>> >> 1) emacs -Q
>> >> 2) eval (setq erc-modules '(scrolltobottom)) in *scratch*
>> >> 3) M-x erc RET RET RET
>> >> 
>> >> Wait for the window to fill up.
>> >> 
>> >> I expect the prompt to stay at the bottom as it used to in 24.3.
>> >
>> > Does it help to set scroll-conservatively to a value larger than 100?
>> 
>> Hi Eli,
>> 
>> Of course it 'works' but it's global for all buffers. After years of
>> conservative scroll set to 0 I am somewhat used to it. I have set it to
>> 101 on my configuration to see if it's nice.
>> 
>> This module did The Right Thing just for ERC buffers. It if can't be
>> fixed it should at least be removed.
>
> Sorry, I didn't mean to suggest that you should turn on
> scroll-conservatively, I just wanted to see what causes recentering.
>
> However, now that I tried your recipe, I see that Emacs 24.3 also
> recenters, like the current trunk.  If I then type RET at the "ERC>"
> prompt, the display is scrolled so that the last non-empty line is
> indeed at the bottom of the window.
>
> I think this is expected, given that scrolltobottom works off the
> post-command-hook, no?
>
> Are you sure that Emacs 24.3 behaves differently here?  Did you
> perhaps use in Emacs 24.3 erc that is different from the one which was
> supplied with the release tarball?

I tested on 24.3 and 24.2 and it does recenter. I am sure this feature
worked at some point but can't recall when. I can try further previous
versions if you wish.

When I type RET at the prompt I get an error message saying I can't send
an empty line. It errors "Blank line - ignoring" in the echo area.
However the display does not scroll up for me.
-- 
Things unattempted yet in prose or rhyme.
    -- John Milton

bug#16697: 24.3.50; ERC scrolltobottom module does not work anymore

[Eli Zaretskii]

> From: Ivan Kanis <ivan@kanis.fr>
> Cc: 16697@debbugs.gnu.org
> Date: Mon, 10 Feb 2014 22:12:19 +0100
> 
> > However, now that I tried your recipe, I see that Emacs 24.3 also
> > recenters, like the current trunk.  If I then type RET at the "ERC>"
> > prompt, the display is scrolled so that the last non-empty line is
> > indeed at the bottom of the window.
> >
> > I think this is expected, given that scrolltobottom works off the
> > post-command-hook, no?
> >
> > Are you sure that Emacs 24.3 behaves differently here?  Did you
> > perhaps use in Emacs 24.3 erc that is different from the one which was
> > supplied with the release tarball?
> 
> I tested on 24.3 and 24.2 and it does recenter. I am sure this feature
> worked at some point but can't recall when. I can try further previous
> versions if you wish.

I think it "worked" when scrolltobottom used window-scroll-functions,
see bug #11697.

> When I type RET at the prompt I get an error message saying I can't send
> an empty line. It errors "Blank line - ignoring" in the echo area.
> However the display does not scroll up for me.

No, I meant if the last line is not at the bottom of the window,
typing just RET will scroll it to the bottom, because the
post-command-hook will kick in.

So I guess this feature expects an improvement that would put the last
line at the bottom even if no command was invoked by the user.

bug#16697: 24.3.50; ERC scrolltobottom module does not work anymore

[Ivan Kanis]

Hi Eli,

I have set scroll-conservatively to 101. Unfortunately I see ERC buffer
still recenters for some reason.

February, 11 at 5:51 Eli wrote:

>> When I type RET at the prompt I get an error message saying I can't send
>> an empty line. It errors "Blank line - ignoring" in the echo area.
>> However the display does not scroll up for me.
>
> No, I meant if the last line is not at the bottom of the window,
> typing just RET will scroll it to the bottom, because the
> post-command-hook will kick in.
>
> So I guess this feature expects an improvement that would put the last
> line at the bottom even if no command was invoked by the user.

It does not do that for me. I just get the error, the ERC prompt stays
in the middle.

bug#16697: 24.3.50; ERC scrolltobottom module does not work anymore

[Eli Zaretskii]

> From: Ivan Kanis <ivan@kanis.fr>
> Cc: 16697@debbugs.gnu.org
> Date: Tue, 11 Feb 2014 10:18:32 +0100
> 
> I have set scroll-conservatively to 101. Unfortunately I see ERC buffer
> still recenters for some reason.

From "emacs -Q"?  If so, please show a complete recipe, because I
cannot reproduce this.  (Of course, you can only have the last line at
the bottom of the window once you have enough stuff in the buffer to
fill the window, but I assume you have accounted for that.)

> February, 11 at 5:51 Eli wrote:
> 
> >> When I type RET at the prompt I get an error message saying I can't send
> >> an empty line. It errors "Blank line - ignoring" in the echo area.
> >> However the display does not scroll up for me.
> >
> > No, I meant if the last line is not at the bottom of the window,
> > typing just RET will scroll it to the bottom, because the
> > post-command-hook will kick in.
> >
> > So I guess this feature expects an improvement that would put the last
> > line at the bottom even if no command was invoked by the user.
> 
> It does not do that for me. I just get the error, the ERC prompt stays
> in the middle.

Again, is that in "emacs -Q"?  If not, please try "emacs -Q".  Here's
what I did:

  emacs -Q
  M-: (setq erc-modules '(scrolltobottom)) RET
  M-x erc RET RET RET RET RET

Then I wait for enough stuff to arrive that Emacs recenters, and hit
RET one more time.  At this point, the last line is scrolled to the
bottom of the window.

bug#16697: 24.3.50; ERC scrolltobottom module does not work anymore

[Ivan Kanis]

February, 11 at 18:37 Eli wrote:

>> From: Ivan Kanis <ivan@kanis.fr>
>> Cc: 16697@debbugs.gnu.org
>> Date: Tue, 11 Feb 2014 10:18:32 +0100
>> 
>> I have set scroll-conservatively to 101. Unfortunately I see ERC buffer
>> still recenters for some reason.
>
>>From "emacs -Q"?

No it wasn't. It was going back and forth between other buffers and the
ERC buffer.

> If so, please show a complete recipe, because I
> cannot reproduce this.  (Of course, you can only have the last line at
> the bottom of the window once you have enough stuff in the buffer to
> fill the window, but I assume you have accounted for that.)

Of course I account for enough line :)

>> February, 11 at 5:51 Eli wrote:
>> 
>> >> When I type RET at the prompt I get an error message saying I can't send
>> >> an empty line. It errors "Blank line - ignoring" in the echo area.
>> >> However the display does not scroll up for me.
>> >
>> > No, I meant if the last line is not at the bottom of the window,
>> > typing just RET will scroll it to the bottom, because the
>> > post-command-hook will kick in.
>> >
>> > So I guess this feature expects an improvement that would put the last
>> > line at the bottom even if no command was invoked by the user.
>> 
>> It does not do that for me. I just get the error, the ERC prompt stays
>> in the middle.
>
> Again, is that in "emacs -Q"?  If not, please try "emacs -Q".  Here's
> what I did:
>
>   emacs -Q
>   M-: (setq erc-modules '(scrolltobottom)) RET
>   M-x erc RET RET RET RET RET
>
> Then I wait for enough stuff to arrive that Emacs recenters, and hit
> RET one more time.  At this point, the last line is scrolled to the
> bottom of the window.

I see it now. It worked without hitting RET before which would be ideal.

Ivan
-- 
A little detective work revealed that, as is usually the case when you
encounter something shoddy in the vicinity of a computer, Microsoft
incompetence and gratuitous incompatibility were to blame.
    -- John Walker 

bug#16697: 24.3.50; ERC scrolltobottom module does not work anymore

[Josh]

On Tue, Feb 11, 2014 at 9:14 AM, Ivan Kanis <ivan@kanis.fr> wrote:
> February, 11 at 18:37 Eli wrote:
>> Then I wait for enough stuff to arrive that Emacs recenters, and hit
>> RET one more time.  At this point, the last line is scrolled to the
>> bottom of the window.
>
> I see it now. It worked without hitting RET before which would be ideal.

This was previously discussed at [0], including a reference[1] to the
commit that changed the behavior.

[0] http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-06/msg00353.html
[1] http://git.savannah.gnu.org/cgit/emacs.git/commit/lisp/erc/erc-goodies.el?id=a1d63e03c3eda51dcec158d6027adf9dbdcfd8dd

bug#16697: 24.3.50; ERC scrolltobottom module does not work anymore

[Glenn Morris]

Josh wrote:

> This was previously discussed at [0],

Ie, http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11697

which was closed by the opener of this current bug report,
after he disconnected it from

http://debbugs.gnu.org/cgi/bugreport.cgi?bug=14573

which is an identical duplicate of this current report.

It's not clear to me what the logic is here.

bug#16697: 24.3.50; ERC scrolltobottom module does not work anymore

[Ivan Kanis]

February, 11 at 16:56 Glenn wrote:

> Josh wrote:
>
>> This was previously discussed at [0],
>
> Ie, http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11697
>
> which was closed by the opener of this current bug report,
> after he disconnected it from
>
> http://debbugs.gnu.org/cgi/bugreport.cgi?bug=14573
>
> which is an identical duplicate of this current report.
>
> It's not clear to me what the logic is here.

Nor to me. I didn't get e-mail for #11697 because the author was not me.
I stated that #14573 was not a duplicate of #11967 for reasons I don't
remember. I closed #11697 but I can't recall why.

I apologize for being a flake and wasting people's time.

Ivan
-- 
Browser's cookie is corrupted. Someone's been nibbling on it.
    -- BOFH excuse #4

bug#16697: 24.3.50; ERC scrolltobottom module does not work anymore

[Lars Ingebrigtsen]

It's unclear what the conclusion of these bug reports were.  Was this
fixed or does the problem remain?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#11697: bug#16697: 24.3.50; ERC scrolltobottom module does not work anymore

[Ivan Kanis]

Hi Lars,

The problem remains.

December, 27 at 22:24 Lars wrote:

> It's unclear what the conclusion of these bug reports were.  Was this
> fixed or does the problem remain?

-- 
At Group L, Stoffel oversees six first-rate programmers, a
managerial challenge roughly comparable to herding cats.
    -- Anonymous , 1985-06-09 , The Washington Post

bug#11697: bug#16697: 24.3.50; ERC scrolltobottom module does not work anymore

[Ivan Kanis]

December, 27 at 22:24 Lars wrote:

> It's unclear what the conclusion of these bug reports were.  Was this
> fixed or does the problem remain?

I forgot to mention I am running on a recent master:

7e9da9f [8 weeks ago] ; Shorten TODO list in file-notify-tests.el
[Michael Albinus]

-- 
In this world nothing can be said to be certain,
except death and taxes.
    -- Benjamin Franklin

bug#11697: bug#16697: 24.3.50; ERC scrolltobottom module does not work anymore

[Lars Ingebrigtsen]

Ivan Kanis <ivan@kanis.fr> writes:

> Hi Lars,
>
> The problem remains.

Ok, I've done some further reading of the many threads and references
here, and I'm still not quite sure what the bug is.  :-)

Do you have a recipe starting from emacs -Q that demonstrates what
happens, and could you describe what you wanted to have happen instead?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#16697: 24.3.50; ERC scrolltobottom module does not work anymore

[Ivan Kanis]

[-- Attachment #1: Type: text/plain, Size: 874 bytes --]

February, 04 at 17:12 Lars wrote:

> Ivan Kanis <ivan@kanis.fr> writes:
>
>> Hi Lars,
>>
>> The problem remains.
>
> Ok, I've done some further reading of the many threads and references
> here, and I'm still not quite sure what the bug is.  :-)
>
> Do you have a recipe starting from emacs -Q that demonstrates what
> happens, and could you describe what you wanted to have happen instead?

Hi Lars,

It's very easy to reproduce.

I am running a month old master (git 384cf23).

emacs -Q

1) evaluate (setq erc-modules '(scrolltobottom))
2) M-x erc
3) select default values
4) /j #emacs
5) wait for the buffer to fill up

I expect the prompt line to stay at the bottom.

It jumps back to the middle.

I have attached a picture. See the ERC> prompt with the blue background?
It jumped back to the middle.

I wish you a very productive month of hacking ;)

Take care,

Ivan


[-- Attachment #2: 2016-02-04-214423_755x725_scrot.png --]
[-- Type: image/png, Size: 91398 bytes --]

bug#11697: bug#16697: 24.3.50; ERC scrolltobottom module does not work anymore

[Lars Ingebrigtsen]

Ivan Kanis <ivan@kanis.fr> writes:

> emacs -Q
>
> 1) evaluate (setq erc-modules '(scrolltobottom))
> 2) M-x erc
> 3) select default values
> 4) /j #emacs
> 5) wait for the buffer to fill up
>
> I expect the prompt line to stay at the bottom.
>
> It jumps back to the middle.

This was a bit convoluted to fix, as none of the hooks erc had could be
used, as they're called while saving too many excursions.  (Well, I
could have rewritten the erc-scroll-to-bottom function to not use
`recenter' at all, which may have been a better idea, come to think of
it.)

But I fixed it a different way, so that now point is kept at the end of
the buffer (if the window is selected).

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no