unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@jurta.org>
To: Glenn Morris <rgm@gnu.org>
Cc: Alan Mackenzie <acm@muc.de>, 17351@debbugs.gnu.org
Subject: bug#17351: Trunk emacs splats .emacs.desktop at startup
Date: Tue, 24 Jun 2014 01:57:52 +0300	[thread overview]
Message-ID: <874mzbz11m.fsf@mail.jurta.org> (raw)
In-Reply-To: <0rionsjxr3.fsf@fencepost.gnu.org> (Glenn Morris's message of "Sun, 22 Jun 2014 20:05:52 -0400")

>> This would keep the desktop file open all the time,
>> and users might not like to see it in the buffer list.
>
> So read it into an invisible buffer, set buffer-file-name, and enable
> auto-save-mode.

auto-save-mode doesn't seem necessary because the contents of the
desktop file buffer has to be generated at the given time interval
anyway, so at the end it can be saved as well like in this patch:

=== modified file 'lisp/desktop.el'
--- lisp/desktop.el	2014-06-06 23:38:40 +0000
+++ lisp/desktop.el	2014-06-23 22:45:20 +0000
@@ -1038,8 +1038,15 @@ (defun desktop-save (dirname &optional r
 			     (point))))
 		 (checksum (and beg (md5 (current-buffer) beg (point-max) 'emacs-mule))))
 	    (unless (and checksum (equal checksum desktop-file-checksum))
-	      (let ((coding-system-for-write 'emacs-mule))
-		(write-region (point-min) (point-max) (desktop-full-file-name) nil 'nomessage))
+	      (let ((coding-system-for-write 'emacs-mule)
+		    (buffer-string (buffer-string)))
+		(with-current-buffer (find-file-noselect (desktop-full-file-name))
+		  ;; Make the buffer invisible
+		  (unless (eq (aref (buffer-name) 0) ?\s)
+		    (rename-buffer (concat " " (buffer-name))))
+		  (erase-buffer)
+		  (insert buffer-string)
+		  (save-buffer)))
 	      (setq desktop-file-checksum checksum)
 	      ;; We remember when it was modified (which is presumably just now).
 	      (setq desktop-file-modtime (nth 5 (file-attributes (desktop-full-file-name)))))))))))






  reply	other threads:[~2014-06-23 22:57 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-26 18:04 bug#17351: Trunk emacs splats .emacs.desktop at startup Alan Mackenzie
2014-04-27  8:22 ` Juri Linkov
2014-04-27  9:15   ` Alan Mackenzie
2014-04-27  9:52     ` Juri Linkov
2014-04-27 14:31       ` Stefan Monnier
2014-04-27 22:13         ` Stefan Monnier
2014-06-22  7:05           ` Glenn Morris
2014-06-22 23:01             ` Juri Linkov
2014-06-23  0:05               ` Glenn Morris
2014-06-23 22:57                 ` Juri Linkov [this message]
2014-06-24 18:30                   ` Glenn Morris
2014-06-24 23:23                     ` Juri Linkov
2014-06-26 19:31                       ` Glenn Morris
2014-06-26 23:44                         ` Juri Linkov
2014-08-11  1:18                           ` Glenn Morris
2014-08-12  6:52                             ` Juri Linkov
2014-07-02 23:52                       ` Juri Linkov
2014-07-03  2:42                         ` Glenn Morris
2014-07-03 23:35                           ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874mzbz11m.fsf@mail.jurta.org \
    --to=juri@jurta.org \
    --cc=17351@debbugs.gnu.org \
    --cc=acm@muc.de \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).