bug#17859: tramp-test31-utf8 aborts

bug#17859: tramp-test31-utf8 aborts

[Glenn Morris]

Package: emacs
Version: 24.4.50

Current trunk on x86_64 RHEL 6.5. tramp-test31-utf8 aborts (in that ert
aborts the test, not that it makes Emacs abort):

A tramp-test31-utf8
    Check UTF8 encoding in file names and file contents.
    aborted

I'm not sure how to get useful information out of it.
`b' doesn't show a proper backtrace. I get:

cond: Wrong method specification for `mock'
ert-results-pop-to-backtrace-for-test-at-point: cl-etypecase failed:
[cl-struct-ert-test-aborted-with-non-local-exit  (((skip-unless
(tramp--test-enabled)) :form (tramp--test-enabled) :value t) ((should
(file-exists-p file1)) :form (file-exists-p
/mock:host.name.removed:/tmp/tramp-test15919jlp/<arabic text>) :value
t))], (ert-test-passed ert-test-result-with-condition)

bug#17859: tramp-test31-utf8 aborts

[Michael Albinus]

Glenn Morris <rgm@gnu.org> writes:

> Package: emacs
> Version: 24.4.50
>
> Current trunk on x86_64 RHEL 6.5. tramp-test31-utf8 aborts (in that ert
> aborts the test, not that it makes Emacs abort):
>
> A tramp-test31-utf8
>     Check UTF8 encoding in file names and file contents.
>     aborted
>
> I'm not sure how to get useful information out of it.

Please instrument the test case. It will be verbose then:

--8<---------------cut here---------------start------------->8---
*** /home/albinus/src/emacs/test/automated/tramp-tests.el.~117420~	2014-06-27 11:06:25.011224723 +0200
--- /home/albinus/src/emacs/test/automated/tramp-tests.el	2014-06-27 11:04:39.554701793 +0200
***************
*** 1481,1486 ****
--- 1481,1487 ----
  
  (defun tramp--test-check-files (&rest files)
    "Runs a simple but comprehensive test over every file in FILES."
+   (tramp--instrument-test-case 10
    (let ((tmp-name1 (tramp--test-make-temp-name))
  	(tmp-name2 (tramp--test-make-temp-name 'local)))
      (unwind-protect
***************
*** 1532,1538 ****
  			  tmp-name2 nil directory-files-no-dot-files-regexp))))
  
        (ignore-errors (delete-directory tmp-name1 'recursive))
!       (ignore-errors (delete-directory tmp-name2 'recursive)))))
  
  ;; This test is inspired by Bug#17238.
  (ert-deftest tramp-test30-special-characters ()
--- 1533,1539 ----
  			  tmp-name2 nil directory-files-no-dot-files-regexp))))
  
        (ignore-errors (delete-directory tmp-name1 'recursive))
!       (ignore-errors (delete-directory tmp-name2 'recursive))))))
  
  ;; This test is inspired by Bug#17238.
  (ert-deftest tramp-test30-special-characters ()
--8<---------------cut here---------------end--------------->8---

Best regards, Michael.

bug#17859: tramp-test31-utf8 aborts

[Glenn Morris]

[-- Attachment #1: Type: text/plain, Size: 100 bytes --]

Michael Albinus wrote:

> Please instrument the test case. It will be verbose then:

See attached.


[-- Attachment #2: tramp-tests.log.xz --]
[-- Type: application/octet-stream, Size: 3016 bytes --]

bug#17859: tramp-test31-utf8 aborts

[Michael Albinus]

Glenn Morris <rgm@gnu.org> writes:

> Michael Albinus wrote:
>
>> Please instrument the test case. It will be verbose then:
>
> See attached.

Well, the traces don't tell too much. When Tramp tries to encode the
file with arabic letters, it doesn't find a proper encoding method. But
it did before, running the other tests.

I've changed `tramp--instrument-test-case' to dump more traces. Please
rerun, keeping the instrumentation as proposed last message.

Best regards, Michael.

bug#17859: tramp-test31-utf8 aborts

[Glenn Morris]

Please download test log from
http://debbugs.gnu.org/cgi/bugreport.cgi?bug=17859#13

bug#17859: tramp-test31-utf8 aborts

[Michael Albinus]

Glenn Morris <rgm@gnu.org> writes:

> Please download test log from
> http://debbugs.gnu.org/cgi/bugreport.cgi?bug=17859#13

Thanks. It looks like there is a process coding-system issue. At least
this is the only difference I have seen, comparing the traces from your
test run, and mine.

I have committed a patch to the trunk. Pls check.

Best regards, Michael.

bug#17859: tramp-test31-utf8 aborts

[Glenn Morris]

Michael Albinus wrote:

> I have committed a patch to the trunk. Pls check.

That seems to do it. Thanks!

bug#17859: tramp-test31-utf8 aborts

[Michael Albinus]

Version: 24.5

Glenn Morris <rgm@gnu.org> writes:

>> I have committed a patch to the trunk. Pls check.
>
> That seems to do it. Thanks!

Thanks for confirmatiuon. I'm closing the bug.

Best regards, Michael.