From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ivan Shmakov Newsgroups: gmane.emacs.bugs Subject: bug#18954: 24.4; vc-log Summary: header is included in the log message Date: Wed, 05 Nov 2014 17:24:04 +0000 Message-ID: <874mud7e8b.fsf@violet.siamics.net> References: <7E039918541B4C4183BFDB8F015C7430813FAC@WCL-EXCH02.wcl.local> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1415208323 17087 80.91.229.3 (5 Nov 2014 17:25:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 5 Nov 2014 17:25:23 +0000 (UTC) To: 18954@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Nov 05 18:25:18 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Xm4Kb-0004U8-QG for geb-bug-gnu-emacs@m.gmane.org; Wed, 05 Nov 2014 18:25:17 +0100 Original-Received: from localhost ([::1]:47789 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xm4Kb-0003Pr-BI for geb-bug-gnu-emacs@m.gmane.org; Wed, 05 Nov 2014 12:25:17 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57870) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xm4KS-0003Ng-BM for bug-gnu-emacs@gnu.org; Wed, 05 Nov 2014 12:25:14 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xm4KO-00076d-8Z for bug-gnu-emacs@gnu.org; Wed, 05 Nov 2014 12:25:08 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53105) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xm4KN-00076M-Rb for bug-gnu-emacs@gnu.org; Wed, 05 Nov 2014 12:25:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Xm4KM-0004Ak-Ee for bug-gnu-emacs@gnu.org; Wed, 05 Nov 2014 12:25:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ivan Shmakov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Nov 2014 17:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18954 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18954-submit@debbugs.gnu.org id=B18954.141520825715979 (code B ref 18954); Wed, 05 Nov 2014 17:25:02 +0000 Original-Received: (at 18954) by debbugs.gnu.org; 5 Nov 2014 17:24:17 +0000 Original-Received: from localhost ([127.0.0.1]:50318 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xm4Jc-00049d-MC for submit@debbugs.gnu.org; Wed, 05 Nov 2014 12:24:17 -0500 Original-Received: from fely.am-1.org ([78.47.74.50]:39197) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xm4Ja-00049T-9e for 18954@debbugs.gnu.org; Wed, 05 Nov 2014 12:24:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=9sPuj8RNR46bLQS+QTgx6mJAiP5WsKfGVvC+u9bNlF4=; b=nhXyo8dFjev23sl7O9AqKgKQ5uzRU/OEGAKMn3lFcko/QLhKsGNnKG0svqP6ZtFLmH1OnO1JOJrJjmIwLhwwXZwzh2bwRLsrUHCoQDHGw6DKPzdeKN/v56Rb8X20m/p3dWf1Y20AuUWc9TRr9UFpr7jekrvGZXna/7CQdzfF08s=; Original-Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1Xm4JY-0001iR-D5 for 18954@debbugs.gnu.org; Wed, 05 Nov 2014 17:24:13 +0000 Original-Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1Xm4JR-00052I-57 for 18954@debbugs.gnu.org; Thu, 06 Nov 2014 00:24:05 +0700 In-Reply-To: <7E039918541B4C4183BFDB8F015C7430813FAC@WCL-EXCH02.wcl.local> (Ed Avis's message of "Wed, 5 Nov 2014 14:45:54 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:95556 >>>>> Ed Avis writes: > I use vc-mode to edit and commit files in an svn repository. On > running vc-next-action on a modified file, a log message buffer > appears containing the text Summary: and a blank line. Typing in > this buffer adds more text after Summary:. On committing with C-c > C-c, the literal text Summary: is included as part of the svn log > message, as you can see afterwards by running 'svn log'. > Please see where > forum user Stefan indicated that this was a bug (presumably, the > Summary: header should be stripped out when sending the text to svn) > and asked to report it. This pseudo-header (along with an optional Author:) is added by the log-edit-insert-message-template command, itself called from log-edit-hook. Thus, as a work-around (which I happen to use myself), it=E2=80=99s possible to simply remove the function from the hook, like: (eval-after-load 'log-edit '(remove-hook 'log-edit-hook 'log-edit-insert-message-template)) A quick scan through vc/*.el suggest that the Summary: header is only recognized by vc-arch.el (which, however, doesn=E2=80=99t seem to take care of Author:), while only vc-git.el seems to recognize Author: (and doesn=E2=80=99t seem to care about Summary: in turn.) If so, this bug actually affects most of the VCS supported by the Emacs VC facility, and not just Subversion. I believe this behavior is highly inconsistent, and would rather suggest either of the following options. =E2=80=A2 Amend the log-edit-insert-message-template function to only generate the template if /either/ explicitly requested by the user (as in: via a yes-maybe-no variable setting, or by running it interactively) /or/ when the headers in question are known to be recognized by the target VCS. =E2=80=A2 Remove the function from the hook=E2=80=99s default value. Also to note that log-edit-insert-cvs-rcstemplate apparently relies on the existence of CVS/Root to decide if its respective template should be added. My guess is that it should instead check the VCS chosen by the user (as in: vc-switch-backend) for the fileset in question. --=20 FSF associate member #7257 http://boycottsystemd.org/ =E2=80=A6 3013 B6A0= 230E 334A