From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#19619: 25.0.50; Fullheight frames in daemonized emacsen are wrong width Date: Mon, 09 Feb 2015 13:26:58 +0100 Message-ID: <874mqv1d9p.fsf@gmx.net> References: <54B9508D.8040609@gmx.at> <54D666D9.2020409@gmx.at> <87r3u1hrs2.fsf@md5i.com> <87h9uww3iu.fsf@gmx.net> <54D87E67.7050902@gmx.at> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1423484904 2836 80.91.229.3 (9 Feb 2015 12:28:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 9 Feb 2015 12:28:24 +0000 (UTC) Cc: Michael Welsh Duggan , 19619@debbugs.gnu.org To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Feb 09 13:28:23 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YKnRs-0000FN-N1 for geb-bug-gnu-emacs@m.gmane.org; Mon, 09 Feb 2015 13:28:20 +0100 Original-Received: from localhost ([::1]:60574 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YKnRs-0008R6-1T for geb-bug-gnu-emacs@m.gmane.org; Mon, 09 Feb 2015 07:28:20 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41499) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YKnRf-0008D5-W1 for bug-gnu-emacs@gnu.org; Mon, 09 Feb 2015 07:28:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YKnRa-0006e0-6k for bug-gnu-emacs@gnu.org; Mon, 09 Feb 2015 07:28:07 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:46700) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YKnRa-0006dq-4S for bug-gnu-emacs@gnu.org; Mon, 09 Feb 2015 07:28:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YKnRZ-00047h-IR for bug-gnu-emacs@gnu.org; Mon, 09 Feb 2015 07:28:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 09 Feb 2015 12:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19619 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19619-submit@debbugs.gnu.org id=B19619.142348483615794 (code B ref 19619); Mon, 09 Feb 2015 12:28:01 +0000 Original-Received: (at 19619) by debbugs.gnu.org; 9 Feb 2015 12:27:16 +0000 Original-Received: from localhost ([127.0.0.1]:37940 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YKnQp-00046g-Lb for submit@debbugs.gnu.org; Mon, 09 Feb 2015 07:27:16 -0500 Original-Received: from mout.gmx.net ([212.227.15.18]:49593) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YKnQn-00046S-Qr for 19619@debbugs.gnu.org; Mon, 09 Feb 2015 07:27:14 -0500 Original-Received: from rosalinde ([89.245.102.9]) by mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0MCLcP-1YTpqs240X-0097QX; Mon, 09 Feb 2015 13:26:59 +0100 In-Reply-To: <54D87E67.7050902@gmx.at> (martin rudalics's message of "Mon, 09 Feb 2015 10:31:19 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-Provags-ID: V03:K0:yFxwzpqBarhEvVgoFCoC2Lfxxu3mp4GTUeJS8l7eKrkj6TUPbWY AOu8bm3BqIijJKA1p82kTHOj6cJztQrpp2tZdh/JTneCowsU8dS4RnsvrlMtwYZUxu5JBa1 Wu3nlfKoJfr13f+PXkUWkKdIbQO1xJHj7AReX16az7sFio5YrulMxayfQywmOWQI9HOOkKk dxE5eiEd/j8sXHyQ6EOvA== X-UI-Out-Filterresults: notjunk:1; X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:99201 Archived-At: On Mon, 09 Feb 2015 10:31:19 +0100 martin rudalics wrote: >> The bug was that the combination of (i) adding the frame >> parameter (fullscreen . fullheight), > > ... adding to `default-frame-alist', `initial-frame-alist'? I used modify-frame-parameters. >> (ii) customizing tool-bar-style to >> 'left > > `tool-bar-style' or the `tool-bar-position' parameter? The latter, sorry for the confusion. >> and (iii) calling tool-bar-add-item or tool-bar-add-item-from-menu >> resulted in lines longer than window-width wrapping one column too >> soon. Again, with current master, this bug is no longer reproducible. >> So thanks for the prescience (even if unintended)! > > Sheer luck, probably. Does the problem already happen with Emacs 24.5? It does not happen with my latest build from the emacs-24 branch. (That does not use a toolkit scroll bar, unlike my builds from master, though I guess that isn't relevant here.) > And what happens with a fullwidth frame and the toolbar orthogonally to > where it is now? Do you mean using the parameter (fullscreen . fullboth) and tool bar on the left? If so, the result is the same in master with and without you recent patch: there's a bit of space between the last character and the right fringe, but less than one column's worth. Although, with your patch, I no longer observe the problem, in case you want to do some ex post facto forensics, below is the minimal recipe I came up with to show the problem. Do emacs -Q in a build from master without your patch, evaluate the code and then type `M-x srb-test'. Steve Berman (defun srb-test () "Test display of rightmost column." (interactive) (let ((buf (generate-new-buffer "*srb test*"))) (with-current-buffer buf (insert "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.") (srb-test-mode)) (switch-to-buffer buf))) (defvar srb-test-toolbar (let ((tool-bar-map (make-sparse-keymap))) (tool-bar-add-item nil nil nil) tool-bar-map)) (defvar srb-test-mode-map (let ((map (make-sparse-keymap))) (define-key map [menu-bar] (make-sparse-keymap)) map) "Keymap for `srb-test-mode'.") (define-derived-mode srb-test-mode nil "srb test" "Mode to test display of rightmost column." (modify-frame-parameters nil '((fullscreen . fullheight))) (custom-set-variables '(tool-bar-position (quote left))) (setq-local tool-bar-map srb-test-toolbar))