From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#20943: 25.0.50; Dired buffers are not always auto-reverted Date: Thu, 09 Jul 2015 20:41:50 +0200 Message-ID: <874mld18cx.fsf@gmx.de> References: <87y4j1oy87.fsf@openmailbox.org> <87pp41cvl1.fsf@openmailbox.org> <83615tv14o.fsf@gnu.org> <874mldtkl9.fsf@openmailbox.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1436467345 2491 80.91.229.3 (9 Jul 2015 18:42:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 9 Jul 2015 18:42:25 +0000 (UTC) Cc: 20943@debbugs.gnu.org To: Mark Karpov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jul 09 20:42:12 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZDGlu-0000kY-Qc for geb-bug-gnu-emacs@m.gmane.org; Thu, 09 Jul 2015 20:42:10 +0200 Original-Received: from localhost ([::1]:41306 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZDGlu-0005e9-7v for geb-bug-gnu-emacs@m.gmane.org; Thu, 09 Jul 2015 14:42:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57701) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZDGlq-0005bk-GL for bug-gnu-emacs@gnu.org; Thu, 09 Jul 2015 14:42:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZDGln-0001AL-7h for bug-gnu-emacs@gnu.org; Thu, 09 Jul 2015 14:42:06 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:44024) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZDGln-0001AF-4R for bug-gnu-emacs@gnu.org; Thu, 09 Jul 2015 14:42:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZDGlm-0001v7-F0 for bug-gnu-emacs@gnu.org; Thu, 09 Jul 2015 14:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 Jul 2015 18:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20943 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20943-submit@debbugs.gnu.org id=B20943.14364673217375 (code B ref 20943); Thu, 09 Jul 2015 18:42:02 +0000 Original-Received: (at 20943) by debbugs.gnu.org; 9 Jul 2015 18:42:01 +0000 Original-Received: from localhost ([127.0.0.1]:45470 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZDGll-0001us-Eq for submit@debbugs.gnu.org; Thu, 09 Jul 2015 14:42:01 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:56481) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZDGlj-0001ub-9U for 20943@debbugs.gnu.org; Thu, 09 Jul 2015 14:41:59 -0400 Original-Received: from detlef.gmx.de ([87.146.52.158]) by mail.gmx.com (mrgmx103) with ESMTPSA (Nemesis) id 0LfTC1-1YgTFG2u7t-00p3nw; Thu, 09 Jul 2015 20:41:51 +0200 In-Reply-To: <874mldtkl9.fsf@openmailbox.org> (Mark Karpov's message of "Thu, 09 Jul 2015 21:30:10 +0600") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-Provags-ID: V03:K0:FNfIDP3b0TAslxRDRJxuatPVWrA9HS+RX3VkASliy8SeRowYY7a kh7Ao744kMZpntL7OilEn3E/RHKTb8PWSlvolaFfQ1ti4GYnhs2gb+tITtqLS9HDW4K1QME bfb2JOv75Fwu3HZVkkXSZHSgc3kiBc/VmbZD7VjTu3uuM7/AzEjKrRvbFz43dZJYJqFFZrB agRVMMeg0TCtDTcdq1TsQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:Zy7659N50es=:Y+x5FJg1LQ3mdM4SQqy5YZ idisfOMv8RwkHSbxc7H8eTGNXHzGZ+jO6SnkZWRB2kVYoakiZ/KsobITjCbDtEdcfd2kG66qS zveWQInW8G7idYi6W7xVxPHtyyNwxOTDEXY1ffoPzRecCCKM4e11kZv8i4cASdcHKA7sRx+dE TcFcLyXhuRC2beJwb/Fa9pDFj+YCimbI2Rtr/AzMC411UnuXhJLf3PnyajwHREMVpFQuUyA4d wT1LJk9Tz7Sozm3wL94/SHUEJdQNYZg3JYJGXB5ymraI4BtJAWtwfMHtnkBbr6rnCx6plZ7sV MllgWDjNR/XayJ4wc2sxreRlTlAM5mKiNvwt1wOVTvcAQYTsUFdCNW3fwaH+6Qe4lkAXG7fMq RHiKu++deHC9+qwzDpQuQlJGYHA2nMhYDh345u5UHf7Iju947qvuhomZFAhzJP/dLd5g8+g8q fxO4BO3wvl2QYx82yKr8EIyp6Fyb9Szc8gCgksgllLLSb2dRhwLjsQxjksfrSt8IG7Z0RpOHb biZm9D7n2iTMBY/JW+HQGVg23RZRgb4WRuTO+n74K+kYlm/lO/5enLS5QEIzXZoK3hx4V5A8j sPYCgwMshdHbyssDZX9iYTmAnZsoqrTNLFMIHV7EgYO1iRVROCHBVz9FlKjDdEIzL9Dmju9AQ bBzHBhesHTCriOlHxd0y8Jl6OAY8mK2NASiFaj7PLKmPyRKLY0pMe/+5luIjevFNxjrE= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:104860 Archived-At: Mark Karpov writes: > 1. In =E2=80=98auto-revert-handler=E2=80=99, autorevert modified files if= current buffer > is a Dired buffer: > > (defun auto-revert-handler () > "Revert current buffer, if appropriate. > This is an internal function used by Auto-Revert Mode." > (when (or auto-revert-tail-mode > (eq major-mode dired-mode) > (not (buffer-modified-p))) > ...)) I fear this is the wrong direction to fix it. `auto-revert-handler' shall not know about major modes. All what a buffer has to say to `auto-revert-handler' must be in `buffer-stale-function', which is set to `dired-buffer-stale-p' here. What happens, if you remove the test for `buffer-read-only' from that function? Best regards, Michael.