From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#20541: ERC password fetching using Secret Service API is broken Date: Sun, 27 Dec 2015 09:05:02 +0100 Message-ID: <874mf4iafl.fsf@gnus.org> References: <87d228lduj.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1451203582 30703 80.91.229.3 (27 Dec 2015 08:06:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 27 Dec 2015 08:06:22 +0000 (UTC) Cc: 20541@debbugs.gnu.org To: Krzysztof Jurewicz Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Dec 27 09:06:10 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aD6LB-0001hH-QY for geb-bug-gnu-emacs@m.gmane.org; Sun, 27 Dec 2015 09:06:09 +0100 Original-Received: from localhost ([::1]:41003 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aD6LB-0002am-1q for geb-bug-gnu-emacs@m.gmane.org; Sun, 27 Dec 2015 03:06:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40569) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aD6L6-0002ZX-Vg for bug-gnu-emacs@gnu.org; Sun, 27 Dec 2015 03:06:05 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aD6L3-0002GR-P6 for bug-gnu-emacs@gnu.org; Sun, 27 Dec 2015 03:06:04 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34790) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aD6L3-0002GN-Lx for bug-gnu-emacs@gnu.org; Sun, 27 Dec 2015 03:06:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aD6L3-0005Jd-HQ for bug-gnu-emacs@gnu.org; Sun, 27 Dec 2015 03:06:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 27 Dec 2015 08:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20541 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20541-submit@debbugs.gnu.org id=B20541.145120352720373 (code B ref 20541); Sun, 27 Dec 2015 08:06:01 +0000 Original-Received: (at 20541) by debbugs.gnu.org; 27 Dec 2015 08:05:27 +0000 Original-Received: from localhost ([127.0.0.1]:42389 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aD6KV-0005IX-Lp for submit@debbugs.gnu.org; Sun, 27 Dec 2015 03:05:27 -0500 Original-Received: from hermes.netfonds.no ([80.91.224.195]:45800) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aD6KT-0005IO-Jj for 20541@debbugs.gnu.org; Sun, 27 Dec 2015 03:05:27 -0500 Original-Received: from 2.150.58.24.tmi.telenormobil.no ([2.150.58.24] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aD6K7-0003lv-6M; Sun, 27 Dec 2015 09:05:03 +0100 In-Reply-To: <87d228lduj.fsf@gmail.com> (Krzysztof Jurewicz's message of "Sun, 10 May 2015 16:13:56 +0200") User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.1.50 (gnu/linux) X-MailScanner-ID: 1aD6K7-0003lv-6M MailScanner-NULL-Check: 1451808303.76985@dx4wtOiR3Qs9YBbB2VHtlw X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:110775 Archived-At: Krzysztof Jurewicz writes: > lisp/erc/erc.el | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el > index cf422f1..a8f1478 100644 > --- a/lisp/erc/erc.el > +++ b/lisp/erc/erc.el > @@ -2010,7 +2010,8 @@ Returns the buffer for the given server or channel." > (auth-source-search :host server > :max 1 > :user nick > - :port port > + ;; secrets.el wouldn.t accept a number > + :port (if (numberp port) (number-to-string port) port) > :require '(:secret))) > :secret))) Thanks; applied to Emacs 25.1. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no