unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Krzysztof Jurewicz <krzysztof.jurewicz@gmail.com>
Cc: 20541@debbugs.gnu.org
Subject: bug#20541: ERC password fetching using Secret Service API is broken
Date: Sun, 27 Dec 2015 09:05:02 +0100	[thread overview]
Message-ID: <874mf4iafl.fsf@gnus.org> (raw)
In-Reply-To: <87d228lduj.fsf@gmail.com> (Krzysztof Jurewicz's message of "Sun,  10 May 2015 16:13:56 +0200")

Krzysztof Jurewicz <krzysztof.jurewicz@gmail.com> writes:

>  lisp/erc/erc.el | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el
> index cf422f1..a8f1478 100644
> --- a/lisp/erc/erc.el
> +++ b/lisp/erc/erc.el
> @@ -2010,7 +2010,8 @@ Returns the buffer for the given server or channel."
>                             (auth-source-search :host server
>                                                 :max 1
>                                                 :user nick
> -                                               :port port
> +                                               ;; secrets.el wouldn.t accept a number
> +                                               :port (if (numberp port) (number-to-string port) port)
>                                                 :require '(:secret)))
>                        :secret)))

Thanks; applied to Emacs 25.1.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





      parent reply	other threads:[~2015-12-27  8:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-10 14:13 bug#20541: ERC password fetching using Secret Service API is broken Krzysztof Jurewicz
2015-06-01  9:20 ` Michael Albinus
2015-06-30  2:28   ` Ted Zlatanov
2015-12-27  8:05 ` Lars Ingebrigtsen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874mf4iafl.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=20541@debbugs.gnu.org \
    --cc=krzysztof.jurewicz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).