From: Ari Roponen <ari.roponen@gmail.com>
To: Kaushal Modi <kaushal.modi@gmail.com>
Cc: 22332@debbugs.gnu.org
Subject: bug#22332: 25.0.50; woman moves point in a wrong buffer
Date: Thu, 04 Feb 2016 10:44:22 +0200 [thread overview]
Message-ID: <874mdoj255.fsf@gmail.com> (raw)
In-Reply-To: <CAFyQvY1bS+_hZOm8w-56rBS92AKC=8L8STuDamNwBvy5nBdObw@mail.gmail.com> (Kaushal Modi's message of "Thu, 04 Feb 2016 05:41:27 +0000")
Hi,
Kaushal Modi <kaushal.modi@gmail.com> writes:
> Can you please try this updated patch? This time, I hope to have it tested
> all the woman buffer switching activities.
>
Unfortunately, the patch doesn't apply, because of some line wrapping.
Recently, eww replaced display-buffer with pop-to-buffer-same-window
(commit 6191003fcd2bc65f2b18d5337f6f390d43f07173). Perhaps we could do
the same in the emacs-25 branch? Patch below.
diff --git a/lisp/woman.el b/lisp/woman.el
index 28a4798..a4a0da2 100644
--- a/lisp/woman.el
+++ b/lisp/woman.el
@@ -1654,7 +1654,7 @@ woman-really-find-file
(setq woman-frame (make-frame)))))
(set-buffer (get-buffer-create bufname))
(condition-case nil
- (display-buffer (current-buffer))
+ (pop-to-buffer-same-window (current-buffer))
(error (pop-to-buffer (current-buffer))))
(buffer-disable-undo)
(setq buffer-read-only nil)
@@ -2064,14 +2064,14 @@ WoMan-find-buffer
(if (zerop woman-buffer-number)
(let ((buffer (get-buffer (cdr (car woman-buffer-alist)))))
(if buffer
- (display-buffer buffer)
+ (pop-to-buffer-same-window buffer)
;; Delete alist element:
(setq woman-buffer-alist (cdr woman-buffer-alist))
nil))
(let* ((prev-ptr (nthcdr (1- woman-buffer-number) woman-buffer-alist))
(buffer (get-buffer (cdr (car (cdr prev-ptr))))))
(if buffer
- (display-buffer buffer)
+ (pop-to-buffer-same-window buffer)
;; Delete alist element:
(setcdr prev-ptr (cdr (cdr prev-ptr)))
(if (>= woman-buffer-number (length woman-buffer-alist))
--
Ari Roponen
next prev parent reply other threads:[~2016-02-04 8:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-08 18:24 bug#22332: 25.0.50; woman moves point in a wrong buffer Ari Roponen
2016-01-09 9:25 ` martin rudalics
2016-01-09 16:36 ` Kaushal Modi
2016-01-09 16:54 ` martin rudalics
2016-01-09 17:19 ` Kaushal Modi
2016-01-09 17:29 ` Ari Roponen
2016-01-09 17:42 ` martin rudalics
2016-01-09 22:32 ` Kaushal Modi
2016-01-10 10:53 ` martin rudalics
2016-02-04 5:41 ` Kaushal Modi
2016-02-04 7:55 ` martin rudalics
2016-02-04 8:44 ` Ari Roponen [this message]
2016-02-04 16:36 ` Kaushal Modi
2016-02-18 16:20 ` Kaushal Modi
2016-02-20 2:41 ` John Wiegley
2016-02-20 6:17 ` Lars Ingebrigtsen
2016-02-20 7:58 ` Lars Ingebrigtsen
2016-01-09 17:42 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874mdoj255.fsf@gmail.com \
--to=ari.roponen@gmail.com \
--cc=22332@debbugs.gnu.org \
--cc=kaushal.modi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).