From: Tassilo Horn <tsdh@gnu.org>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: 22736@debbugs.gnu.org
Subject: bug#22736: 25.0.91; file-notify calls wrong callbacks
Date: Fri, 19 Feb 2016 23:59:42 +0100 [thread overview]
Message-ID: <874md4z4pt.fsf@gnu.org> (raw)
In-Reply-To: <87d1rt5bpc.fsf@gmx.de> (Michael Albinus's message of "Fri, 19 Feb 2016 09:46:55 +0100")
Michael Albinus <michael.albinus@gmx.de> writes:
Hi Michael and Eli,
>>> The problem is that when there is a directory watch on some
>>> directory and a file watch on a file in that directory, the callback
>>> for the directory watch gets an event with the descriptor of the
>>> file watch.
>>
>> I think this is because when you ask to watch a file, we actually
>> watch its parent directory.
>
> Although we watch the parent directory internally (except with
> kqueue), the given scenario by Tassilo shall work as he expected.
> There shall be two file notification events in the given case, calling
> magit-filenotify--callback and auto-revert-notify-handler with the
> respective descriptor.
Yes, that's exactly what I had expected.
> I'll check.
Thanks!
> Tassilo, would you be willing to write an ert test case for the problem?
Sure, I'm already working on it. :-)
Bye,
Tassilo
next prev parent reply other threads:[~2016-02-19 22:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-18 19:04 bug#22736: 25.0.91; file-notify calls wrong callbacks Tassilo Horn
2016-02-18 20:09 ` Eli Zaretskii
2016-02-19 8:46 ` Michael Albinus
2016-02-19 22:59 ` Tassilo Horn [this message]
2016-02-20 13:23 ` Michael Albinus
2016-02-21 8:02 ` Tassilo Horn
2016-02-21 9:01 ` Michael Albinus
2016-02-21 16:02 ` Tassilo Horn
2016-02-22 17:58 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874md4z4pt.fsf@gnu.org \
--to=tsdh@gnu.org \
--cc=22736@debbugs.gnu.org \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).