unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Óscar Fuentes" <ofv@wanadoo.es>
To: Eli Zaretskii <eliz@gnu.org>
Cc: schwab@linux-m68k.org, 23075@debbugs.gnu.org,
	nikolay.kudryavtsev@gmail.com
Subject: bug#23075: 24.5; vc-git-command should use coding-system-for-read
Date: Mon, 21 Mar 2016 20:38:22 +0100	[thread overview]
Message-ID: <874mbzfwpd.fsf@wanadoo.es> (raw)
In-Reply-To: <83io0f669g.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 21 Mar 2016 20:22:03 +0200")

Eli Zaretskii <eliz@gnu.org> writes:

>> Does git always use that encoding? If not, on what it depends the
>> encoding used by git?
>
> It just spews the bytes, AFAIK.  IOW, it's the encoding of the file
> whose log we are viewing.

I was expecting from HELLO to be utf-8, but you are right.

Please note that a diff may contain changes from multiple files,
including some that do not longer exists (or that exists with another
encoding). So we can't process a diff as a single unit, it must be
separated by file.

Solving this on a general way does not seem possible, but we can do our
best by using the file's current encoding, or simply guessing it. The
former can have serious performance implications.





  reply	other threads:[~2016-03-21 19:38 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-21 11:22 bug#23075: 24.5; vc-git-command should use coding-system-for-read Nikolay Kudryavtsev
2016-03-21 16:16 ` Eli Zaretskii
2016-03-21 16:54   ` Óscar Fuentes
2016-03-21 17:21     ` Eli Zaretskii
2016-03-21 17:57     ` Andreas Schwab
2016-03-21 18:05       ` Óscar Fuentes
2016-03-21 18:22         ` Eli Zaretskii
2016-03-21 19:38           ` Óscar Fuentes [this message]
2016-04-02 10:02             ` Eli Zaretskii
2016-03-21 18:20       ` Eli Zaretskii
2016-03-21 18:45         ` Nikolay Kudryavtsev
2016-03-21 19:17           ` Eli Zaretskii
2016-03-21 19:35             ` Nikolay Kudryavtsev
2016-04-02  9:58           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874mbzfwpd.fsf@wanadoo.es \
    --to=ofv@wanadoo.es \
    --cc=23075@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=nikolay.kudryavtsev@gmail.com \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).